> As seen in the unit test of the PR, when we click on the area above/below the > scrollbar the position jumps - but the jump is now not always consistent. > In the current version on the last cell - the UI always jumps to the top. In > the other cases, the assumed default cell height is used. > > With this PR, always the default cell height is used, to determine how much > is scrolled. > This makes the behavior more consistent. > > Especially from the unit-test, it's clear that with this PR the behavior is > much more consistent. > > This is also related to the following PR: > https://github.com/openjdk/jfx/pull/1194
Florian Kirmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8323511-scrollbar-jump - JDK-8323511: Adjust javadoc of the getViewportLength() - JDK-8323511: Mage getViewportLength() public and use it instead of getBlockIncrement() - JDK-8323511: Use viewport length as block increment - JDK-8323511: Fix scrolling when clicking the scrollbar track when only one cell is visible - JDK-8323511 reverted accidental indentation chang - JDK-8323511 Making the scrolled height consistent, when abvoe/below the scrollbar is clicked. ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1326/files - new: https://git.openjdk.org/jfx/pull/1326/files/645feee3..f16cff94 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1326&range=06 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1326&range=05-06 Stats: 381640 lines in 7736 files changed: 219841 ins; 105079 del; 56720 mod Patch: https://git.openjdk.org/jfx/pull/1326.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1326/head:pull/1326 PR: https://git.openjdk.org/jfx/pull/1326
