On Wed, 15 May 2024 21:58:46 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> README-code-reviews.md line 14: >> >>> 12: ### Reviewers >>> 13: >>> 14: The [List of Reviewers](https://openjdk.java.net/census#openjfx) is on >>> the OpenJDK Census. >> >> We use ".org" now, not ".java.net" > > Yes, I missed this. I'll update. fixed >> README-code-reviews.md line 40: >> >>> 38: ### 1. The Reviewer role for the OpenJFX Project >>> 39: >>> 40: We define a formal "Reviewer" role, similar to the JDK project. A >>> [Reviewer](https://openjdk.java.net/census#openjfx) is responsible for >>> reviewing code changes and helping to determine whether a change is >>> suitable for including into OpenJFX. We expect Reviewers to feel >>> responsible not just for their piece, but for the quality of the JavaFX >>> library as a whole. In other words, the role of Reviewer is one of >>> stewardship. See the following section for what constitutes a good review. >> >> (https://openjdk.java.net/census#openjfx) >> >> .org please >> >> BTW these very long source lines make it awkward to precisely identify the >> text I'm commenting on. > > I'll fix it. fixed >> README-code-reviews.md line 77: >> >>> 75: >>> 76: * All substantive feedback has been addressed, especially any >>> objections from one with a Reviewer role. >>> 77: * All Reviewers who have requested the chance to review have done so >>> (or indicated that they are OK with it going in without their review). In >>> rare cases a Project Lead may override this. >> >> One thing to add here (or hereabouts) is that if someone has commented on >> your review and requested changes that in almost all cases you should expect >> that they will want to return to review the results. So DO NOT push without >> letting earlier reviewers who made substantive comments re-review. > > I'll add something about this. fixed ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605064310 PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605064515 PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605064857
