On Wed, 15 May 2024 22:05:46 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> README-code-reviews.md line 60: >> >>> 58: * If you want an area expert to review a PR, indicate this in a comment >>> of the form: `Reviewers: @PERSON1 @PERSON2`; the requested reviewers can >>> indicate whether or not they plan to review it >>> 59: * If you want to ensure that you have the opportunity to review this PR >>> yourself, add a comment of the form: `@PRAUTHOR Wait for me to review this >>> PR`, optionally add any concerns you might have >>> 60: >> >> Another thing to look out for is the targeting branch during rampdown. >> Should they all target master and then be backported as needed, or can some >> target the rampdown branch? > > Good idea. I'll add the bit about checking the target branch -- if the PR > isn't a backport it should almost always target the master branch (there > might be _very_ rare exception where a bug is specific to the stabilization > branch). fixed >> README-code-reviews.md line 69: >> >>> 67: * Check whether there is an automated test; if not, ask for one, if it >>> is feasible >>> 68: * Make sure that the PR has executed the GHA tests and that they all >>> pass; if they aren't being run, ask the PR author to enable GHA workflows >>> 69: * If the PR source branch hasn't synced up from master in a long time, >>> or if there is an upstream commit not in the source branch that might >>> interfere with the PR, ask the PR author to merge the latest upstream >>> master. >> >> This is the only bullet point with a period at the end. > > I'll fix it. fixed ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605062508 PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605062271
