On Wed, 6 Sep 2023 05:21:03 GMT, Karthik P K wrote:
>> Added test: `testChartLineAndAreaRemovedOnClearingSeries()` for
>> `StackedAreaChart` to check if the line and fill elements gets removed from
>> the series on clearing the series. This test is added similar to the tests
>> added to `LineC
On Tue, 5 Sep 2023 23:36:25 GMT, Jose Pereda wrote:
> Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
> Reviewed-by: aghaisas, angorya
>
> There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:
>
>
> -setSkin(new SkinStub(this));
> +
On Tue, 5 Sep 2023 20:18:52 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/ChoiceBoxScrollUpOnCollectionChangeTest.java
>
> Made changes to use Util::waitForIdle instead of Toolkit::firePulse in system
> tests. The test will wait for default value of 10 pulses to complete in the
> scene before executing the subsequent statements.
Karthik P K has updated the pull request incrementally with one additional
commit sin
> Added test: `testChartLineAndAreaRemovedOnClearingSeries()` for
> `StackedAreaChart` to check if the line and fill elements gets removed from
> the series on clearing the series. This test is added similar to the tests
> added to `LineChart` and `AreaChart`.
> This test is not required for `Ba
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
On Tue, 5 Sep 2023 23:27:44 GMT, Andy Goryachev wrote:
>> It is documented in the `Platform.Preferences` interface, which is
>> implemented by this class:
>>
>>
>> /**
>> * Returns the value to which the specified key is mapped.
>> *
>> * @param the type of
On Tue, 5 Sep 2023 19:56:56 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed application preferences implementation
>
> modules/javafx.graphics/src/test/java/test/com/sun/javafx/applica
On Tue, 5 Sep 2023 23:18:22 GMT, Andy Goryachev wrote:
>> No. This map is only used by `QuantumToolkit` to initialize the preferences.
>> The implementation should not keep this map around, and an immutability
>> guarantee might be seen as an invitation to do so.
>
> would it make sense to add
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
On Tue, 5 Sep 2023 21:37:38 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed application preferences implementation
>
> modules/javafx.graphics/src/main/java/javafx/application/Platform
On Tue, 5 Sep 2023 23:26:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
Reviewed-by: aghaisas, angorya
There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:
-setSkin(new SkinStub(this));
+setSkin(new SkinStub<>(this));
-
Commit messages:
-
On Tue, 5 Sep 2023 23:30:39 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line
>> 466:
>>
>>> 464: * so applications should not assume that a particular preference
>>> is always available.
>>> 465: *
>>> 466: * The followin
On Tue, 5 Sep 2023 23:21:18 GMT, Andy Goryachev wrote:
>> It doesn't handle _removals_ of keys in `current`, which is explained in the
>> method documentation:
>>
>> "Returns a map that contains the _new or changed_ mappings of _current_
>> compared to _old_.
>> A value has changed if _Objects
On Tue, 5 Sep 2023 20:21:54 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed application preferences implementation
>
> modules/javafx.graphics/src/main/java/javafx/application/Platfor
On Tue, 5 Sep 2023 23:07:03 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/PlatformPreferences.java
>> line 112:
>>
>>> 110: }
>>> 111:
>>> 112: throw new IllegalArgumentException(
>>
>> should this behavior be docume
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
On Tue, 5 Sep 2023 20:16:45 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/Application.java
>> line 35:
>>
>>> 33: import javafx.css.Stylesheet;
>>> 34: import javafx.scene.Scene;
>>> 35: import javafx.scene.paint.Color;
>>
>> strictly speaking, this fi
On Tue, 5 Sep 2023 22:51:28 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Application.java line
>> 762:
>>
>>> 760: */
>>> 761: public Map getPlatformPreferences() {
>>> 762: return Map.of();
>>
>> Should javadoc explicitly proclaim that
On Tue, 5 Sep 2023 19:30:30 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed application preferences implementation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/
On Tue, 5 Sep 2023 19:26:50 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed application preferences implementation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/
On Tue, 5 Sep 2023 19:21:39 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed application preferences implementation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/
On Tue, 5 Sep 2023 19:18:04 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed application preferences implementation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/
On Tue, 5 Sep 2023 19:11:20 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed application preferences implementation
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Applicatio
On Tue, 5 Sep 2023 18:45:50 GMT, Andy Goryachev wrote:
> > I think it would best to remove BitSet
>
> does it mean there'll be a followup PR?
Filing a follow-up cleanup bug seems reasonable, but not urgent, especially now
that BitSet is immutable . The problems pointed out are (largely, if not
On Tue, 5 Sep 2023 00:55:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Tue, 5 Sep 2023 21:31:23 GMT, Kevin Rushforth wrote:
>> All I actually want is a link to the platform keys, not to the Properties
>> class per se.
>> Perhaps something similar to what String.format() does.
>
> Hmm, maybe. In that case, the description seems the best place for that sort
> o
On Tue, 5 Sep 2023 21:12:09 GMT, Andy Goryachev wrote:
>> Yes, I know that `{@code}` shows up in monospace font, while `{@link}`
>> provides the link. It does that in the javadoc-generated API docs, too.
>>
>> What I meant by my comment is that since the method in question returns a
>> `Prefer
On Tue, 5 Sep 2023 21:06:38 GMT, Kevin Rushforth wrote:
>> not in Eclipse. {@code} shows up in monospace font, while {@link} provides
>> the link:
>>
>> > src="https://github.com/openjdk/jfx/assets/107069028/e7e39445-226a-48b2-8154-429e66683243";>
>
> Yes, I know that `{@code}` shows up in mon
On Tue, 5 Sep 2023 20:44:19 GMT, Andy Goryachev wrote:
>> I think there is no need to make this a link, since the return type of the
>> method already provides the link.
>
> not in Eclipse. {@code} shows up in monospace font, while {@link} provides
> the link:
>
> src="https://github.com/ope
On Tue, 5 Sep 2023 20:19:11 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line
>> 448:
>>
>>> 446: * by JavaFX when the operating system reports that a platform
>>> preference has changed.
>>> 447: *
>>> 448: * @return the
On Tue, 5 Sep 2023 20:12:36 GMT, Jose Pereda wrote:
> Clean backport of 8289751: Multiple unit test failures after JDK-8251483
> Reviewed-by: kcr
This pull request has now been integrated.
Changeset: 289ac761
Author:Jose Pereda
URL:
https://git.openjdk.org/jfx17u/commit/289ac761451a
On Tue, 5 Sep 2023 19:41:33 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed application preferences implementation
>
> modules/javafx.graphics/src/main/java/javafx/application/Applicat
On Tue, 5 Sep 2023 00:55:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Mon, 4 Sep 2023 10:47:02 GMT, Karthik P K wrote:
> Made changes to use Util::waitForIdle instead of Toolkit::firePulse in system
> tests. The test will wait for default value of 10 pulses to complete in the
> scene before executing the subsequent statements.
tests/system/src/test/java/test/
Clean backport of 8289751: Multiple unit test failures after JDK-8251483
Reviewed-by: kcr
-
Commit messages:
- 8289751: Multiple unit test failures after JDK-8251483
Changes: https://git.openjdk.org/jfx17u/pull/153/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=153&range
On Tue, 5 Sep 2023 18:59:56 GMT, Jose Pereda wrote:
> Clean backport of 8251483: TableCell: NPE on modifying item's list
> Reviewed-by: aghaisas, mstrauss
This pull request has now been integrated.
Changeset: 0985af97
Author:Jose Pereda
URL:
https://git.openjdk.org/jfx17u/commit/098
On Tue, 5 Sep 2023 00:55:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had t
On Mon, 4 Sep 2023 13:15:47 GMT, Karthik P K wrote:
> Added test: `testChartLineAndAreaRemovedOnClearingSeries()` for
> `StackedAreaChart` to check if the line and fill elements gets removed from
> the series on clearing the series. This test is added similar to the tests
> added to `LineChart
Clean backport of 8251483: TableCell: NPE on modifying item's list
Reviewed-by: aghaisas, mstrauss
-
Commit messages:
- 8251483: TableCell: NPE on modifying item's list
Changes: https://git.openjdk.org/jfx17u/pull/152/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=152&ra
On Tue, 5 Sep 2023 17:55:23 GMT, Johan Vos wrote:
> 8251481: TableCell accessing row: NPE on auto-sizing
> Reviewed-by: fastegal
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jfx17u/pull/151
On Tue, 5 Sep 2023 17:02:40 GMT, Jose Pereda wrote:
> Clean backport of 8251481: TableCell accessing row: NPE on auto-sizing
> Reviewed-by: fastegal
This pull request has now been integrated.
Changeset: 2e56cc0e
Author:Jose Pereda
URL:
https://git.openjdk.org/jfx17u/commit/2e56cc0e7
On Tue, 5 Sep 2023 17:55:23 GMT, Johan Vos wrote:
> 8251481: TableCell accessing row: NPE on auto-sizing
> Reviewed-by: fastegal
duplicate PR to investigate why it wasn't a clean BP.
-
PR Comment: https://git.openjdk.org/jfx17u/pull/151#issuecomment-1707154738
On Tue, 5 Sep 2023 17:02:40 GMT, Jose Pereda wrote:
> Clean backport of 8251481: TableCell accessing row: NPE on auto-sizing
> Reviewed-by: fastegal
Marked as reviewed by jvos (Reviewer).
-
PR Review: https://git.openjdk.org/jfx17u/pull/150#pullrequestreview-1611725107
On Tue, 5 Sep 2023 13:07:55 GMT, John Hendrikx wrote:
> I think it would best to remove `BitSet`
does it mean there'll be a followup PR? or should it be done as a part of this
one?
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1076#discussion_r1316269856
On Tue, 5 Sep 2023 09:22:58 GMT, Jose Pereda wrote:
> Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
> Reviewed-by: aghaisas, angorya
>
> There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:
>
> -setSkin(new SkinStub(this));
> +
On Tue, 5 Sep 2023 09:22:58 GMT, Jose Pereda wrote:
> Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
> Reviewed-by: aghaisas, angorya
>
> There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:
>
> -setSkin(new SkinStub(this));
> +
8251481: TableCell accessing row: NPE on auto-sizing
Reviewed-by: fastegal
-
Commit messages:
- 8251481: TableCell accessing row: NPE on auto-sizing
Changes: https://git.openjdk.org/jfx17u/pull/151/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=151&range=00
Issue: http
Clean backport of 8251481: TableCell accessing row: NPE on auto-sizing
Reviewed-by: fastegal
-
Commit messages:
- 8251481: TableCell accessing row: NPE on auto-sizing
Changes: https://git.openjdk.org/jfx17u/pull/150/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=150&rang
On Mon, 14 Aug 2023 16:17:29 GMT, Hima Bindu Meda wrote:
>> Minimum version of python ,to run webkit build , on linux is set to 3.6 and
>> for other platforms, minimum version of python is set to 3.8.
>>
>> Verified build on all platforms. No issue seen
>
> Hima Bindu Meda has updated the pull
On Mon, 4 Sep 2023 09:40:14 GMT, Johan Vos wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' of https://git.openjdk.org/jfx into
>>feature/immutable-pseudoclasss
On Tue, 5 Sep 2023 13:09:46 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line
>> 549:
>>
>>> 547:
>>> 548: for (int i = 0; i < max; i++) {
>>> 549: long m0 = i >= a ? 0 : this.bits[i];
>>
>> Are we guaranteed that it is
On Mon, 4 Sep 2023 13:15:47 GMT, Karthik P K wrote:
> Added test: `testChartLineAndAreaRemovedOnClearingSeries()` for
> `StackedAreaChart` to check if the line and fill elements gets removed from
> the series on clearing the series. This test is added similar to the tests
> added to `LineChart
On Tue, 5 Sep 2023 09:22:58 GMT, Jose Pereda wrote:
> Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
> Reviewed-by: aghaisas, angorya
>
> There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:
>
> -setSkin(new SkinStub(this));
> +
Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
Reviewed-by: aghaisas, angorya
There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:
-setSkin(new SkinStub(this));
+setSkin(new SkinStub<>(this));
-
Commit messages:
-
On Mon, 4 Sep 2023 09:10:18 GMT, Jose Pereda wrote:
> Almost clean backport of 8089280: horizontal scrollbar should never become
> visible in TableView with constrained resize policy
>
> Reviewed-by: kcr, aghaisas
>
> It had some minor conflicts from JDK-8089280 (TableViewSkinBase: copyright
On Mon, 4 Sep 2023 09:10:18 GMT, Jose Pereda wrote:
> Almost clean backport of 8089280: horizontal scrollbar should never become
> visible in TableView with constrained resize policy
>
> Reviewed-by: kcr, aghaisas
>
> It had some minor conflicts from JDK-8089280 (TableViewSkinBase: copyright
On Mon, 14 Aug 2023 16:17:29 GMT, Hima Bindu Meda wrote:
>> Minimum version of python ,to run webkit build , on linux is set to 3.6 and
>> for other platforms, minimum version of python is set to 3.8.
>>
>> Verified build on all platforms. No issue seen
>
> Hima Bindu Meda has updated the pull
61 matches
Mail list logo
