On Tue, 5 Sep 2023 23:18:22 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> No. This map is only used by `QuantumToolkit` to initialize the preferences. 
>> The implementation should not keep this map around, and an immutability 
>> guarantee might be seen as an invitation to do so.
>
> would it make sense to add this explanation to javadoc, even though it's not 
> a public API?

I've added the following sentence:

Callers should assume that the returned map is immutable, while implementations 
should
either return an immutable map, or give up ownership of the returned map.


What do you think?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1316535413

Reply via email to