On Tue, 5 Sep 2023 20:21:54 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removed application preferences implementation > > modules/javafx.graphics/src/main/java/javafx/application/Platform.java line > 466: > >> 464: * so applications should not assume that a particular preference >> is always available. >> 465: * <p> >> 466: * The following list contains all preferences that are potentially >> available on the specified platforms: > > Is it possible that a preference might be stored that isn't in the below > list? Or is it guaranteed that the _only_ possible preferences that will ever > be stored are those documented here? If the former, I recommend removing the > word "all". If the latter, then it is OK as is, if we are comfortable > specifying this. I think we should indeed document _all_ possible preferences for the platform toolkit implementations we control. Of course, this means that we need to keep this list in sync with the actual implementation. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1316516566
