On Tue, 5 Sep 2023 19:11:20 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed application preferences implementation
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Application.java line
> 762:
>
>> 760: */
>> 761: public Map<String, Object> getPlatformPreferences() {
>> 762: return Map.of();
>
> Should javadoc explicitly proclaim that the map is immutable?
No. This map is only used by `QuantumToolkit` to initialize the preferences.
The implementation should not keep this map around, and an immutability
guarantee might be seen as an invitation to do so.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1316494811
