pjfanning commented on PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#issuecomment-2479499590
I'll merge to unblock projection work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
pjfanning merged PR #175:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
pjfanning commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1840928034
##
core/src/main/scala/org/apache/pekko/persistence/r2dbc/query/scaladsl/mysql/MySQLQueryDao.scala:
##
@@ -0,0 +1,83 @@
+/*
Review Comment:
this lo
pjfanning commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1840927349
##
core/src/main/scala/org/apache/pekko/persistence/r2dbc/state/scaladsl/mysql/MySQLDurableStateDao.scala:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the
pjfanning commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1840925249
##
docker/docker-compose-mysql.yml:
##
@@ -0,0 +1,13 @@
+services:
Review Comment:
can you add a license header like the one on the create sql
-
pjfanning commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1840924626
##
ddl-scripts/drop_tables_mysql.sql:
##
@@ -0,0 +1,6 @@
+DROP TABLE IF EXISTS event_journal;
Review Comment:
can you add the same license header f
pjfanning commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1840792343
##
core/src/main/resources/reference.conf:
##
@@ -101,7 +101,7 @@ pekko.persistence.r2dbc {
// #connection-settings
pekko.persistence.r2dbc {
- #
ptrdom commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1840816417
##
core/src/main/resources/reference.conf:
##
@@ -101,7 +101,7 @@ pekko.persistence.r2dbc {
// #connection-settings
pekko.persistence.r2dbc {
- # pos
ptrdom commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1840760448
##
core/src/main/scala/org/apache/pekko/persistence/r2dbc/query/scaladsl/mysql/MySQLQueryDao.scala:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Sof
ptrdom commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1840757435
##
core/src/main/resources/reference.conf:
##
@@ -101,7 +101,7 @@ pekko.persistence.r2dbc {
// #connection-settings
pekko.persistence.r2dbc {
- # pos
pjfanning commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1838754491
##
ddl-scripts/create_tables_mysql.sql:
##
@@ -0,0 +1,95 @@
+CREATE TABLE IF NOT EXISTS event_journal(
Review Comment:
Is it possible to add a sour
pjfanning commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1838749967
##
core/src/main/scala/org/apache/pekko/persistence/r2dbc/query/scaladsl/mysql/MySQLQueryDao.scala:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache
pjfanning commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1838749284
##
core/src/main/resources/reference.conf:
##
@@ -101,7 +101,7 @@ pekko.persistence.r2dbc {
// #connection-settings
pekko.persistence.r2dbc {
- #
pjfanning commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1838746770
##
core/src/main/scala/org/apache/pekko/persistence/r2dbc/R2dbcSettings.scala:
##
@@ -92,6 +93,7 @@ sealed trait Dialect
object Dialect {
case obje
ptrdom commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1838450434
##
core/src/main/resources/reference.conf:
##
@@ -101,7 +101,7 @@ pekko.persistence.r2dbc {
// #connection-settings
pekko.persistence.r2dbc {
- # pos
ptrdom commented on code in PR #175:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1838447816
##
core/src/main/resources/reference.conf:
##
@@ -101,7 +101,7 @@ pekko.persistence.r2dbc {
// #connection-settings
pekko.persistence.r2dbc {
- # pos
ptrdom opened a new pull request, #175:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/175
Partially resolves
https://github.com/apache/pekko-persistence-r2dbc/issues/158.
Split off from https://github.com/apache/pekko-persistence-r2dbc/pull/170.
--
This is an automated me
17 matches
Mail list logo
