pjfanning commented on code in PR #175: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1840928034
########## core/src/main/scala/org/apache/pekko/persistence/r2dbc/query/scaladsl/mysql/MySQLQueryDao.scala: ########## @@ -0,0 +1,83 @@ +/* Review Comment: this looks brand new (no code copied from an existing source file) - therefore, could you use the standard license header (like the create sql)? ########## core/src/main/scala/org/apache/pekko/persistence/r2dbc/journal/mysql/MySQLJournalDao.scala: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: this looks brand new (no code copied from an existing source file) - therefore, could you use the standard license header (like the create sql)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
