pjfanning commented on code in PR #175: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1838746770
########## core/src/main/scala/org/apache/pekko/persistence/r2dbc/R2dbcSettings.scala: ########## @@ -92,6 +93,7 @@ sealed trait Dialect object Dialect { case object Postgres extends Dialect case object Yugabyte extends Dialect + case object MySQL extends Dialect Review Comment: could you add `@since 1.1.0` in scaladoc on this new object? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org