ptrdom commented on code in PR #175:
URL: 
https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1840757435


##########
core/src/main/resources/reference.conf:
##########
@@ -101,7 +101,7 @@ pekko.persistence.r2dbc {
 // #connection-settings
 pekko.persistence.r2dbc {
 
-  # postgres or yugabyte
+  # postgres, yugabyte or mysql

Review Comment:
   Config differences between dialects are expressed here:
   
https://github.com/apache/pekko-persistence-r2dbc/blob/daa27a750d3074f916b02a8c83b8b00674f0aea4/core/src/test/scala/org/apache/pekko/persistence/r2dbc/TestConfig.scala#L24-L62
   So different drivers, default ports, credentials, database names, and with 
MySQL we require following to be set:
   ```
   db-timestamp-monotonic-increasing = on 
   use-app-timestamp = on 
   ```
   Journal will throw error upon initialization if these settings are in 
different values.
   
   I will try coming up with something more ergonomic, of course you can 
provide suggestions if you have preferences.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org

Reply via email to