ptrdom commented on code in PR #175: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/175#discussion_r1840760448
########## core/src/main/scala/org/apache/pekko/persistence/r2dbc/query/scaladsl/mysql/MySQLQueryDao.scala: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * license agreements; and to You under the Apache License, version 2.0: + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * This file is part of the Apache Pekko project, which was derived from Akka. + */ + +package org.apache.pekko.persistence.r2dbc.query.scaladsl.mysql + +import java.time.Instant + +import scala.concurrent.ExecutionContext +import scala.concurrent.Future +import scala.concurrent.duration.Duration +import scala.concurrent.duration.FiniteDuration +import io.r2dbc.spi.ConnectionFactory +import org.apache.pekko +import pekko.actor.typed.ActorSystem +import pekko.persistence.r2dbc.R2dbcSettings +import pekko.persistence.r2dbc.internal.Sql.DialectInterpolation +import pekko.persistence.r2dbc.query.scaladsl.QueryDao + +class MySQLQueryDao( Review Comment: Ah, forgot to make these new classes `private`. I think they should be - if users really want to change journal's behavior they can always wire in their own, no need for us to maintain additional public API for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
