[GitHub] [ignite] asfgit closed pull request #10804: IGNITE-19818 SQL Calcite: Fix failure on planning when cache size exc…

2023-07-06 Thread via GitHub
asfgit closed pull request #10804: IGNITE-19818 SQL Calcite: Fix failure on planning when cache size exc… URL: https://github.com/apache/ignite/pull/10804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [ignite] Mmuzaf commented on a diff in pull request #10824: IGNITE-19915 Remove obsolete IgniteCacheSnapshotManager

2023-07-06 Thread via GitHub
Mmuzaf commented on code in PR #10824: URL: https://github.com/apache/ignite/pull/10824#discussion_r1254719884 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxLocalAdapter.java: ## @@ -816,22 +813,6 @@ else if (op == RELOAD) {

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10762: IGNITE-19158 Improve message about received partition file during sna…

2023-07-06 Thread via GitHub
sonarcloud[bot] commented on PR #10762: URL: https://github.com/apache/ignite/pull/10762#issuecomment-1624125352 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] nizhikov merged pull request #10824: IGNITE-19915 Remove obsolete IgniteCacheSnapshotManager

2023-07-06 Thread via GitHub
nizhikov merged PR #10824: URL: https://github.com/apache/ignite/pull/10824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-06 Thread via GitHub
sonarcloud[bot] commented on PR #10766: URL: https://github.com/apache/ignite/pull/10766#issuecomment-1624384090 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] dependabot[bot] opened a new pull request, #10828: Bump cassandra-all from 3.11.3 to 4.0.10 in /modules/cassandra/store

2023-07-06 Thread via GitHub
dependabot[bot] opened a new pull request, #10828: URL: https://github.com/apache/ignite/pull/10828 Bumps cassandra-all from 3.11.3 to 4.0.10. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.cassandra

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10828: Bump cassandra-all from 3.11.3 to 4.0.10 in /modules/cassandra/store

2023-07-06 Thread via GitHub
sonarcloud[bot] commented on PR #10828: URL: https://github.com/apache/ignite/pull/10828#issuecomment-1624450279 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] lowka commented on a diff in pull request #2282: IGNITE-17298 Sql. Support BOOLEAN type.

2023-07-06 Thread via GitHub
lowka commented on code in PR #2282: URL: https://github.com/apache/ignite-3/pull/2282#discussion_r1255262941 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSecondaryIndexTest.java: ## @@ -993,4 +993,60 @@ public void testSaturatedBoundsHashIn

[GitHub] [ignite-3] lowka commented on a diff in pull request #2282: IGNITE-17298 Sql. Support BOOLEAN type.

2023-07-06 Thread via GitHub
lowka commented on code in PR #2282: URL: https://github.com/apache/ignite-3/pull/2282#discussion_r1255262941 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSecondaryIndexTest.java: ## @@ -993,4 +993,60 @@ public void testSaturatedBoundsHashIn

[GitHub] [ignite-3] lowka commented on a diff in pull request #2271: IGNITE-19862: Revise error codes for SQL module

2023-07-06 Thread via GitHub
lowka commented on code in PR #2271: URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1255268774 ## modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java: ## @@ -117,92 +117,35 @@ public static class Sql { /** Session not found error. */

[GitHub] [ignite-3] lowka commented on a diff in pull request #2271: IGNITE-19862: Revise error codes for SQL module

2023-07-06 Thread via GitHub
lowka commented on code in PR #2271: URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1255271830 ## modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java: ## @@ -117,92 +117,35 @@ public static class Sql { /** Session not found error. */

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-06 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1624801732 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-06 Thread via GitHub
sonarcloud[bot] commented on PR #10766: URL: https://github.com/apache/ignite/pull/10766#issuecomment-1624845053 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2298: IGNITE-19609 Java client: Add data streamer metrics

2023-07-07 Thread via GitHub
ptupitsyn opened a new pull request, #2298: URL: https://github.com/apache/ignite-3/pull/2298 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite] nizhikov opened a new pull request, #10829: IGNITE-19918 idle_verify stat for compact footer usage added

2023-07-07 Thread via GitHub
nizhikov opened a new pull request, #10829: URL: https://github.com/apache/ignite/pull/10829 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10829: IGNITE-19918 idle_verify stat for compact footer usage added

2023-07-07 Thread via GitHub
sonarcloud[bot] commented on PR #10829: URL: https://github.com/apache/ignite/pull/10829#issuecomment-1625221719 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2273: IGNITE-15568 Implement batch log updates for RAFT.

2023-07-07 Thread via GitHub
SammyVimes commented on code in PR #2273: URL: https://github.com/apache/ignite-3/pull/2273#discussion_r1255612729 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DefaultLogStorageFactory.java: ## @@ -69,16 +70,24 @@ public class DefaultLogStorageFacto

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2273: IGNITE-15568 Implement batch log updates for RAFT.

2023-07-07 Thread via GitHub
ibessonov commented on code in PR #2273: URL: https://github.com/apache/ignite-3/pull/2273#discussion_r1255636041 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/StripeAwareLogManager.java: ## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software F

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2273: IGNITE-15568 Implement batch log updates for RAFT.

2023-07-07 Thread via GitHub
ibessonov commented on code in PR #2273: URL: https://github.com/apache/ignite-3/pull/2273#discussion_r1255638474 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DefaultLogStorageFactory.java: ## @@ -69,16 +70,24 @@ public class DefaultLogStorageFactor

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2273: IGNITE-15568 Implement batch log updates for RAFT.

2023-07-07 Thread via GitHub
ibessonov commented on code in PR #2273: URL: https://github.com/apache/ignite-3/pull/2273#discussion_r1255639570 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/StripeAwareLogManager.java: ## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software F

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10829: IGNITE-19918 idle_verify stat for compact footer usage added

2023-07-07 Thread via GitHub
sonarcloud[bot] commented on PR #10829: URL: https://github.com/apache/ignite/pull/10829#issuecomment-1625240522 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10829: IGNITE-19918 idle_verify stat for compact footer usage added

2023-07-07 Thread via GitHub
sonarcloud[bot] commented on PR #10829: URL: https://github.com/apache/ignite/pull/10829#issuecomment-1625250387 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] ptupitsyn merged pull request #2298: IGNITE-19609 Java client: Add data streamer metrics

2023-07-07 Thread via GitHub
ptupitsyn merged PR #2298: URL: https://github.com/apache/ignite-3/pull/2298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10829: IGNITE-19918 idle_verify stat for compact footer usage added

2023-07-07 Thread via GitHub
sonarcloud[bot] commented on PR #10829: URL: https://github.com/apache/ignite/pull/10829#issuecomment-1625276898 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] rpuch opened a new pull request, #2299: IGNITE-19932 Simplify handleChangePendingAssignmentEvent in TableManager

2023-07-07 Thread via GitHub
rpuch opened a new pull request, #2299: URL: https://github.com/apache/ignite-3/pull/2299 https://issues.apache.org/jira/browse/IGNITE-19932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite-3] sk0x50 opened a new pull request, #2300: IGNITE-19928 Fix method signature related to creating a new error group and registering a new error code

2023-07-07 Thread via GitHub
sk0x50 opened a new pull request, #2300: URL: https://github.com/apache/ignite-3/pull/2300 https://issues.apache.org/jira/browse/IGNITE-19928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [ignite] yurinaryshkin commented on a diff in pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-07 Thread via GitHub
yurinaryshkin commented on code in PR #10798: URL: https://github.com/apache/ignite/pull/10798#discussion_r1255890475 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/ByteBufferWalIterator.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to th

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-07 Thread via GitHub
ibessonov commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1255864196 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryRow.java: ## @@ -44,12 +47,11 @@ public interface BinaryRow { /** Get has value flag: {@

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-07 Thread via GitHub
sashapolo commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1255915228 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryRow.java: ## @@ -44,12 +47,11 @@ public interface BinaryRow { /** Get has value flag: {@

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-07 Thread via GitHub
sashapolo commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1255917053 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryRowImpl.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-07 Thread via GitHub
sashapolo commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1255920352 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -114,20 +105,22 @@ * BE means Big Endian,

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-07 Thread via GitHub
sashapolo commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1255921925 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -374,40 +366,47 @@ private void saveGroupCo

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-07 Thread via GitHub
sashapolo commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1255923525 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -657,21 +684,25 @@ private ReadResult readR

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-07 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1625511932 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-07 Thread via GitHub
sashapolo commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1255928122 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/io/RowVersionDataIo.java: ## @@ -50,46 +52,102 @@ protected RowVersionD

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-07 Thread via GitHub
sashapolo commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1255931129 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/ByteBufferRow.java: ## @@ -18,14 +18,11 @@ package org.apache.ignite.internal.schema; import ja

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-07 Thread via GitHub
sashapolo commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1255935892 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/io/RowVersionDataIo.java: ## @@ -50,46 +52,102 @@ protected RowVersionD

[GitHub] [ignite] nizhikov commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
nizhikov commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1255959009 ## modules/core/src/main/java/org/apache/ignite/internal/management/cdc/CdcDeleteLostSegmentsTask.java: ## @@ -102,69 +115,138 @@ protected CdcDeleteLostSegmentsJob(

[GitHub] [ignite] nizhikov commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
nizhikov commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1255959009 ## modules/core/src/main/java/org/apache/ignite/internal/management/cdc/CdcDeleteLostSegmentsTask.java: ## @@ -102,69 +115,138 @@ protected CdcDeleteLostSegmentsJob(

[GitHub] [ignite] nizhikov commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
nizhikov commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1255961857 ## modules/core/src/main/java/org/apache/ignite/internal/management/cdc/CdcDeleteLostSegmentsTask.java: ## @@ -102,69 +115,138 @@ protected CdcDeleteLostSegmentsJob(

[GitHub] [ignite] nizhikov commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
nizhikov commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1255963016 ## modules/core/src/main/java/org/apache/ignite/internal/management/cdc/CdcDeleteLostSegmentsTask.java: ## @@ -102,69 +115,138 @@ protected CdcDeleteLostSegmentsJob(

[GitHub] [ignite] nizhikov commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
nizhikov commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1255964521 ## modules/core/src/main/java/org/apache/ignite/internal/management/cdc/CdcDeleteLostSegmentsTask.java: ## @@ -102,69 +115,138 @@ protected CdcDeleteLostSegmentsJob(

[GitHub] [ignite] nizhikov commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
nizhikov commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1255964521 ## modules/core/src/main/java/org/apache/ignite/internal/management/cdc/CdcDeleteLostSegmentsTask.java: ## @@ -102,69 +115,138 @@ protected CdcDeleteLostSegmentsJob(

[GitHub] [ignite] nizhikov commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
nizhikov commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1255983617 ## modules/core/src/main/java/org/apache/ignite/internal/management/cdc/CdcDeleteLostSegmentsTask.java: ## @@ -102,69 +115,138 @@ protected CdcDeleteLostSegmentsJob(

[GitHub] [ignite] nizhikov commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
nizhikov commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1255987713 ## modules/core/src/main/java/org/apache/ignite/internal/management/cdc/CdcDeleteLostSegmentsTask.java: ## @@ -102,69 +115,138 @@ protected CdcDeleteLostSegmentsJob(

[GitHub] [ignite] nizhikov commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
nizhikov commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1255997863 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java: ## @@ -515,8 +521,18 @@ public void setFileIO

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
NSAmelchev commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1256003572 ## modules/core/src/main/java/org/apache/ignite/internal/management/cdc/CdcDeleteLostSegmentsTask.java: ## @@ -102,69 +115,138 @@ protected CdcDeleteLostSegmentsJo

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
NSAmelchev commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1256004639 ## modules/core/src/main/java/org/apache/ignite/internal/management/cdc/CdcDeleteLostSegmentsTask.java: ## @@ -102,69 +115,138 @@ protected CdcDeleteLostSegmentsJo

[GitHub] [ignite] nizhikov merged pull request #10829: IGNITE-19918 idle_verify stat for compact footer usage added

2023-07-07 Thread via GitHub
nizhikov merged PR #10829: URL: https://github.com/apache/ignite/pull/10829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
sonarcloud[bot] commented on PR #10766: URL: https://github.com/apache/ignite/pull/10766#issuecomment-1625589678 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] nizhikov commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
nizhikov commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1256025145 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java: ## @@ -1818,6 +1837,37 @@ public long maxWalS

[GitHub] [ignite] nizhikov commented on a diff in pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-07 Thread via GitHub
nizhikov commented on code in PR #10766: URL: https://github.com/apache/ignite/pull/10766#discussion_r1256025145 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java: ## @@ -1818,6 +1837,37 @@ public long maxWalS

[GitHub] [ignite-3] SammyVimes merged pull request #2299: IGNITE-19932 Simplify handleChangePendingAssignmentEvent in TableManager

2023-07-07 Thread via GitHub
SammyVimes merged PR #2299: URL: https://github.com/apache/ignite-3/pull/2299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] AMashenkov commented on pull request #2286: IGNITE-19499 TableManager should listen CatalogService events instead of configuration

2023-07-07 Thread via GitHub
AMashenkov commented on PR #2286: URL: https://github.com/apache/ignite-3/pull/2286#issuecomment-1625683835 Fixed the issue, when wrong default precision and scale values were passed to Catalog. DistributionZoneManager push changes to Catalog as well as to configuration. TableManager p

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-08 Thread via GitHub
sashapolo commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1257188253 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -374,40 +366,47 @@ private void saveGroupCo

[GitHub] [ignite] Noone-No opened a new issue, #10830: Apache ignite doc it’s like shit !!!!!!!

2023-07-08 Thread via GitHub
Noone-No opened a new issue, #10830: URL: https://github.com/apache/ignite/issues/10830 Who wrote it ? have you tested it ? Does your sample code work ? Can you actually write documentation ? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [ignite] Shoothzj opened a new pull request, #10831: IGNITE-18830 Optimize log in GridQueryProcessor

2023-07-09 Thread via GitHub
Shoothzj opened a new pull request, #10831: URL: https://github.com/apache/ignite/pull/10831 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10831: IGNITE-18830 Optimize log in GridQueryProcessor

2023-07-09 Thread via GitHub
sonarcloud[bot] commented on PR #10831: URL: https://github.com/apache/ignite/pull/10831#issuecomment-1627651712 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] isapego commented on a diff in pull request #2284: IGNITE-19212 ODBC: Implement basic query execution

2023-07-09 Thread via GitHub
isapego commented on code in PR #2284: URL: https://github.com/apache/ignite-3/pull/2284#discussion_r1257565750 ## modules/platforms/cpp/ignite/client/detail/sql/result_set_impl.h: ## @@ -154,15 +154,15 @@ class result_set_impl : public std::enable_shared_from_this { *

[GitHub] [ignite-3] isapego commented on a diff in pull request #2284: IGNITE-19212 ODBC: Implement basic query execution

2023-07-09 Thread via GitHub
isapego commented on code in PR #2284: URL: https://github.com/apache/ignite-3/pull/2284#discussion_r1257565841 ## modules/platforms/cpp/ignite/odbc/query/cursor.h: ## @@ -0,0 +1,74 @@ +/* + * Copyright 2019 GridGain Systems, Inc. and Contributors. Review Comment: Fixed.

[GitHub] [ignite] ptupitsyn commented on issue #10830: Apache ignite doc is not good!

2023-07-09 Thread via GitHub
ptupitsyn commented on issue #10830: URL: https://github.com/apache/ignite/issues/10830#issuecomment-1628141514 Please describe the problems in more detail: which sample code is broken and why. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2302: IGNITE-19935 Allow combining individual colocation hashes

2023-07-09 Thread via GitHub
ptupitsyn opened a new pull request, #2302: URL: https://github.com/apache/ignite-3/pull/2302 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-10 Thread via GitHub
ibessonov commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1257827649 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryRow.java: ## @@ -44,12 +47,11 @@ public interface BinaryRow { /** Get has value flag: {@

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-10 Thread via GitHub
ibessonov commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1257827649 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryRow.java: ## @@ -44,12 +47,11 @@ public interface BinaryRow { /** Get has value flag: {@

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-10 Thread via GitHub
ibessonov commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1257831184 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/ByteBufferRow.java: ## @@ -18,14 +18,11 @@ package org.apache.ignite.internal.schema; import ja

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-10 Thread via GitHub
ibessonov commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1257831597 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -114,20 +105,22 @@ * BE means Big Endian,

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-10 Thread via GitHub
ibessonov commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1257832406 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -657,21 +684,25 @@ private ReadResult readR

[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2259: IGNITE-19688 use waitAndGetLeader instead of waitLeader and getLeader

2023-07-10 Thread via GitHub
alievmirza commented on code in PR #2259: URL: https://github.com/apache/ignite-3/pull/2259#discussion_r1257863933 ## modules/raft/src/testFixtures/java/org/apache/ignite/raft/jraft/core/TestCluster.java: ## @@ -408,6 +408,26 @@ public void waitLeader() throws InterruptedExcepti

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2283: IGNITE-19903 Fix recovery descriptor race condition

2023-07-10 Thread via GitHub
ibessonov commented on code in PR #2283: URL: https://github.com/apache/ignite-3/pull/2283#discussion_r1257868088 ## modules/network/src/main/java/org/apache/ignite/internal/network/netty/ChannelCreationListener.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software F

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-10 Thread via GitHub
sashapolo commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1257891425 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryRow.java: ## @@ -44,12 +47,11 @@ public interface BinaryRow { /** Get has value flag: {@

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-10 Thread via GitHub
ibessonov commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1257977808 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryRow.java: ## @@ -44,12 +47,11 @@ public interface BinaryRow { /** Get has value flag: {@

[GitHub] [ignite-extensions] petrov-mg merged pull request #219: IGNITE-18548 Fix AbstractReplicationTest#checkMetrics

2023-07-10 Thread via GitHub
petrov-mg merged PR #219: URL: https://github.com/apache/ignite-extensions/pull/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [ignite-extensions] petrov-mg merged pull request #221: IGNITE-19901 Use all parameters in SQL tests of AbstractReplicationTest

2023-07-10 Thread via GitHub
petrov-mg merged PR #221: URL: https://github.com/apache/ignite-extensions/pull/221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2295: IGNITE-19810 Remove excessive BinaryRow buffer copying

2023-07-10 Thread via GitHub
sashapolo commented on code in PR #2295: URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1258010132 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryRow.java: ## @@ -44,12 +47,11 @@ public interface BinaryRow { /** Get has value flag: {@

[GitHub] [ignite-3] sk0x50 merged pull request #2291: IGNITE-19865 Fix propagating trace identifier

2023-07-10 Thread via GitHub
sk0x50 merged PR #2291: URL: https://github.com/apache/ignite-3/pull/2291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2282: IGNITE-17298 Sql. Support BOOLEAN type.

2023-07-10 Thread via GitHub
korlov42 commented on code in PR #2282: URL: https://github.com/apache/ignite-3/pull/2282#discussion_r1255678596 ## modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleReader.java: ## @@ -79,6 +80,34 @@ public boolean hasNullValue(int index) {

[GitHub] [ignite-3] vldpyatkov merged pull request #2259: IGNITE-19688 use waitAndGetLeader instead of waitLeader and getLeader

2023-07-10 Thread via GitHub
vldpyatkov merged PR #2259: URL: https://github.com/apache/ignite-3/pull/2259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-10 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1628929940 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-10 Thread via GitHub
timoninmaxim commented on code in PR #10798: URL: https://github.com/apache/ignite/pull/10798#discussion_r1258240204 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordV2Serializer.java: ## @@ -266,7 +265,7 @@ private stati

[GitHub] [ignite] petrov-mg opened a new pull request, #10832: IGNITE-18130 Refactored SslContextFactory to split loading KeyManagers and TrustManagers into two methods.

2023-07-10 Thread via GitHub
petrov-mg opened a new pull request, #10832: URL: https://github.com/apache/ignite/pull/10832 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### T

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10832: IGNITE-18130 Refactored SslContextFactory to split loading KeyManagers and TrustManagers into two methods.

2023-07-10 Thread via GitHub
sonarcloud[bot] commented on PR #10832: URL: https://github.com/apache/ignite/pull/10832#issuecomment-1629021695 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2273: IGNITE-15568 Implement batch log updates for RAFT.

2023-07-10 Thread via GitHub
alievmirza commented on code in PR #2273: URL: https://github.com/apache/ignite-3/pull/2273#discussion_r1258149634 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/disruptor/StripedDisruptor.java: ## @@ -214,7 +223,7 @@ void unsubscribe(NodeId nodeId) { as

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2296: IGNITE-19924 Test shouldn't guess id of newly created catalog object

2023-07-10 Thread via GitHub
korlov42 commented on code in PR #2296: URL: https://github.com/apache/ignite-3/pull/2296#discussion_r1258338255 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -148,18 +148,18 @@ public CatalogServiceImpl(UpdateLog updateLog,

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2296: IGNITE-19924 Test shouldn't guess id of newly created catalog object

2023-07-10 Thread via GitHub
korlov42 commented on code in PR #2296: URL: https://github.com/apache/ignite-3/pull/2296#discussion_r1258338255 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -148,18 +148,18 @@ public CatalogServiceImpl(UpdateLog updateLog,

[GitHub] [ignite] nizhikov commented on a diff in pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-10 Thread via GitHub
nizhikov commented on code in PR #10778: URL: https://github.com/apache/ignite/pull/10778#discussion_r1258369217 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/cdc/CdcBufferConsumer.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache S

[GitHub] [ignite] nizhikov commented on a diff in pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-10 Thread via GitHub
nizhikov commented on code in PR #10778: URL: https://github.com/apache/ignite/pull/10778#discussion_r1258369719 ## modules/core/src/main/java/org/apache/ignite/configuration/DataStorageConfiguration.java: ## @@ -252,6 +253,14 @@ public class DataStorageConfiguration implements

[GitHub] [ignite] nizhikov commented on a diff in pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-10 Thread via GitHub
nizhikov commented on code in PR #10778: URL: https://github.com/apache/ignite/pull/10778#discussion_r1258370397 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/cdc/CdcBufferConsumer.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache S

[GitHub] [ignite] nizhikov commented on a diff in pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-10 Thread via GitHub
nizhikov commented on code in PR #10778: URL: https://github.com/apache/ignite/pull/10778#discussion_r1258376597 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/cdc/CdcBufferConsumer.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache S

[GitHub] [ignite] yurinaryshkin commented on a diff in pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-10 Thread via GitHub
yurinaryshkin commented on code in PR #10798: URL: https://github.com/apache/ignite/pull/10798#discussion_r1258390484 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordV2Serializer.java: ## @@ -266,7 +265,7 @@ private stat

[GitHub] [ignite] yurinaryshkin commented on a diff in pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-10 Thread via GitHub
yurinaryshkin commented on code in PR #10798: URL: https://github.com/apache/ignite/pull/10798#discussion_r1258398881 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/ByteBufferWalIterator.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to th

[GitHub] [ignite] yurinaryshkin commented on a diff in pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-10 Thread via GitHub
yurinaryshkin commented on code in PR #10798: URL: https://github.com/apache/ignite/pull/10798#discussion_r1258401396 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/ByteBufferWalIterator.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to th

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-10 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1629206703 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] nizhikov commented on a diff in pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-10 Thread via GitHub
nizhikov commented on code in PR #10778: URL: https://github.com/apache/ignite/pull/10778#discussion_r1258496150 ## modules/core/src/main/java/org/apache/ignite/configuration/DataStorageConfiguration.java: ## @@ -252,6 +253,14 @@ public class DataStorageConfiguration implements

[GitHub] [ignite] nizhikov commented on a diff in pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-10 Thread via GitHub
nizhikov commented on code in PR #10778: URL: https://github.com/apache/ignite/pull/10778#discussion_r1258504633 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java: ## @@ -521,6 +525,9 @@ public void setFileIOF

[GitHub] [ignite] nizhikov commented on a diff in pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-10 Thread via GitHub
nizhikov commented on code in PR #10778: URL: https://github.com/apache/ignite/pull/10778#discussion_r1258519399 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/cdc/CdcProcessor.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite] nizhikov commented on a diff in pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-10 Thread via GitHub
nizhikov commented on code in PR #10778: URL: https://github.com/apache/ignite/pull/10778#discussion_r1258577210 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/cdc/CdcProcessor.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite] nizhikov commented on a diff in pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-10 Thread via GitHub
nizhikov commented on code in PR #10778: URL: https://github.com/apache/ignite/pull/10778#discussion_r1258581164 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/cdc/CdcProcessor.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite] nizhikov commented on a diff in pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-10 Thread via GitHub
nizhikov commented on code in PR #10778: URL: https://github.com/apache/ignite/pull/10778#discussion_r1258583730 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/cdc/CdcProcessor.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite-3] isapego commented on a diff in pull request #2302: IGNITE-19935 Allow combining individual colocation hashes [DRAFT]

2023-07-10 Thread via GitHub
isapego commented on code in PR #2302: URL: https://github.com/apache/ignite-3/pull/2302#discussion_r1258583924 ## modules/core/src/main/java/org/apache/ignite/internal/util/HashCalculator.java: ## @@ -170,8 +244,19 @@ public void appendNumber(BigInteger v) { * @param v Va

[GitHub] [ignite] nizhikov commented on a diff in pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-10 Thread via GitHub
nizhikov commented on code in PR #10778: URL: https://github.com/apache/ignite/pull/10778#discussion_r1258636609 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/cdc/CdcProcessor.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Softwa

<    8   9   10   11   12   13   14   15   16   17   >