[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2296: IGNITE-19924 Test shouldn't guess id of newly created catalog object

[via GitHub]

korlov42 commented on code in PR #2296:
URL: https://github.com/apache/ignite-3/pull/2296#discussion_r1258338255


##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java:
##########
@@ -148,18 +148,18 @@ public CatalogServiceImpl(UpdateLog updateLog, 
ClockWaiter clockWaiter, LongSupp
 
     @Override
     public void start() {
-        int objectIdGen = 0;
+        int objectIdGen = 1;
 
         // TODO: IGNITE-19082 Move default schema objects initialization to 
cluster init procedure.
         CatalogSchemaDescriptor schemaPublic = new CatalogSchemaDescriptor(
-                objectIdGen++,
+                0,
                 DEFAULT_SCHEMA_NAME,
                 new CatalogTableDescriptor[0],
                 new CatalogIndexDescriptor[0]
         );
 
         CatalogZoneDescriptor defaultZone = new CatalogZoneDescriptor(
-                objectIdGen++,
+                0,

Review Comment:
   why schema and zone are sharing the same id?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org