ibessonov commented on code in PR #2273:
URL: https://github.com/apache/ignite-3/pull/2273#discussion_r1255638474
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DefaultLogStorageFactory.java:
##########
@@ -69,16 +70,24 @@ public class DefaultLogStorageFactory implements
LogStorageFactory {
/** Data column family handle. */
private ColumnFamilyHandle dataHandle;
+ /**
+ * Thread-local batch instance, used by {@link
RocksDbSharedLogStorage#appendEntriesToBatch(List)} and
+ * {@link RocksDbSharedLogStorage#commitWriteBatch()}.
+ * <br>
+ * Shared between instances to provide more efficient way of executing
batch updates.
+ */
+ @SuppressWarnings("ThreadLocalNotStaticFinal")
+ private final ThreadLocal<WriteBatch> threadLocalWriteBatch = new
ThreadLocal<>();
Review Comment:
Well, one per node. I can make it static, it will work, I just thought that
non-static field makes more sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
