nizhikov commented on code in PR #10766:
URL: https://github.com/apache/ignite/pull/10766#discussion_r1255997863
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java:
##########
@@ -515,8 +521,18 @@ public void setFileIOFactory(FileIOFactory ioFactory) {
name, oldVal, newVal));
}
- if (newVal != null && newVal)
+ if (newVal != null && newVal) {
Review Comment:
A few linew below you check both values - `oldVal && !newVal`.
Here you check only `newVal`.
Does it mean that disable record can be recorded twice? When oldVal == newVal
So, it seems you should keep logic of both check consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
