yurinaryshkin commented on code in PR #10798:
URL: https://github.com/apache/ignite/pull/10798#discussion_r1258390484
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordV2Serializer.java:
##########
@@ -266,7 +265,7 @@ private static WALPointer readPositionAndCheckPoint(
int fileOff = in.readInt();
int len = in.readInt();
- if (!F.eq(idx, expPtr.index()) || (!skipPositionCheck &&
!F.eq(fileOff, expPtr.fileOffset())))
+ if (expPtr != null && (!F.eq(idx, expPtr.index()) ||
(!skipPositionCheck && !F.eq(fileOff, expPtr.fileOffset()))))
Review Comment:
In ByteBufferWalIterator we pass null as expPtr and that's why the pointer
check is not executed here. I think this is the minimum change that we can do
in the serializer class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
