[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

2023-07-03 Thread via GitHub
korlov42 commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1250363722 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -838,33 +838,38 @@ private CompletableFuture close(boo

[GitHub] [ignite-3] zstan commented on a diff in pull request #2275: IGNITE-19644 Change DROP|ADD COLUMN IF (NOT) EXISTS syntax

2023-07-03 Thread via GitHub
zstan commented on code in PR #2275: URL: https://github.com/apache/ignite-3/pull/2275#discussion_r1250373230 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/internal/InternalSchemaTest.java: ## @@ -93,12 +92,23 @@ public void testDropColumns() {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2274: IGNITE-19892 Fix catalog module dependencies

2023-07-03 Thread via GitHub
korlov42 commented on code in PR #2274: URL: https://github.com/apache/ignite-3/pull/2274#discussion_r1250391461 ## modules/distribution-zones/build.gradle: ## @@ -26,6 +26,7 @@ dependencies { annotationProcessor project(":ignite-configuration-annotation-processor") an

[GitHub] [ignite-3] zstan commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

2023-07-03 Thread via GitHub
zstan commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1250404649 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -838,33 +838,38 @@ private CompletableFuture close(boolea

[GitHub] [ignite-3] ptupitsyn merged pull request #2276: IGNITE-19827 Java client: fix partition awareness node ids

2023-07-03 Thread via GitHub
ptupitsyn merged PR #2276: URL: https://github.com/apache/ignite-3/pull/2276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] sanpwc merged pull request #2258: IGNITE-19393 Java thin 3.0: testAccessLockedKeyTimesOut is flaky

2023-07-03 Thread via GitHub
sanpwc merged PR #2258: URL: https://github.com/apache/ignite-3/pull/2258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite-extensions] shishkovilja opened a new pull request, #221: IGNITE-19901 Add parameters usage to SQL tests of AbstractReplication…

2023-07-03 Thread via GitHub
shishkovilja opened a new pull request, #221: URL: https://github.com/apache/ignite-extensions/pull/221 …Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [ignite-3] valepakh opened a new pull request, #2278: IGNITE-19706 Add verification of deploy to majority

2023-07-03 Thread via GitHub
valepakh opened a new pull request, #2278: URL: https://github.com/apache/ignite-3/pull/2278 https://issues.apache.org/jira/browse/IGNITE-19706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-03 Thread via GitHub
timoninmaxim commented on code in PR #10798: URL: https://github.com/apache/ignite/pull/10798#discussion_r1250480380 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/wal/ByteBufferWalIteratorTest.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to

[GitHub] [ignite-extensions] shishkovilja commented on pull request #219: IGNITE-18548 Fix AbstractReplicationTest#checkMetrics

2023-07-03 Thread via GitHub
shishkovilja commented on PR #219: URL: https://github.com/apache/ignite-extensions/pull/219#issuecomment-1617684370 TC Run all tests: [#487 at 3 Jul 11:19](https://ci2.ignite.apache.org/buildConfiguration/IgniteExtensions_Tests_RunAllTests/7243189?hideProblemsFromDependencies=false&expandB

[GitHub] [ignite-extensions] shishkovilja commented on pull request #221: IGNITE-19901 Use all parameters in SQL tests of AbstractReplicationTest

2023-07-03 Thread via GitHub
shishkovilja commented on PR #221: URL: https://github.com/apache/ignite-extensions/pull/221#issuecomment-1617812293 TC Run all tests: [#638 at 3 Jul 12:18](https://ci.ignite.apache.org/buildConfiguration/IgniteExtensions_Tests_RunAllTests/7337615?hideProblemsFromDependencies=false&expandBu

[GitHub] [ignite-3] AMashenkov merged pull request #2274: IGNITE-19892 Fix catalog module dependencies

2023-07-03 Thread via GitHub
AMashenkov merged PR #2274: URL: https://github.com/apache/ignite-3/pull/2274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite] nizhikov closed pull request #10797: IGNITE-19753 Move task classes to commands

2023-07-03 Thread via GitHub
nizhikov closed pull request #10797: IGNITE-19753 Move task classes to commands URL: https://github.com/apache/ignite/pull/10797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-03 Thread via GitHub
sonarcloud[bot] commented on PR #10778: URL: https://github.com/apache/ignite/pull/10778#issuecomment-1618019186 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10820: IGNITE-19034 Added snapshot check status

2023-07-03 Thread via GitHub
sonarcloud[bot] commented on PR #10820: URL: https://github.com/apache/ignite/pull/10820#issuecomment-1618108707 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] zstan commented on pull request #2275: IGNITE-19644 Change DROP|ADD COLUMN IF (NOT) EXISTS syntax

2023-07-03 Thread via GitHub
zstan commented on PR #2275: URL: https://github.com/apache/ignite-3/pull/2275#issuecomment-1618157111 @AMashenkov done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [ignite-3] sanpwc opened a new pull request, #2279: IGNITE-19393 Add possibility to check transaction state

2023-07-03 Thread via GitHub
sanpwc opened a new pull request, #2279: URL: https://github.com/apache/ignite-3/pull/2279 https://issues.apache.org/jira/browse/IGNITE-19393 1. TestOnly IgniteImpl#txManager method added. 2. Assertion added in TxManagerImpl#changeState in order to check that changeState was succes

[GitHub] [ignite] yurinaryshkin commented on a diff in pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-03 Thread via GitHub
yurinaryshkin commented on code in PR #10798: URL: https://github.com/apache/ignite/pull/10798#discussion_r1250889586 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/wal/ByteBufferWalIteratorTest.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed t

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10817: IGNITE-19878 Restrict possibility to create two caches with the same schemas and index names

2023-07-03 Thread via GitHub
sonarcloud[bot] commented on PR #10817: URL: https://github.com/apache/ignite/pull/10817#issuecomment-1618282213 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] korlov42 opened a new pull request, #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-03 Thread via GitHub
korlov42 opened a new pull request, #2280: URL: https://github.com/apache/ignite-3/pull/2280 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10820: IGNITE-19034 Added snapshot check status

2023-07-03 Thread via GitHub
timoninmaxim commented on code in PR #10820: URL: https://github.com/apache/ignite/pull/10820#discussion_r1250843829 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java: ## @@ -464,6 +465,9 @@ public class Ign

[GitHub] [ignite-3] xtern commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-03 Thread via GitHub
xtern commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1251004704 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImpl.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [ignite-3] xtern commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-03 Thread via GitHub
xtern commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1251004704 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImpl.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2141: IGNITE-19578 Decrease count of lease messages to meta storage

2023-07-03 Thread via GitHub
vldpyatkov commented on code in PR #2141: URL: https://github.com/apache/ignite-3/pull/2141#discussion_r1250788223 ## modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/MultiActorPlacementDriverTest.java: ## @@ -91,7 +96,7 @@ /** * Th

[GitHub] [ignite-3] ptupitsyn merged pull request #2277: IGNITE-19808 .NET: Fix TestHandshakesFailedTimeout flakiness

2023-07-03 Thread via GitHub
ptupitsyn merged PR #2277: URL: https://github.com/apache/ignite-3/pull/2277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2141: IGNITE-19578 Decrease count of lease messages to meta storage

2023-07-03 Thread via GitHub
vldpyatkov commented on code in PR #2141: URL: https://github.com/apache/ignite-3/pull/2141#discussion_r1251068220 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java: ## @@ -89,32 +96,30 @@ public LeaseTracker(VaultManag

[GitHub] [ignite-3] rpuch opened a new pull request, #2281: IGNITE-19906 Check that table exists when going to destroy partition storage

2023-07-03 Thread via GitHub
rpuch opened a new pull request, #2281: URL: https://github.com/apache/ignite-3/pull/2281 https://issues.apache.org/jira/browse/IGNITE-19906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite-3] xtern opened a new pull request, #2282: IGNITE-17298 Enable BOOLEAN type

2023-07-03 Thread via GitHub
xtern opened a new pull request, #2282: URL: https://github.com/apache/ignite-3/pull/2282 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-03 Thread via GitHub
AMashenkov commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1251218670 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java: ## @@ -183,19 +174,25 @@ public void onSchemaUpdated() {

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-03 Thread via GitHub
AMashenkov commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1251226494 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImpl.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software F

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10820: IGNITE-19034 Added snapshot check status

2023-07-03 Thread via GitHub
sonarcloud[bot] commented on PR #10820: URL: https://github.com/apache/ignite/pull/10820#issuecomment-1619100159 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #2141: IGNITE-19578 Decrease count of lease messages to meta storage

2023-07-03 Thread via GitHub
denis-chudov commented on code in PR #2141: URL: https://github.com/apache/ignite-3/pull/2141#discussion_r1251260517 ## modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/MultiActorPlacementDriverTest.java: ## @@ -91,7 +96,7 @@ /** *

[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #2141: IGNITE-19578 Decrease count of lease messages to meta storage

2023-07-03 Thread via GitHub
denis-chudov commented on code in PR #2141: URL: https://github.com/apache/ignite-3/pull/2141#discussion_r1251261351 ## modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java: ## @@ -1087,4 +1088,56 @@ public static boolean startsWith(byte[] key, byte[] pre

[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #2141: IGNITE-19578 Decrease count of lease messages to meta storage

2023-07-03 Thread via GitHub
denis-chudov commented on code in PR #2141: URL: https://github.com/apache/ignite-3/pull/2141#discussion_r1251263393 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java: ## @@ -207,17 +215,25 @@ public void deactivate() {

[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #2141: IGNITE-19578 Decrease count of lease messages to meta storage

2023-07-03 Thread via GitHub
denis-chudov commented on code in PR #2141: URL: https://github.com/apache/ignite-3/pull/2141#discussion_r1251263730 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java: ## @@ -305,14 +328,33 @@ public void run() {

[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #2141: IGNITE-19578 Decrease count of lease messages to meta storage

2023-07-03 Thread via GitHub
denis-chudov commented on code in PR #2141: URL: https://github.com/apache/ignite-3/pull/2141#discussion_r1251264742 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java: ## @@ -328,28 +370,17 @@ public void run() { * @

[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #2141: IGNITE-19578 Decrease count of lease messages to meta storage

2023-07-03 Thread via GitHub
denis-chudov commented on code in PR #2141: URL: https://github.com/apache/ignite-3/pull/2141#discussion_r1251267508 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java: ## @@ -89,32 +96,30 @@ public LeaseTracker(VaultMan

[GitHub] [ignite-3] ibessonov merged pull request #2281: IGNITE-19906 Check that table exists when going to destroy partition storage

2023-07-03 Thread via GitHub
ibessonov merged PR #2281: URL: https://github.com/apache/ignite-3/pull/2281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] xtern commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-04 Thread via GitHub
xtern commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1251593176 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImpl.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2275: IGNITE-19644 Change DROP|ADD COLUMN IF (NOT) EXISTS syntax

2023-07-04 Thread via GitHub
AMashenkov commented on code in PR #2275: URL: https://github.com/apache/ignite-3/pull/2275#discussion_r1251611060 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItCreateTableDdlTest.java: ## @@ -122,6 +129,55 @@ public void implicitColocationCo

[GitHub] [ignite-3] xtern commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-04 Thread via GitHub
xtern commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1251593176 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImpl.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-04 Thread via GitHub
AMashenkov commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1251614805 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImpl.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software F

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-04 Thread via GitHub
korlov42 commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1251617401 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImpl.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-04 Thread via GitHub
korlov42 commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1251689114 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java: ## @@ -183,19 +174,25 @@ public void onSchemaUpdated() {

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10820: IGNITE-19034 Added snapshot check status

2023-07-04 Thread via GitHub
NSAmelchev commented on code in PR #10820: URL: https://github.com/apache/ignite/pull/10820#discussion_r1251724179 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java: ## @@ -464,6 +465,9 @@ public class Ignit

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10820: IGNITE-19034 Added snapshot check status

2023-07-04 Thread via GitHub
NSAmelchev commented on code in PR #10820: URL: https://github.com/apache/ignite/pull/10820#discussion_r1251724681 ## modules/core/src/main/java/org/apache/ignite/internal/management/snapshot/SnapshotStatusCommand.java: ## @@ -68,23 +70,36 @@ public class SnapshotStatusCommand e

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10820: IGNITE-19034 Added snapshot check status

2023-07-04 Thread via GitHub
NSAmelchev commented on code in PR #10820: URL: https://github.com/apache/ignite/pull/10820#discussion_r1251729472 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotHandlerContext.java: ## @@ -44,6 +45,9 @@ public class Snapsh

[GitHub] [ignite] yurinaryshkin commented on a diff in pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-04 Thread via GitHub
yurinaryshkin commented on code in PR #10798: URL: https://github.com/apache/ignite/pull/10798#discussion_r1251730293 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/WalRecordsIteratorAdaptor.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed t

[GitHub] [ignite] yurinaryshkin commented on a diff in pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-04 Thread via GitHub
yurinaryshkin commented on code in PR #10798: URL: https://github.com/apache/ignite/pull/10798#discussion_r1251733520 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordV1Serializer.java: ## @@ -226,8 +226,11 @@ public Reco

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-04 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1619866337 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] isapego opened a new pull request, #2284: IGNITE-19212 ODBC: Implement basic query execution

2023-07-04 Thread via GitHub
isapego opened a new pull request, #2284: URL: https://github.com/apache/ignite-3/pull/2284 - Ported basic query execution functionality from Ignite 2; - Ported tests; - Adapted to use new protocol; -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #2284: IGNITE-19212 ODBC: Implement basic query execution

2023-07-04 Thread via GitHub
ptupitsyn commented on code in PR #2284: URL: https://github.com/apache/ignite-3/pull/2284#discussion_r1251757320 ## modules/platforms/cpp/ignite/client/detail/sql/result_set_impl.h: ## @@ -154,15 +154,15 @@ class result_set_impl : public std::enable_shared_from_this { *

[GitHub] [ignite] zstan closed pull request #10817: IGNITE-19878 Restrict possibility to create two caches with the same schemas and index names

2023-07-04 Thread via GitHub
zstan closed pull request #10817: IGNITE-19878 Restrict possibility to create two caches with the same schemas and index names URL: https://github.com/apache/ignite/pull/10817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10820: IGNITE-19034 Added snapshot check status

2023-07-04 Thread via GitHub
sonarcloud[bot] commented on PR #10820: URL: https://github.com/apache/ignite/pull/10820#issuecomment-1620003103 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-04 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1620007842 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-04 Thread via GitHub
sonarcloud[bot] commented on PR #10766: URL: https://github.com/apache/ignite/pull/10766#issuecomment-1620013432 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10818: IGNITE-19830 Added a description check if the command argument is enum type.

2023-07-04 Thread via GitHub
sonarcloud[bot] commented on PR #10818: URL: https://github.com/apache/ignite/pull/10818#issuecomment-1620018915 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
sashapolo commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1251868940 ## modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/DistributedConfigurationStorage.java: ## @@ -206,60 +194,44 @@ public CompletableFut

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
ibessonov commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1251881826 ## modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/DistributedConfigurationStorage.java: ## @@ -296,9 +268,9 @@ public CompletableFutur

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
ibessonov commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1251885540 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -1234,7 +1236,7 @@ private CompletableFuture createTableLocally(

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-07-04 Thread via GitHub
timoninmaxim commented on code in PR #10798: URL: https://github.com/apache/ignite/pull/10798#discussion_r1251848192 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/AbstractWalRecordsIterator.java: ## @@ -184,16 +142,13 @@ protected void

[GitHub] [ignite-3] lowka commented on a diff in pull request #2275: IGNITE-19644 Change DROP|ADD COLUMN IF (NOT) EXISTS syntax

2023-07-04 Thread via GitHub
lowka commented on code in PR #2275: URL: https://github.com/apache/ignite-3/pull/2275#discussion_r1251894868 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItCreateTableDdlTest.java: ## @@ -122,6 +129,63 @@ public void implicitColocationColumns

[GitHub] [ignite-3] AMashenkov opened a new pull request, #2285: IGNITE-19892 TableManager should listen CatalogService events instead of configuration

2023-07-04 Thread via GitHub
AMashenkov opened a new pull request, #2285: URL: https://github.com/apache/ignite-3/pull/2285 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [ignite-3] AMashenkov closed pull request #2285: IGNITE-19499 TableManager should listen CatalogService events instead of configuration

2023-07-04 Thread via GitHub
AMashenkov closed pull request #2285: IGNITE-19499 TableManager should listen CatalogService events instead of configuration URL: https://github.com/apache/ignite-3/pull/2285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [ignite-3] AMashenkov opened a new pull request, #2286: IGNITE-19499 TableManager should listen CatalogService events instead of configuration

2023-07-04 Thread via GitHub
AMashenkov opened a new pull request, #2286: URL: https://github.com/apache/ignite-3/pull/2286 https://issues.apache.org/jira/browse/IGNITE-19499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-07-04 Thread via GitHub
sonarcloud[bot] commented on PR #10766: URL: https://github.com/apache/ignite/pull/10766#issuecomment-1620187634 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] zstan commented on a diff in pull request #2275: IGNITE-19644 Change DROP|ADD COLUMN IF (NOT) EXISTS syntax

2023-07-04 Thread via GitHub
zstan commented on code in PR #2275: URL: https://github.com/apache/ignite-3/pull/2275#discussion_r1251995011 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItCreateTableDdlTest.java: ## @@ -122,6 +129,63 @@ public void implicitColocationColumns

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
SammyVimes commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252025730 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/configuration/ItDistributedConfigurationPropertiesTest.java: ## @@ -228,7 +228,7 @@ void start

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
SammyVimes commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252027048 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -960,44 +957,16 @@ public void init( * and deploying watches after that.

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
SammyVimes commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252030258 ## modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/DistributedConfigurationStorage.java: ## @@ -206,60 +194,44 @@ public CompletableFu

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
SammyVimes commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252035427 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -1234,7 +1236,7 @@ private CompletableFuture createTableLocally

[GitHub] [ignite-extensions] sdarlington commented on pull request #220: IGNITE-19899 Use autoconfigure scheme for SpringBoot 2.7+

2023-07-04 Thread via GitHub
sdarlington commented on PR #220: URL: https://github.com/apache/ignite-extensions/pull/220#issuecomment-1620291411 Tests passed: Thin client: https://ci.ignite.apache.org/buildConfiguration/IgniteExtensions_Tests_SpringBootThinClientAutoconfigure/7341174?hideProblemsFromDependencies

[GitHub] [ignite-3] korlov42 commented on pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-04 Thread via GitHub
korlov42 commented on PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#issuecomment-1620328483 @AMashenkov, @xtern, guys, I've made some refactoring and introduced tests for ParserServiceImpl. Take a look once again please -- This is an automated message from the Apache Git Ser

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
ibessonov commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252100524 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -1234,7 +1236,7 @@ private CompletableFuture createTableLocally(

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

2023-07-04 Thread via GitHub
korlov42 commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1252124233 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -838,33 +838,38 @@ private CompletableFuture close(boo

[GitHub] [ignite-3] AMashenkov closed pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-04 Thread via GitHub
AMashenkov closed pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements URL: https://github.com/apache/ignite-3/pull/2226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
ibessonov commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252140674 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -84,7 +85,18 @@ public interface MetaStorageManager ex

[GitHub] [ignite-3] korlov42 merged pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

2023-07-04 Thread via GitHub
korlov42 merged PR #2196: URL: https://github.com/apache/ignite-3/pull/2196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10778: IGNITE-19622 Add realtime CDC buffer

2023-07-04 Thread via GitHub
sonarcloud[bot] commented on PR #10778: URL: https://github.com/apache/ignite/pull/10778#issuecomment-1620451882 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] xtern commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-04 Thread via GitHub
xtern commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1252173226 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImpl.java: ## @@ -68,7 +66,7 @@ public ParsedResult parse(String query) {

[GitHub] [ignite-3] xtern commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-04 Thread via GitHub
xtern commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1252173671 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImplTest.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
SammyVimes commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252195378 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -1234,7 +1236,7 @@ private CompletableFuture createTableLocally

[GitHub] [ignite-3] AMashenkov merged pull request #2265: IGNITE-19775 Add index builder to TestBuilders

2023-07-04 Thread via GitHub
AMashenkov merged PR #2265: URL: https://github.com/apache/ignite-3/pull/2265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] zstan commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

2023-07-04 Thread via GitHub
zstan commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1252208917 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -838,33 +838,38 @@ private CompletableFuture close(boolea

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
SammyVimes commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252210523 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -84,7 +85,18 @@ public interface MetaStorageManager e

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
SammyVimes commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252211465 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageWatchTest.java: ## @@ -218,6 +219,12 @@ private void startC

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
SammyVimes commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252212463 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -824,19 +830,7 @@ private CompletableFuture onR

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
SammyVimes commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252214544 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/BaseIgniteRestartTest.java: ## @@ -241,32 +236,17 @@ public static PartialNode partialNode(

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-04 Thread via GitHub
SammyVimes commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252214935 ## modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/DistributedConfigurationStorage.java: ## @@ -296,9 +268,9 @@ public CompletableFutu

[GitHub] [ignite-3] alievmirza opened a new pull request, #2288: IGNITE-19581 add restoring of zones state after restart taking into account zone's filter updates

2023-07-04 Thread via GitHub
alievmirza opened a new pull request, #2288: URL: https://github.com/apache/ignite-3/pull/2288 https://issues.apache.org/jira/browse/IGNITE-19581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #2141: IGNITE-19578 Decrease count of lease messages to meta storage

2023-07-04 Thread via GitHub
denis-chudov commented on code in PR #2141: URL: https://github.com/apache/ignite-3/pull/2141#discussion_r1252358663 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java: ## @@ -89,32 +96,30 @@ public LeaseTracker(VaultMan

[GitHub] [ignite] zstan opened a new pull request, #10822: IGNITE-19912 Duplicated index creation using SQL and already existing QueryFields index leads to node start-up failure

2023-07-04 Thread via GitHub
zstan opened a new pull request, #10822: URL: https://github.com/apache/ignite/pull/10822 … QueryFields index leads to node start-up failure Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to en

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10822: IGNITE-19912 Duplicated index creation using SQL and already existing QueryFields index leads to node start-up failure

2023-07-04 Thread via GitHub
sonarcloud[bot] commented on PR #10822: URL: https://github.com/apache/ignite/pull/10822#issuecomment-1621106957 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-05 Thread via GitHub
sashapolo commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252655302 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -67,6 +67,8 @@ public interface MetaStorageManager ext

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

2023-07-05 Thread via GitHub
sashapolo commented on code in PR #2266: URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252662032 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/configuration/ItDistributedConfigurationPropertiesTest.java: ## @@ -228,7 +228,7 @@ void start(

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2141: IGNITE-19578 Decrease count of lease messages to meta storage

2023-07-05 Thread via GitHub
vldpyatkov commented on code in PR #2141: URL: https://github.com/apache/ignite-3/pull/2141#discussion_r1252689832 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java: ## @@ -263,6 +282,14 @@ public void run() { whi

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2289: IGNITE-19756 Java client: fix colocation column order

2023-07-05 Thread via GitHub
ptupitsyn opened a new pull request, #2289: URL: https://github.com/apache/ignite-3/pull/2289 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-05 Thread via GitHub
korlov42 commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1252815943 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImplTest.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] zstan commented on a diff in pull request #2279: IGNITE-19663 Add possibility to check transaction state

2023-07-05 Thread via GitHub
zstan commented on code in PR #2279: URL: https://github.com/apache/ignite-3/pull/2279#discussion_r1252816766 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItCommonApiTest.java: ## @@ -181,7 +181,7 @@ public void checkTimestampOperations() {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2280: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-07-05 Thread via GitHub
korlov42 commented on code in PR #2280: URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1252817997 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImpl.java: ## @@ -68,7 +66,7 @@ public ParsedResult parse(String query) {

<    6   7   8   9   10   11   12   13   14   15   >