ibessonov commented on code in PR #2266:
URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1251885540
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1234,7 +1236,7 @@ private CompletableFuture<?> createTableLocally(
// TODO should be reworked in IGNITE-16763
// We use the event notification future as the result so that
dependent components can complete the schema updates.
- return fireEvent(TableEvent.CREATE, new
TableEventParameters(causalityToken, tableId));
+ return allOf(createPartsFut, fireEvent(TableEvent.CREATE, new
TableEventParameters(causalityToken, tableId)));
Review Comment:
This fix will significantly slow down some tests, and the system in general
when creating table/changing assignments. We need a better fix, which means
adding TODO and describing what's happening and why the old code didn't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
