korlov42 commented on code in PR #2280:
URL: https://github.com/apache/ignite-3/pull/2280#discussion_r1252817997
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImpl.java:
##########
@@ -68,7 +66,7 @@ public ParsedResult parse(String query) {
);
if (shouldBeCached(queryType)) {
- queryToParsedResultCache.put(query, result);
+ queryToParsedResultCache.computeIfAbsent(query, k -> result);
Review Comment:
I tried to make Cache interface minimal yet sufficient. But if it causes
confusion, it's better to replace this call with `put`.
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
