ptupitsyn commented on code in PR #2284:
URL: https://github.com/apache/ignite-3/pull/2284#discussion_r1251757320
##########
modules/platforms/cpp/ignite/client/detail/sql/result_set_impl.h:
##########
@@ -154,15 +154,15 @@ class result_set_impl : public
std::enable_shared_from_this<result_set_impl> {
*
* @return @c true if there are more pages with results and @c false
otherwise.
*/
- [[nodiscard]] IGNITE_API bool has_more_pages() { return
m_resource_id.has_value() && m_has_more_pages; }
+ [[nodiscard]] bool has_more_pages() { return m_resource_id.has_value() &&
m_has_more_pages; }
Review Comment:
Is `IGNITE_API` removed because this is `_imp.h`?
##########
modules/platforms/cpp/ignite/odbc/query/cursor.h:
##########
@@ -0,0 +1,74 @@
+/*
+ * Copyright 2019 GridGain Systems, Inc. and Contributors.
Review Comment:
Incorrect header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
