SammyVimes commented on code in PR #2266:
URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252195378


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1234,7 +1236,7 @@ private CompletableFuture<?> createTableLocally(
 
         // TODO should be reworked in IGNITE-16763
         // We use the event notification future as the result so that 
dependent components can complete the schema updates.
-        return fireEvent(TableEvent.CREATE, new 
TableEventParameters(causalityToken, tableId));
+        return allOf(createPartsFut, fireEvent(TableEvent.CREATE, new 
TableEventParameters(causalityToken, tableId)));

Review Comment:
   I mean that there seems to be no impact to teamcity build time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to