Bug 2171

2015-03-05 Thread Glen Walker
Hello All,   Please forgive my ignorance if I ask obvious questions - I'm just starting out with NetSurf!   Steve suggested I take a look at Bug 2171 (http://bugs.netsurf-browser.org/mantis/view.php?id=2171) as a way of getting to grips with the source code.   I've been looking and scratching

Re: Bug 2171

2015-03-05 Thread Rob Kendrick
On Thu, Mar 05, 2015 at 12:11:54PM +0100, Glen Walker wrote: > Hello All, Hi, Please avoid sending HTML mail to this list. B.

Re: Re: Bug 2171

2015-03-05 Thread Glen Walker
Apologies again - I might have sent this out twice (first in HTML and then in plaintext but I don't think it went to everyone). This is the first time I have ever used a mailing list to talk about anything - I'm far more used to forums... But I digress...if you have received the HTML version I

Re: Re: Bug 2171

2015-03-05 Thread Rob Kendrick
On Thu, Mar 05, 2015 at 12:38:07PM +0100, Glen Walker wrote: > Which uses the enum in menus.h to set up the menu order and creates the menu > according to functions in menu.c > > As far as I can gather the actual text (i.e., "Help... F1") is set up using > the function ro_gui_menu_transate >

Re: Re: Bug 2171

2015-03-05 Thread Glen Walker
Aha! Excellent, thank you! Do you think it would be appropriate to define another version of "AppHelp" (and other menu entries) for use where the the function key shortcut does not apply? Something like this: en.ro.AppHelp:Help... F1 de.ro.AppHelp:Hilfe... F1 fr.ro.AppHelp:Aide... F1 it.ro.App

Re: Re: Bug 2171

2015-03-05 Thread Rob Kendrick
On Thu, Mar 05, 2015 at 12:56:53PM +0100, Glen Walker wrote: > Aha! Excellent, thank you! > > Do you think it would be appropriate to define another version of "AppHelp" > (and other menu entries) for use where the the function key shortcut does not > apply? Something like this: > > en.ro.AppHe

Re: Re: Bug 2171

2015-03-05 Thread WPB
On Thu, 05 Mar 2015 12:01:05 -, Rob Kendrick wrote: On Thu, Mar 05, 2015 at 12:56:53PM +0100, Glen Walker wrote: Aha! Excellent, thank you! Do you think it would be appropriate to define another version of "AppHelp" (and other menu entries) for use where the the function key shortcu

Re: Re: Bug 2171

2015-03-05 Thread Rob Kendrick
On Thu, Mar 05, 2015 at 02:26:26PM -, WPB wrote: > Couldn't the messages in the UI messages file contain a special > character to denote the start of a keyboard shortcut? Something that > wouldn't make sense for a menu item, like a CR? I suppose that's not > very friendly in terms of the messag

Re: Re: Bug 2171

2015-03-05 Thread WPB
On Thu, 05 Mar 2015 14:49:59 -, Rob Kendrick wrote: On Thu, Mar 05, 2015 at 02:26:26PM -, WPB wrote: Couldn't the messages in the UI messages file contain a special character to denote the start of a keyboard shortcut? Something that wouldn't make sense for a menu item, like a CR? I

Re: Re: Bug 2171

2015-03-05 Thread Rob Kendrick
On Thu, Mar 05, 2015 at 02:55:49PM -, WPB wrote: > I wondered if that might be the case. Fair enough, then. Perhaps the > duplicate messages option is cleanest without a large development > overhead. Bit of a headache for internationalizing, but I think the > FatMessages file uses a dot-separat

Re: Re: Bug 2171

2015-03-05 Thread Glen Walker
> Sent: Thursday, March 05, 2015 at 2:49 PM > From: "Rob Kendrick" > To: netsurf-dev@netsurf-browser.org > Subject: Re: Re: Bug 2171 > > On Thu, Mar 05, 2015 at 02:26:26PM -, WPB wrote: > > Couldn't the messages in the UI messages file contain a special > > character to denote the start of a k

Re: Re: Bug 2171

2015-03-05 Thread Glen Walker
> But again, please not "NoFunc". > > B. > > I agree! Sorry, that was me. NoAccellerator/NoAccel or NoShortcut are better. In fact I propose that if we adopt that strategy then "NoShortcut" is probably the most obvious one and should be used.

Re: libcss memory leak

2015-03-05 Thread Michael Drake
On 03/03/15 16:55, Ralf Junker wrote: libcss may leak memory if css_stylesheet_data_done() > is not called. See the attached source for an example. Hi Ralf, thanks for pointing this out. I agree, the API does not make it clear that you must call _data_done before _destroy if you want to abor

Re: Re: Bug 2171

2015-03-05 Thread Steve Fryatt
On 5 Mar, Rob Kendrick wrote in message <20150305150242.gt31...@platypus.pepperfish.net>: > On Thu, Mar 05, 2015 at 02:55:49PM -, WPB wrote: > > I wondered if that might be the case. Fair enough, then. Perhaps the > > duplicate messages option is cleanest without a large development > > ov

Re: Re: Bug 2171

2015-03-05 Thread Steve Fryatt
On 5 Mar, "Glen Walker" wrote in message : > The accelerator may be any alphanumeric character, any function key (from > F1 to F12) or one of the special characters listed in the table below > (again, case doesn't matter): The handling of keyboard shortcuts in RISC OS menus is one of the mass

Re: Re: Bug 2171

2015-03-05 Thread Steve Fryatt
On 5 Mar, "Glen Walker" wrote in message : > Steve suggested I take a look at Bug 2171 > (http://bugs.netsurf-browser.org/mantis/view.php?id=2171) as a way of > getting to grips with the source code. > > I've been looking and scratching my head for a day or so. When I suggested looking at

Re: Bug 2171

2015-03-05 Thread Chris Young
On Thu, 5 Mar 2015 22:55:59 +, Steve Fryatt wrote: > The problem are the other two entries: Global History and Hotlist, as the > same tokens are used in both iconbar and main menus. The following are the > corresponding entries from the main menu definition: > > { "Utilities.Hotlist.Hotlist

Re: Re: Bug 2171

2015-03-05 Thread Glen Walker
Thanks Steve that's brilliant work! :--) I'm away this weekend but hopefully next week I'll get some time to digest what you have written and maybe even squash 2171 - if I do any bug fixing, how would I submit the revisions? > However, I also thought that iconbar.c/h was a useful bit of cod