Re: [PATCH] net/mlx5e: Allow removing representors netdev to other namespace

2019-05-21 Thread Or Gerlitz
On Tue, May 21, 2019 at 7:36 AM Tonghao Zhang wrote: > On Tue, May 21, 2019 at 4:24 AM Or Gerlitz wrote: > > > > On Mon, May 20, 2019 at 3:19 PM wrote: > > > > > > From: Tonghao Zhang > > > > > > At most case, we use the ConnectX-5 NIC

Re: [PATCH] net/mlx5e: Allow removing representors netdev to other namespace

2019-05-21 Thread Or Gerlitz
On Wed, May 22, 2019 at 4:26 AM Tonghao Zhang wrote: > I review the reps of netronome nfp codes, nfp does't set the > NETIF_F_NETNS_LOCAL to netdev->features. > And I changed the OFED codes which used for our product environment, > and then send this patch to upstream. The real question here is

Re: [PATCH] net/mlx5e: Fix zero table prio set by user.

2019-07-26 Thread Or Gerlitz
On Fri, Jul 26, 2019 at 12:24 AM Saeed Mahameed wrote: > > On Thu, 2019-07-25 at 19:24 +0800, we...@ucloud.cn wrote: > > From: wenxu > > > > The flow_cls_common_offload prio is zero > > > > It leads the invalid table prio in hw. > > > > Error: Could not process rule: Invalid argument > > > > kern

Re: [PATCH] net/mlx5e: Allow removing representors netdev to other namespace

2019-08-04 Thread Or Gerlitz
On Thu, Aug 1, 2019 at 3:44 AM Tonghao Zhang wrote: > On Wed, May 22, 2019 at 12:49 PM Or Gerlitz wrote: > > On Wed, May 22, 2019 at 4:26 AM Tonghao Zhang > > wrote: > > > I review the reps of netronome nfp codes, nfp does't set the > > > NETIF_F_NETNS_

Re: perf measure for stalled cycles per instruction on newer Intel processors

2020-10-18 Thread Or Gerlitz
On Thu, Oct 15, 2020 at 9:33 PM Andi Kleen wrote: > On Thu, Oct 15, 2020 at 05:53:40PM +0300, Or Gerlitz wrote: > > Earlier Intel processors (e.g E5-2650) support the more of classical > > two stall events (for backend and frontend [1]) and then perf shows > > the nice meas

Re: [PATCH v4 net-next 21/21] Documentation: add TCP DDP offload documentation

2021-02-13 Thread Or Gerlitz
On Fri, Feb 12, 2021 at 4:11 PM Nikolay Aleksandrov wrote: > I got interested and read through the doc, there are a few typos below. thanks for spotting these, we will fix them

Re: [PATCH v4 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-14 Thread Or Gerlitz
On Sun, Feb 14, 2021 at 8:20 PM David Ahern wrote: > On 2/11/21 2:10 PM, Boris Pismenny wrote: > > @@ -223,6 +229,164 @@ static inline size_t nvme_tcp_pdu_last_send(struct > > nvme_tcp_request *req, > > return nvme_tcp_pdu_data_left(req) <= len; > > } Hi Dave, Thanks for the continuous f

Re: [PATCH v4 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-17 Thread Or Gerlitz
On Sun, Feb 14, 2021 at 8:20 PM David Ahern wrote: > On 2/11/21 2:10 PM, Boris Pismenny wrote: > > @@ -223,6 +229,164 @@ static inline size_t nvme_tcp_pdu_last_send(struct > > nvme_tcp_request *req, > > return nvme_tcp_pdu_data_left(req) <= len; > > } > > > > +#ifdef CONFIG_TCP_DDP > > + >

Re: [PATCH v4 net-next 07/21] nvme-tcp: Add DDP data-path

2021-02-17 Thread Or Gerlitz
On Sun, Feb 14, 2021 at 8:30 PM David Ahern wrote: > > On 2/11/21 2:10 PM, Boris Pismenny wrote: > > > > +static int nvme_tcp_teardown_ddp(struct nvme_tcp_queue *queue, > > + u16 command_id, > > + struct request *rq) > > +{ > > + struct

Re: [PATCH v4 net-next 00/21] nvme-tcp receive offloads

2021-02-21 Thread Or Gerlitz
On Thu, Feb 11, 2021 at 11:15 PM Boris Pismenny wrote: > Changes since v3: > = > * Use DDP_TCP ifdefs in iov_iter and skb iterators to minimize impact > when compiled out (Christoph) > * Simplify netdev references and reduce the use of > get_netdev_for_sock

Re: [PATCH v3 net-next 01/21] iov_iter: Introduce new procedures for copy to iter/pages

2021-02-02 Thread Or Gerlitz
On Mon, Feb 1, 2021 at 7:38 PM Christoph Hellwig wrote: > On Mon, Feb 01, 2021 at 12:04:49PM +0200, Boris Pismenny wrote: > > +static __always_inline __must_check > > +size_t ddp_copy_to_iter(const void *addr, size_t bytes, struct iov_iter *i) > > +{ > > + if (unlikely(!check_copy_size(addr, b

Re: [PATCH v3 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-02 Thread Or Gerlitz
On Mon, Feb 1, 2021 at 7:39 PM Christoph Hellwig wrote: >> +static >> +int nvme_tcp_offload_socket(struct nvme_tcp_queue *queue) > > Please use the same coding style as the rest of the file, and not some > weirdo version. ack

Re: [PATCH v3 net-next 07/21] nvme-tcp: Add DDP data-path

2021-02-02 Thread Or Gerlitz
On Mon, Feb 1, 2021 at 7:40 PM Christoph Hellwig wrote: > Given how much ddp code there is can you split it into a separate file? mmm, do we need to check the preferences or get to a consensus among the maintainers for that one?

Re: [PATCH net-next RESEND 2/2] net/mlx5: E-Switch, Implement devlink port function cmds to control roce

2021-02-02 Thread Or Gerlitz
On Tue, Feb 2, 2021 at 10:08 AM Yishai Hadas wrote: > Implement devlink port function commands to enable / disable roce. > This is used to control the roce device capabilities. [..] > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h > @@ -122,8 +122,9 @@ struct mlx5_vport_info { >

Re: [PATCH v3 net-next 09/21] nvme-tcp: Deal with netdevice DOWN events

2021-02-04 Thread Or Gerlitz
On Wed, Feb 3, 2021 at 11:17 AM Sagi Grimberg wrote: > > @@ -2930,6 +2931,27 @@ static struct nvme_ctrl *nvme_tcp_create_ctrl(struct > > device *dev, > > return ERR_PTR(ret); > > } > > > > +static int nvme_tcp_netdev_event(struct notifier_block *this, > > + un

Re: [PATCH v3 net-next 08/21] nvme-tcp : Recalculate crc in the end of the capsule

2021-02-04 Thread Or Gerlitz
On Wed, Feb 3, 2021 at 11:12 AM Sagi Grimberg wrote: > > @@ -1841,8 +1913,10 @@ static void __nvme_tcp_stop_queue(struct > > nvme_tcp_queue *queue) > > nvme_tcp_restore_sock_calls(queue); > > cancel_work_sync(&queue->io_work); > > > > - if (test_bit(NVME_TCP_Q_OFF_DDP, &queue->fl

Re: [PATCH v3 net-next 07/21] nvme-tcp: Add DDP data-path

2021-02-04 Thread Or Gerlitz
On Wed, Feb 3, 2021 at 10:54 AM Sagi Grimberg wrote: > > +static > > +int nvme_tcp_teardown_ddp(struct nvme_tcp_queue *queue, > > + u16 command_id, > > + struct request *rq) > > +{ > > + struct nvme_tcp_request *req = blk_mq_rq_to_pdu(rq); > > +

Re: [PATCH v3 net-next 08/21] nvme-tcp : Recalculate crc in the end of the capsule

2021-02-07 Thread Or Gerlitz
On Wed, Feb 3, 2021 at 11:12 AM Sagi Grimberg wrote: > On 2/1/21 2:04 AM, Boris Pismenny wrote: > > @@ -290,12 +341,9 @@ int nvme_tcp_setup_ddp(struct nvme_tcp_queue *queue, > > } > > > > req->ddp.command_id = command_id; > > - req->ddp.sg_table.sgl = req->ddp.first_sgl; > > -

Re: [pull request][net-next V2 00/17] mlx5 updates 2021-02-04

2021-02-08 Thread Or Gerlitz
On Sat, Feb 6, 2021 at 7:10 AM Saeed Mahameed wrote: > From: Saeed Mahameed > This series adds the support for VF tunneling. > Vlad Buslov says: > = > Implement support for VF tunneling > Abstract > Currently, mlx5 only supports configuration with tunnel endpoint IP address on

Re: [pull request][net-next V2 00/17] mlx5 updates 2021-02-04

2021-02-09 Thread Or Gerlitz
On Sat, Feb 6, 2021 at 7:10 AM Saeed Mahameed wrote: > Vlad Buslov says: > Implement support for VF tunneling > Currently, mlx5 only supports configuration with tunnel endpoint IP address on > uplink representor. Remove implicit and explicit assumptions of tunnel always > being terminated on up

Re: [pull request][net-next V2 00/17] mlx5 updates 2021-02-04

2021-02-09 Thread Or Gerlitz
On Tue, Feb 9, 2021 at 10:42 AM Or Gerlitz wrote: > On Sat, Feb 6, 2021 at 7:10 AM Saeed Mahameed wrote: > > Vlad Buslov says: > > > Implement support for VF tunneling > > > Currently, mlx5 only supports configuration with tunnel endpoint IP address > >

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-09 Thread Or Gerlitz
On Tue, Feb 9, 2021 at 8:49 AM Leon Romanovsky wrote: [..] > This is another problem with mlx5 - complete madness with config options > that are not possible to test. > ➜ kernel git:(rdma-next) grep -h "config MLX" > drivers/net/ethernet/mellanox/mlx5/core/Kconfig | awk '{ print $2}' | sort >

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-09 Thread Or Gerlitz
On Tue, Feb 9, 2021 at 12:01 PM Leon Romanovsky wrote: > > On Tue, Feb 09, 2021 at 11:25:33AM +0200, Or Gerlitz wrote: > > On Tue, Feb 9, 2021 at 8:49 AM Leon Romanovsky wrote: > > > > [..] > > > > > This is another problem with mlx5 - complete madness

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-09 Thread Or Gerlitz
On Tue, Feb 9, 2021 at 4:26 PM Vlad Buslov wrote: > On Mon 08 Feb 2021 at 22:22, Jakub Kicinski wrote: > > On Mon, 8 Feb 2021 10:21:21 +0200 Vlad Buslov wrote: > >> > These operations imply that 7.7.7.5 is configured on some interface on > >> > the host. Most likely the VF representor itself, as

Re: [for-next V2 08/10] linux/dim: Implement rdma_dim

2019-06-26 Thread Or Gerlitz
On Wed, Jun 26, 2019 at 1:03 AM Sagi Grimberg wrote: > > > +void rdma_dim(struct dim *dim, u64 completions) > > +{ > > + struct dim_sample *curr_sample = &dim->measuring_sample; > > + struct dim_stats curr_stats; > > + u32 nevents; > > + > > + dim_update_sample_with_comps(curr_samp

Re: [PATCH rdma-next] MAINTAINERS: Remove bouncing @mellanox.com addresses

2018-05-03 Thread Or Gerlitz
On Thu, May 3, 2018 at 9:37 PM, LR wrote: > MELLANOX MLX5 core VPI driver > M: Saeed Mahameed > -M: Matan Barak Goodbye Matan! You were a long time developer, maintainer, hacker and a very deeply thinking, pleasant, nice and open person in our team, enjoy your new adventures and than

Re: [PATCH v2 net 0/2] IB/ipoib: ip link support

2018-05-07 Thread Or Gerlitz
On Thu, Jan 18, 2018 at 7:25 AM, Jason Gunthorpe wrote: > On Mon, Jan 15, 2018 at 01:13:09PM -0500, David Miller wrote: >> From: Denis Drozdov >> Date: Tue, 9 Jan 2018 23:42:45 +0200 >> >> > IP link was broken due to the changes in IPoIB for the rdma_netdev >> > support after commit cd565b4b51e5

Re: [PATCH net 5/5] nfp: remove false positive offloads in flower vxlan

2018-04-18 Thread Or Gerlitz
On Fri, Nov 17, 2017 at 4:06 AM, Jakub Kicinski wrote: > From: John Hurley > > Pass information to the match offload on whether or not the repr is the > ingress or egress dev. Only accept tunnel matches if repr is the egress dev. > > This means rules such as the following are successfully offload

Re: [PATCH net 5/5] nfp: remove false positive offloads in flower vxlan

2018-04-18 Thread Or Gerlitz
On Wed, Apr 18, 2018 at 3:31 PM, John Hurley wrote: > On Wed, Apr 18, 2018 at 8:43 AM, Or Gerlitz wrote: >> On Fri, Nov 17, 2017 at 4:06 AM, Jakub Kicinski >> wrote: >>> From: John Hurley >>> >>> Pass information to the match offload on whether or not

Re: [PATCH net 5/5] nfp: remove false positive offloads in flower vxlan

2018-04-19 Thread Or Gerlitz
On Thu, Apr 19, 2018 at 1:31 AM, John Hurley wrote: > On Wed, Apr 18, 2018 at 7:18 PM, Or Gerlitz wrote: >> On Wed, Apr 18, 2018 at 3:31 PM, John Hurley >> wrote: >>> On Wed, Apr 18, 2018 at 8:43 AM, Or Gerlitz wrote: >>>> On Fri, Nov 17, 2017 at

Re: [PATCH net-next 3/4] nfp: flower: support offloading multiple rules with same cookie

2018-04-24 Thread Or Gerlitz
On Wed, Apr 25, 2018 at 7:17 AM, Jakub Kicinski wrote: > From: John Hurley > > When multiple netdevs are attached to a tc offload block and register for > callbacks, a rule added to the block will be propogated to all netdevs. > Previously these were detected as duplicates (based on cookie) and >

Re: [PATCH net-next 3/4] nfp: flower: support offloading multiple rules with same cookie

2018-04-25 Thread Or Gerlitz
On Wed, Apr 25, 2018 at 11:51 AM, John Hurley wrote: > On Wed, Apr 25, 2018 at 7:31 AM, Or Gerlitz wrote: >> On Wed, Apr 25, 2018 at 7:17 AM, Jakub Kicinski >> wrote: >>> From: John Hurley >>> >>> When multiple netdevs are attached to a tc offload bl

Re: [PATCH net-next 3/4] nfp: flower: support offloading multiple rules with same cookie

2018-04-25 Thread Or Gerlitz
On Wed, Apr 25, 2018 at 12:02 PM, John Hurley wrote: > On Wed, Apr 25, 2018 at 9:56 AM, Or Gerlitz wrote: >> On Wed, Apr 25, 2018 at 11:51 AM, John Hurley >> wrote: >>> On Wed, Apr 25, 2018 at 7:31 AM, Or Gerlitz wrote: >>>> On Wed, Apr 25, 2018 at

Re: [PATCH net-next 4/4] nfp: flower: ignore duplicate cb requests for same rule

2018-04-25 Thread Or Gerlitz
On Wed, Apr 25, 2018 at 7:17 AM, Jakub Kicinski wrote: > From: John Hurley > > If a flower rule has a repr both as ingress and egress port then 2 > callbacks may be generated for the same rule request. > > Add an indicator to each flow as to whether or not it was added from an > ingress registere

Re: mlx5 stable backport help

2019-02-21 Thread Or Gerlitz
On Wed, Feb 20, 2019 at 10:03 PM Saeed Mahameed wrote: > On Tue, 2019-02-19 at 22:36 -0800, David Miller wrote: >> I need help backporting two changes for -stable. Namely: > Hi Dave Thanks for trying, here too > > 6707f74be8621ae067d2cf1c4485900e2742c20f ("net/mlx5e: Update hw flows > > when e

Re: [PATCH net-next 1/5] net/mlx5e: Return -EOPNOTSUPP when modify header action zero

2019-02-21 Thread Or Gerlitz
On Thu, Feb 21, 2019 at 3:42 PM wrote: > else /* namespace is MLX5_FLOW_NAMESPACE_KERNEL - NIC offloading */ > max_actions = MLX5_CAP_FLOWTABLE_NIC_RX(priv->mdev, > max_modify_header_actions); > > + if (!max_actions) { > + NL_SET_ERR_MSG_MOD(extack, > +

Re: [PATCH net-next 2/5] net/mlx5e: Make the log friendly when decapsulation offload not supported

2019-02-21 Thread Or Gerlitz
On Thu, Feb 21, 2019 at 3:42 PM wrote: > > From: Tonghao Zhang > > If we try to offload decapsulation actions to VFs hw, we get the log [1]. but the switching was on the tunnel type (if (tunnel_type == [...]) - what rules caused you to get here? what was the ingress device and what was the egre

Re: [PATCH net-next 5/5] net/mlx5e: Support enable/disable VFs link state on switchdev mode

2019-02-21 Thread Or Gerlitz
On Thu, Feb 21, 2019 at 3:42 PM wrote: > From: Tonghao Zhang > > This patch allow users to enable/disable VFs link state > on switchdev mode. NAK We do it with the reps, if you change the administrative link state of a VF rep it will effect the operational link state of the VF, see upstream com

Re: [PATCH net-next 2/5] net/mlx5e: Make the log friendly when decapsulation offload not supported

2019-02-22 Thread Or Gerlitz
On Fri, Feb 22, 2019 at 9:49 AM Tonghao Zhang wrote: > > On Fri, Feb 22, 2019 at 12:32 AM Or Gerlitz wrote: > > > > On Thu, Feb 21, 2019 at 3:42 PM wrote: > > > > > > From: Tonghao Zhang > > > > > > If we try to offload decapsulation

Re: mlx5 stable backport help

2019-02-22 Thread Or Gerlitz
On Fri, Feb 22, 2019 at 12:35 AM Saeed Mahameed wrote: > On Thu, 2019-02-21 at 12:21 +0200, Or Gerlitz wrote: > So we all agree that the offending patch is "net/mlx5e: Support tunnel > encap over tagged Ethernet" even if the issue existed before, as you said the issue exis

Re: [PATCH net-next 2/5] net/mlx5e: Make the log friendly when decapsulation offload not supported

2019-02-24 Thread Or Gerlitz
On Sat, Feb 23, 2019 at 9:58 AM Tonghao Zhang wrote: > On Fri, Feb 22, 2019 at 5:07 PM Or Gerlitz wrote: > > On Fri, Feb 22, 2019 at 9:49 AM Tonghao Zhang > > wrote: > > > On Fri, Feb 22, 2019 at 12:32 AM Or Gerlitz wrote: > > > > On

Re: [PATCH net-next v2 1/5] net/mlx5e: Return -EOPNOTSUPP when modify header action zero

2019-02-26 Thread Or Gerlitz
On Mon, Feb 25, 2019 at 1:06 PM wrote: > When max modify header action is zero, we return -EOPNOTSUPP > directly. In this way, we can ignore wrong message info (e.g. > "mlx5: parsed 0 pedit actions, can't do more"). > > This happens when offloading pedit actions on mlx VFs. this command should w

Re: [PATCH net-next v2 5/5] net/mlx5e: Return -EOPNOTSUPP when attempting to offload an unsupported action

2019-02-26 Thread Or Gerlitz
On Mon, Feb 25, 2019 at 1:07 PM wrote: > The encapsulation is not supported for mlx5 VFs. When we try to > offload that action, the -EINVAL is returned, but not -EOPNOTSUPP. > This patch changes the returned value and ignore to confuse user. FWIW, note that this changes the behavior towards user

Re: [PATCH mlx5-next 3/4] net/mlx5: Decrease default mr cache size

2019-03-27 Thread Or Gerlitz
-off-by: Leon Romanovsky Reported-by: Shalom Toledo Acked-by: Or Gerlitz Lets push it into stable kernels, a Fixes tag here will cause that to happen more easily, so please consider that. > --- > .../net/ethernet/mellanox/mlx5/core/main.c| 20 --- > 1 file changed,

Re: [PATCH mlx5-next 3/4] net/mlx5: Decrease default mr cache size

2019-03-27 Thread Or Gerlitz
On Wed, Mar 27, 2019 at 1:41 PM Leon Romanovsky wrote: > On Wed, Mar 27, 2019 at 12:07:54PM +0200, Or Gerlitz wrote: > > On Tue, Mar 19, 2019 at 11:25 AM Leon Romanovsky wrote: > > > From: Artemy Kovalyov > > > > > > Delete initialization of high o

Re: [PATCH mlx5-next 3/4] net/mlx5: Decrease default mr cache size

2019-03-27 Thread Or Gerlitz
On Wed, Mar 27, 2019 at 3:36 PM Leon Romanovsky wrote: > On Wed, Mar 27, 2019 at 01:58:17PM +0200, Or Gerlitz wrote: > > On Wed, Mar 27, 2019 at 1:41 PM Leon Romanovsky wrote: > > > On Wed, Mar 27, 2019 at 12:07:54PM +0200, Or Gerlitz wrote: > > > > On Tue,

Re: [PATCH v2] net/mlx5e: Add bonding device for indr block to offload the packet received from bonding device

2019-05-19 Thread Or Gerlitz
On Fri, May 17, 2019 at 12:45 PM wrote: > From: wenxu > > The mlx5e support the lag mode. When add mlx_p0 and mlx_p1 to bond0. > packet received from mlx_p0 or mlx_p1 and in the ingress tc flower > forward to vf0. The tc rule can't be offloaded because there is > no indr_register_block for the bo

Re: [PATCH] net/mlx5e: Allow removing representors netdev to other namespace

2019-05-20 Thread Or Gerlitz
On Mon, May 20, 2019 at 3:19 PM wrote: > > From: Tonghao Zhang > > At most case, we use the ConnectX-5 NIC on compute node for VMs, > but we will offload forwarding rules to NICs on gateway node. > On the gateway node, we will install multiple NICs and set them to > different dockers which contai

Re: [patch net-next 0/4] net: sched: get rid of cls_flower->egress_dev

2017-10-10 Thread Or Gerlitz
On Tue, Oct 10, 2017 at 10:30 AM, Jiri Pirko wrote: > > > drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 + > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 +- > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 31 ++-- Jiri, FWIW, as I reported to you earlier, I was pla

Re: [patch net-next 3/4] net: sched: convert cls_flower->egress_dev users to tc_setup_cb_egdev infra

2017-10-10 Thread Or Gerlitz
On Tue, Oct 10, 2017 at 10:30 AM, Jiri Pirko wrote: > The only user of cls_flower->egress_dev is mlx5. but nfp supports decap action offload too and from the flower code stand point, I guess they are both the same, right? how does it work there? Or.

Re: [patch net-next 3/4] net: sched: convert cls_flower->egress_dev users to tc_setup_cb_egdev infra

2017-10-10 Thread Or Gerlitz
On Tue, Oct 10, 2017 at 10:30 AM, Jiri Pirko wrote: > --- a/include/net/pkt_cls.h > +++ b/include/net/pkt_cls.h > @@ -206,8 +206,6 @@ int tcf_exts_dump(struct sk_buff *skb, struct tcf_exts > *exts); > int tcf_exts_dump_stats(struct sk_buff *skb, struct tcf_exts *exts); > int tcf_exts_get_dev(s

Re: [patch net-next 0/4] net: sched: get rid of cls_flower->egress_dev

2017-10-10 Thread Or Gerlitz
On Wed, Oct 11, 2017 at 12:13 AM, Jiri Pirko wrote: > Tue, Oct 10, 2017 at 07:24:21PM CEST, gerlitz...@gmail.com wrote: > Or, as I replied to you earlier, the issue you describe is totally > unrelated to this patchset as you see the issue with the current net-next. Jiri, the point I wanted to ma

Re: [patch net-next 3/4] net: sched: convert cls_flower->egress_dev users to tc_setup_cb_egdev infra

2017-10-10 Thread Or Gerlitz
On Wed, Oct 11, 2017 at 12:16 AM, Jiri Pirko wrote: > Tue, Oct 10, 2017 at 10:08:23PM CEST, gerlitz...@gmail.com wrote: >>On Tue, Oct 10, 2017 at 10:30 AM, Jiri Pirko wrote: >>> The only user of cls_flower->egress_dev is mlx5. >> >>but nfp supports decap action offload too and from the flower cod

Re: [patch net-next 3/4] net: sched: convert cls_flower->egress_dev users to tc_setup_cb_egdev infra

2017-10-11 Thread Or Gerlitz
On Wed, Oct 11, 2017 at 12:47 AM, Or Gerlitz wrote: > On Wed, Oct 11, 2017 at 12:16 AM, Jiri Pirko wrote: >> Tue, Oct 10, 2017 at 10:08:23PM CEST, gerlitz...@gmail.com wrote: >>>On Tue, Oct 10, 2017 at 10:30 AM, Jiri Pirko wrote: >>>> The only user of cls_flower-&

[PATCH net] net/sched: cls_flower: Set egress_dev mark when calling into the HW driver

2017-10-16 Thread Or Gerlitz
hich we're calling into the HW driver through the egress port net-device. Fixes: de4784ca030f ('net: sched: get rid of struct tc_to_netdev') Signed-off-by: Or Gerlitz Signed-off-by: Roi Dayan --- Hi Dave, the bug was introduced in 4.14-rc1 but later the related code was changed in net

Re: [PATCH net] net/sched: cls_flower: Set egress_dev mark when calling into the HW driver

2017-10-18 Thread Or Gerlitz
On Tue, Oct 17, 2017 at 2:29 PM, Sergei Shtylyov wrote: > Hello! > > On 10/16/2017 12:19 PM, Or Gerlitz wrote: > >> Commit 7091d8c '(net/sched: cls_flower: Add offload support using egress > > >At least 12 digits are needed. Also on such a spot (e.g not on

[PATCH net-next] net/sched: Set the net-device for egress device instance

2017-10-18 Thread Or Gerlitz
Currently the netdevice field is not set and the egdev instance is not functional, fix that. Fixes: 3f55bdda8df ('net: sched: introduce per-egress action device callbacks') Signed-off-by: Or Gerlitz Acked-by: Jiri Pirko --- net/sched/act_api.c | 1 + 1 file changed, 1 insertion(+)

Re: Fwd: [PATCH 0/6] offload Linux LAG devices to the TC datapath

2018-06-26 Thread Or Gerlitz
> Forwarded Message > Subject: [PATCH 0/6] offload Linux LAG devices to the TC datapath > Date: Thu, 21 Jun 2018 14:35:55 +0100 > From: John Hurley > To: d...@openvswitch.org, r...@mellanox.com, g...@mellanox.com, > pa...@mellanox.com, f...@sysclose.org, simon.hor...@netronome.c

Re: [PATCH 0/6] offload Linux LAG devices to the TC datapath

2018-06-27 Thread Or Gerlitz
On Wed, Jun 27, 2018 at 1:31 AM, Jakub Kicinski wrote: > On Tue, 26 Jun 2018 17:57:08 +0300, Or Gerlitz wrote: >> 2. re the egress side of things. Some NIC HWs can't just use LAG >> as the egress port destination of an ACL (tc rule) and the HW rule >> needs to be dupli

Re: Fwd: [PATCH 0/6] offload Linux LAG devices to the TC datapath

2018-06-27 Thread Or Gerlitz
On Tue, Jun 26, 2018 at 9:16 PM, John Hurley wrote: > On Tue, Jun 26, 2018 at 3:57 PM, Or Gerlitz wrote: >>> Forwarded Message >>> Subject: [PATCH 0/6] offload Linux LAG devices to the TC datapath >>> Date: Thu, 21 Jun 2018 14:35:55 +0100 &g

Re: [PATCH 0/6] offload Linux LAG devices to the TC datapath

2018-06-27 Thread Or Gerlitz
On Thu, Jun 28, 2018 at 2:08 AM, Jakub Kicinski wrote: > On Wed, 27 Jun 2018 23:07:29 +0300, Or Gerlitz wrote: >> On Wed, Jun 27, 2018 at 1:31 AM, Jakub Kicinski >> wrote: >> > On Tue, 26 Jun 2018 17:57:08 +0300, Or Gerlitz wrote: >> >> >> 2. re the egre

Re: [PATCH 0/6] offload Linux LAG devices to the TC datapath

2018-06-28 Thread Or Gerlitz
On Thu, Jun 28, 2018 at 7:02 AM, Jakub Kicinski wrote: [...] > } else if (netif_is_lag_master(out_dev) && >priv->flower_ext_feats & NFP_FL_FEATS_LAG) { > int gid; > > output->flags = cpu_to_be16(tmp_flags); > gid = nfp_

Re: [BUG] mlx5 have problems with ipv4-ipv6 tunnels in linux 4.4

2018-07-12 Thread Or Gerlitz
On Tue, Jul 10, 2018 at 12:19 PM, Konstantin Khlebnikov wrote: > On 10.07.2018 01:31, Saeed Mahameed wrote: >> >> On Tue, Jul 3, 2018 at 10:45 PM, Konstantin Khlebnikov >> wrote: >>> >>> I'm seeing problems with tunnelled traffic with Mellanox Technologies >>> MT27710 Family [ConnectX-4 Lx] using

Re: [net-next PATCH] net: ipv4: fix listify ip_rcv_finish in case of forwarding

2018-07-12 Thread Or Gerlitz
On Wed, Jul 11, 2018 at 11:06 PM, Jesper Dangaard Brouer wrote: > Well, I would prefer you to implement those. I just did a quick > implementation (its trivially easy) so I have something to benchmark > with. The performance boost is quite impressive! sounds good, but wait > One reason I did

Re: [PATCH mlx5-next v1 1/8] net/mlx5: Add forward compatible support for the FTE match data

2018-07-12 Thread Or Gerlitz
On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > From: Yishai Hadas > > Use the PRM size including the reserved when working with the FTE > match data. is this actually a bug fix? > This comes to support forward compatibility for cases that current > reserved data will be exposed by th

Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number

2018-07-12 Thread Or Gerlitz
On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > From: Yishai Hadas > > Add support to set a destination from a flow table number. > This functionality will be used in downstream patches from this > series by the DEVX stuff. Reading your cover letter, I still don't understand what is mi

Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number

2018-07-12 Thread Or Gerlitz
On Fri, Jul 13, 2018 at 12:26 AM, Jason Gunthorpe wrote: > On Fri, Jul 13, 2018 at 12:00:41AM +0300, Or Gerlitz wrote: >> On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: >> > From: Yishai Hadas >> > >> > Add support to set a destination from a flow t

Re: [PATCH net-next] net: sched: refactor flower walk to iterate over idr

2018-07-14 Thread Or Gerlitz
On Tue, Jul 10, 2018 at 8:02 PM, Vlad Buslov wrote: > > On Tue 10 Jul 2018 at 13:55, Simon Horman wrote: >> On Mon, Jul 09, 2018 at 01:29:11PM +0300, Vlad Buslov wrote: >>> Extend struct tcf_walker with additional 'cookie' field. It is intended to >>> be used by classifier walk implementations to

Re: [PATCH mlx5-next v1 1/8] net/mlx5: Add forward compatible support for the FTE match data

2018-07-15 Thread Or Gerlitz
On Sun, Jul 15, 2018 at 10:26 AM, Yishai Hadas wrote: > On 7/12/2018 11:53 PM, Or Gerlitz wrote: >> On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: >>> From: Yishai Hadas >>> Use the PRM size including the reserved when working with the FTE >>> ma

Re: [RFC PATCH mlx5-next 01/18] net/mlx5: Add proper NIC TX steering flow tables support

2018-07-16 Thread Or Gerlitz
On Mon, Jul 16, 2018 at 11:22 AM, Leon Romanovsky wrote: > From: Mark Bloch > > Expose the ability to add steering rules to NIC TX flow tables. > For now, we are only adding TX bypass (egress) which is used by the RDMA > side. While we are here clean the switch logic. > > We expose the same numbe

Re: [RFC PATCH rdma-next 13/18] RDMA/mlx5: Enable decap and packet reformat on flow tables

2018-07-16 Thread Or Gerlitz
On Mon, Jul 16, 2018 at 11:23 AM, Leon Romanovsky wrote: > From: Mark Bloch > > If NIC RX flow tables support decap opertion, enable it on creation. opertion --> operation > If NIC TX flow tables support reformat opertion, enable it on creation. What is the trigger to use the decap flag on RX

Re: [RFC PATCH mlx5-next 02/18] net/mlx5: Export modify header alloc/dealloc functions

2018-07-16 Thread Or Gerlitz
On Mon, Jul 16, 2018 at 11:22 AM, Leon Romanovsky wrote: > From: Mark Bloch > > Those function will be used by the RDMA side to create modify header function --> functions > actions to be attached to flow steering rules via verbs.

Re: [RFC PATCH mlx5-next 04/18] net/mlx5: Break encap/decap into two separated flags

2018-07-16 Thread Or Gerlitz
On Mon, Jul 16, 2018 at 11:22 AM, Leon Romanovsky wrote: > From: Mark Bloch > > Today we are able to attach encap and decap actions only to the FDB. > In preparation to enable those actions on the NIC flow tables break tables break --> tables, break > the single flag into two.

Re: [RFC PATCH mlx5-next 07/18] net/mlx5: Expose new packet reformat capabilities

2018-07-16 Thread Or Gerlitz
On Mon, Jul 16, 2018 at 11:22 AM, Leon Romanovsky wrote: > From: Mark Bloch > > Expose new abilities when creating a packet reformat context. > > The new types which can be created are: > MLX5_REFORMAT_TYPE_L2_TO_L2_TUNNEL: Ability to create generic encap > opertion to be done by the HW. opertio

Re: [RFC PATCH rdma-next 13/18] RDMA/mlx5: Enable decap and packet reformat on flow tables

2018-07-17 Thread Or Gerlitz
On Tue, Jul 17, 2018 at 12:46 AM, Mark Bloch wrote: >> From: Or Gerlitz [mailto:gerlitz...@gmail.com] >> > If NIC RX flow tables support decap opertion, enable it on creation. >> opertion --> operation saw it? >> > If NIC TX flow tables support reforma

[PATCH net-next 2/3] flow_dissector: Dissect tos and ttl from the tunnel info

2018-07-17 Thread Or Gerlitz
Add dissection of the tos and ttl from the ip tunnel headers fields in case a match is needed on them. Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan Acked-by: Jiri Pirko --- include/net/flow_dissector.h | 2 +- net/core/flow_dissector.c| 14 +- 2 files changed, 14

[PATCH net-next 0/3] set/match the tos/ttl fields of TC based IP tunnels

2018-07-17 Thread Or Gerlitz
enc_dst_ip 192.168.10.1 enc_key_id 100 enc_dst_port 4789 enc_tos 0x30 \ src_mac e4:11:22:33:44:70 dst_mac e4:11:22:33:44:50 \ action tunnel_key unset \ action mirred egress redirect dev eth0_0 Or. Or Gerlitz (3): net/sched: tunnel_key: Allow to set tos and ttl for tc

[PATCH net-next 3/3] net/sched: cls_flower: Support matching on ip tos and ttl for tunnels

2018-07-17 Thread Or Gerlitz
Allow users to set rules matching on ipv4 tos and ttl or ipv6 traffic-class and hoplimit of tunnel headers. Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan Acked-by: Jiri Pirko --- include/uapi/linux/pkt_cls.h | 5 + net/sched/cls_flower.c | 43

[PATCH net-next 1/3] net/sched: tunnel_key: Allow to set tos and ttl for tc based ip tunnels

2018-07-17 Thread Or Gerlitz
Allow user-space to provide tos and ttl to be set for the tunnel headers. Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan Acked-by: Jiri Pirko --- include/uapi/linux/tc_act/tc_tunnel_key.h | 2 ++ net/sched/act_tunnel_key.c| 20 ++-- 2 files changed, 20

Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion

2018-03-11 Thread Or Gerlitz
On 3/7/2018 6:23 PM, David Miller wrote: > From: Paul Blakey > Date: Wed, 7 Mar 2018 16:00:11 +0200 > >> On our mlx5 driver fs_core.c, we use the rhltable interface to store >> flow groups. We noticed that sometimes we get a warning that flow group isn't >> found at removal. This rare case was c

Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion

2018-03-11 Thread Or Gerlitz
On 3/12/2018 4:48 AM, David Miller wrote: > Ok, queued up. thank you

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-13 Thread Or Gerlitz
On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote: > Mon, Mar 05, 2018 at 02:28:30PM CET, john.hur...@netronome.com wrote: >>Allow drivers to register netdev callbacks for tc offload in linux bonds. >>If a netdev has registered and is a slave of a given bond, then any tc >>rules offloaded to the b

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-13 Thread Or Gerlitz
On Tue, Mar 13, 2018 at 5:51 PM, Or Gerlitz wrote: Sorry ppl, I added MLNX alias (asap_direct_...@mellanox.com) which is not open to outer posts, please remove it from your replies, otherwise it will bump you back.. Or. > On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote: >> Mon, Mar

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-13 Thread Or Gerlitz
On Wed, Mar 14, 2018 at 3:50 AM, Jakub Kicinski wrote: > On Tue, 13 Mar 2018 17:53:39 +0200, Or Gerlitz wrote: >> > Starting with type 2, in our current NIC HW APIs we have to duplicate >> > these rules >> > into two rules set to HW: >> > >> > 2.1

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-14 Thread Or Gerlitz
On Wed, Mar 14, 2018 at 11:50 AM, Jiri Pirko wrote: > Tue, Mar 13, 2018 at 04:51:02PM CET, gerlitz...@gmail.com wrote: >>On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote: >>This sounds nice for the case where one install ingress tc rules on >>the bond (lets >>call them type 1, see next) >> >>On

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-15 Thread Or Gerlitz
On Wed, Mar 14, 2018 at 5:56 PM, Jiri Pirko wrote: > Wed, Mar 14, 2018 at 12:23:59PM CET, gerlitz...@gmail.com wrote: >>On Wed, Mar 14, 2018 at 11:50 AM, Jiri Pirko wrote: >>> Tue, Mar 13, 2018 at 04:51:02PM CET, gerlitz...@gmail.com wrote: On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote:

Re: SRIOV switchdev mode BoF minutes

2018-04-12 Thread Or Gerlitz
On Thu, Apr 12, 2018 at 8:05 PM, Samudrala, Sridhar wrote: > On 11/12/2017 11:49 AM, Or Gerlitz wrote: >> >> Hi Dave and all, >> >> During and after the BoF on SRIOV switchdev mode, we came into a >> consensus among the developers from four different HW vendor

Re: SRIOV switchdev mode BoF minutes

2018-04-13 Thread Or Gerlitz
On Thu, Apr 12, 2018 at 11:33 PM, Samudrala, Sridhar wrote: > On 4/12/2018 1:20 PM, Or Gerlitz wrote: >> >> On Thu, Apr 12, 2018 at 8:05 PM, Samudrala, Sridhar >> wrote: >>> >>> On 11/12/2017 11:49 AM, Or Gerlitz wrote: >>>> >>>&g

Re: SRIOV switchdev mode BoF minutes

2018-04-13 Thread Or Gerlitz
On Fri, Apr 13, 2018 at 11:56 AM, Or Gerlitz wrote: > On Thu, Apr 12, 2018 at 11:33 PM, Samudrala, Sridhar > wrote: >> On 4/12/2018 1:20 PM, Or Gerlitz wrote: >>> >>> On Thu, Apr 12, 2018 at 8:05 PM, Samudrala, Sridhar >>> wrote: >>>

Re: SRIOV switchdev mode BoF minutes

2018-04-13 Thread Or Gerlitz
On Fri, Apr 13, 2018 at 7:49 PM, Samudrala, Sridhar wrote: > On 4/13/2018 1:57 AM, Or Gerlitz wrote: >>> in overlay networks scheme, the uplink rep has the VTEP ip and is not >>> connected >>> to the bridge, e.g you use ovs you have vf reps and vxlan ports c

Re: SRIOV switchdev mode BoF minutes

2018-04-14 Thread Or Gerlitz
On Sat, Apr 14, 2018 at 2:03 AM, Samudrala, Sridhar wrote: > I meant between PFs on 2 compute nodes. If the PF serves as uplink rep, it functions as a switch port -- applications don't run on switch ports. One way to get apps to run on the host in switchdev mode is probe one of the VFs there.

Re: [patch net-next RFC 00/12] devlink: introduce port flavours and common phys_port_name generation

2018-04-17 Thread Or Gerlitz
On Thu, Mar 22, 2018 at 1:55 PM, Jiri Pirko wrote: > From: Jiri Pirko > > This patchset resolves 2 issues we have right now: > 1) There are many netdevices / ports in the system, for port, pf, vf >represenatation but the user has no way to see which is which > 2) The ndo_get_phys_port_name is

Re: SRIOV switchdev mode BoF minutes

2018-04-17 Thread Or Gerlitz
On Tue, Apr 17, 2018 at 4:30 PM, Andy Gospodarek wrote: > On Mon, Apr 16, 2018 at 07:08:39PM -0700, Samudrala, Sridhar wrote: >> >> On 4/16/2018 5:39 AM, Andy Gospodarek wrote: >> > On Sun, Apr 15, 2018 at 09:01:16AM +0300, Or Gerlitz wrote: >> > > On Sat

Re: [for-next 01/14] net/mlx5: Fixed sparse issues

2018-03-05 Thread Or Gerlitz
On Mon, Mar 5, 2018 at 10:46 PM, Saeed Mahameed wrote: > From: Aviad Yehezkel > > 1. Local fucntions should be static. s/fucntions/functions/ > 2. Missing declarations warnings. > > Signed-off-by: Aviad Yehezkel > Signed-off-by: Saeed Mahameed > --- > drivers/net/ethernet/mellanox/mlx5/core/

Re: [RFC net-next 4/6] nfp: add ndo_set_mac_address for representors

2018-03-05 Thread Or Gerlitz
On Mon, Mar 5, 2018 at 3:28 PM, John Hurley wrote: > A representor hardware address does not have any meaning outside of the > kernel netdev/networking stack. Thus there is no need for any app specific > code for setting a representors hardware address, the default eth_mac_addr > is sufficient. w

Re: [RFC net-next 0/6] offload linux bonding tc ingress rules

2018-03-05 Thread Or Gerlitz
On Mon, Mar 5, 2018 at 3:28 PM, John Hurley wrote: > This RFC patchset adds support for offloading tc ingress rules applied to > linux bonds. The premise of these patches is that if a rule is applied to > a bond port then the rule should be applied to each slave of the bond. > > The linux bond its

Re: [PATCH/RFC net-next 0/3] introduce Geneve options support in TC tunnel key

2018-03-06 Thread Or Gerlitz
On Tue, Mar 6, 2018 at 7:08 PM, Simon Horman wrote: > Hi all, > > This set adds Geneve options support to the TC tunnel key action. > Options TLVs are exposed to userspace using a list of netlink attributes > with each option described using attributes for class, type and data. can you comment re

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-25 Thread Or Gerlitz
On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman wrote: > From: Simon Horman > > John says: > > This patch set allows offloading of TC flower match and set tunnel fields > to the NFP. The initial focus is on VXLAN traffic. Due to the current > state of the NFP firmware, only VXLAN traffic on well kn

Re: [PATCH net-next 7/7] nfp: flower vxlan neighbour keep-alive

2017-09-25 Thread Or Gerlitz
On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman wrote: > From: John Hurley > > Periodically receive messages containing the destination IPs of tunnels > that have recently forwarded traffic. Update the neighbour entries 'used' > value for these IPs next hop. Are you proactively sending keep alive

Re: [PATCH net-next 2/7] nfp: compile flower vxlan tunnel metadata match fields

2017-09-25 Thread Or Gerlitz
On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman wrote: > From: John Hurley > > Compile ovs-tc flower vxlan metadata match fields for offloading. Only anything in the npf kernel bits has direct relation to ovs? what? > +++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c > @@ -52,8 +52,25 @@

  1   2   3   4   5   6   7   8   9   10   >