On Thu, Feb 21, 2019 at 3:42 PM <xiangxia.m....@gmail.com> wrote: > else /* namespace is MLX5_FLOW_NAMESPACE_KERNEL - NIC offloading */ > max_actions = MLX5_CAP_FLOWTABLE_NIC_RX(priv->mdev, > max_modify_header_actions); > > + if (!max_actions) { > + NL_SET_ERR_MSG_MOD(extack, > + "don't support pedit actions, can't > offload"); > + netdev_warn(priv->netdev, "don't support pedit actions, can't > offload\n");
it's not going to work if we keep filling the driver with duplicated error messages, stick to extack only Also, when you respin with comments provided on this submission, please send also cover letter which is going to be "[PATCH net-next 00/05] ... " use --cover-letter for git format-patch and edit it after creation