On Fri, Feb 22, 2019 at 12:35 AM Saeed Mahameed <sae...@mellanox.com> wrote: > On Thu, 2019-02-21 at 12:21 +0200, Or Gerlitz wrote:
> So we all agree that the offending patch is "net/mlx5e: Support tunnel > encap over tagged Ethernet" even if the issue existed before, as you said the issue existed before we added support for offloading tunnels in the presence of vlan on the underlay, it's like this since 4.12 when we introduced support for neigh update in 232c001398ae "net/mlx5e: Add support to neighbour update flow" which is basically the one to blame/fix since some code was moved and some code was added (e->route_dev) backporting the patch without pulling more patches can be done as I sketched below. Anyway, we can maybe let it go without backporting, production environments are typically not changing their source mac in prime time. So this can be seen more as future proofing. > in order to fix the issue you will have to port not only this patch but > the whole series which claimed to fix the issue, so the fixes tag was > wrong.. this patch on its own is no good. >> [1] using e->out_dev instead of e->route_dev >> [2] use the hunks from mlx5e_tc_tun_create_header_ipv4/6() in >> mlx5e_create_encap_header_ipv4/6()
