Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Miguel Ojeda
On Sun, Nov 22, 2020 at 11:36 PM James Bottomley wrote: > > Well, it seems to be three years of someone's time plus the maintainer > review time and series disruption of nearly a thousand patches. Let's > be conservative and assume the producer worked about 30% on the series > and it takes about

Re: [PATCH net-next 10/10] mptcp: refine MPTCP-level ack scheduling

2020-11-23 Thread Paolo Abeni
Hi, On Mon, 2020-11-23 at 12:57 +0100, Eric Dumazet wrote: > > diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c > > index 4ae2c4a30e44..748343f1a968 100644 > > --- a/net/mptcp/protocol.c > > +++ b/net/mptcp/protocol.c > > @@ -407,16 +407,42 @@ static void mptcp_set_timeout(const struct soc

Hardcoded multicast queue length in macvlan.c driver causes poor multicast receive performance

2020-11-23 Thread Thomas Karlsson
Hello, There is a special queue handling in macvlan.c for broadcast and multicast packages that was arbitrarily set to 1000 in commit 07d92d5cc977a7fe1e683e1d4a6f723f7f2778cb . While this is probably sufficient for most uses cases it is insufficient to support high packet rates. I currently ha

Re: [arm64] kernel BUG at kernel/seccomp.c:1309!

2020-11-23 Thread Gabriel Krisman Bertazi
Jann Horn writes: > On Mon, Nov 23, 2020 at 2:45 PM Arnd Bergmann wrote: >> On Mon, Nov 23, 2020 at 12:15 PM Naresh Kamboju >> wrote: >> > >> > While booting arm64 kernel the following kernel BUG noticed on several >> > arm64 >>

Re: [PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Nikolay Aleksandrov
On 23/11/2020 14:31, Horatiu Vultur wrote: > The 11/23/2020 14:13, Nikolay Aleksandrov wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> On 23/11/2020 13:14, Horatiu Vultur wrote: >>> Extend MRP to support LC mode(link check) for the inte

Re: [PATCH net-next v2 1/2] lockdep: Introduce in_softirq lockdep assert

2020-11-23 Thread Peter Zijlstra
On Sat, Nov 21, 2020 at 11:06:15AM +0800, Yunsheng Lin wrote: > The current semantic for napi_consume_skb() is that caller need > to provide non-zero budget when calling from NAPI context, and > breaking this semantic will cause hard to debug problem, because > _kfree_skb_defer() need to run in ato

Re: [PATCH v3 1/1] xdp: remove the function xsk_map_inc

2020-11-23 Thread Zhu Yanjun
On Mon, Nov 23, 2020 at 10:27 PM wrote: > > From: Zhu Yanjun > > The function xsk_map_inc is a simple wrapper of bpf_map_inc and > always returns zero. As such, replacing this function with bpf_map_inc > and removing the test code. > > Signed-off-by: Zhu Yanjun > --- > net/xdp/xsk.c| 2 +-

Re: netconsole deadlock with virtnet

2020-11-23 Thread Steven Rostedt
On Mon, 23 Nov 2020 13:08:55 +0200 Leon Romanovsky wrote: > [ 10.028024] Chain exists of: > [ 10.028025] console_owner --> target_list_lock --> _xmit_ETHER#2 Note, the problem is that we have a location that grabs the xmit_lock while holding target_list_lock (and possibly console_owner)

Re: [PATCH v3 1/1] xdp: remove the function xsk_map_inc

2020-11-23 Thread Magnus Karlsson
On Mon, Nov 23, 2020 at 3:30 PM Zhu Yanjun wrote: > > On Mon, Nov 23, 2020 at 10:27 PM wrote: > > > > From: Zhu Yanjun > > > > The function xsk_map_inc is a simple wrapper of bpf_map_inc and > > always returns zero. As such, replacing this function with bpf_map_inc > > and removing the test code

[PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread stefanc
From: Stefan Chulski Tx/Rx FIFO is a HW resource limited by total size, but shared by all ports of same CP110 and impacting port-performance. Do not divide the FIFO for ports which are not enabled in DTS, so active ports could have more FIFO. The active port mapping should be done in probe befor

Re: [PATCH] dpaa2-eth: Fix compile error due to missing devlink support

2020-11-23 Thread Ezequiel Garcia
Hi Ioana, On Mon, 2020-11-23 at 09:39 +, Ioana Ciornei wrote: > Hi Ezequiel, > > Thanks a lot for the fix, I overlooked this when adding devlink support. > No worries :) > On Sat, Nov 21, 2020 at 09:23:36PM -0300, Ezequiel Garcia wrote: > > The dpaa2 driver depends on devlink, so it should

[PATCH v3 1/1] xdp: remove the function xsk_map_inc

2020-11-23 Thread Zhu Yanjun
From: Zhu Yanjun The function xsk_map_inc is a simple wrapper of bpf_map_inc and always returns zero. As such, replacing this function with bpf_map_inc and removing the test code. Signed-off-by: Zhu Yanjun --- net/xdp/xsk.c| 2 +- net/xdp/xsk.h| 1 - net/xdp/xskmap.c | 13 +--

Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Russell King - ARM Linux admin
Hi, On Mon, Nov 23, 2020 at 04:52:40PM +0200, stef...@marvell.com wrote: > From: Stefan Chulski > > Tx/Rx FIFO is a HW resource limited by total size, but shared > by all ports of same CP110 and impacting port-performance. > Do not divide the FIFO for ports which are not enabled in DTS, > so act

Re: [PATCH] dpaa2-eth: Fix compile error due to missing devlink support

2020-11-23 Thread Ioana Ciornei
On Mon, Nov 23, 2020 at 12:06:14PM -0300, Ezequiel Garcia wrote: > Hi Ioana, > > On Mon, 2020-11-23 at 09:39 +, Ioana Ciornei wrote: > > Hi Ezequiel, > > > > Thanks a lot for the fix, I overlooked this when adding devlink support. > > > > No worries :) > > > On Sat, Nov 21, 2020 at 09:23:3

[PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Horatiu Vultur
Extend MRP to support LC mode(link check) for the interconnect port. This applies only to the interconnect ring. Opposite to RC mode(ring check) the LC mode is using CFM frames to detect when the link goes up or down and based on that the userspace will need to react. One advantage of the LC mode

RE: [EXT] Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Stefan Chulski
> -Original Message- > From: Russell King - ARM Linux admin > Sent: Monday, November 23, 2020 5:11 PM > To: Stefan Chulski > Cc: netdev@vger.kernel.org; thomas.petazz...@bootlin.com; > da...@davemloft.net; Nadav Haklai ; Yan Markman > ; linux-ker...@vger.kernel.org; k...@kernel.org; > m..

Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Russell King - ARM Linux admin
On Mon, Nov 23, 2020 at 03:10:49PM +, Russell King - ARM Linux admin wrote: > Hi, > > On Mon, Nov 23, 2020 at 04:52:40PM +0200, stef...@marvell.com wrote: > > From: Stefan Chulski > > > > Tx/Rx FIFO is a HW resource limited by total size, but shared > > by all ports of same CP110 and impacti

Re: [EXT] Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Russell King - ARM Linux admin
On Mon, Nov 23, 2020 at 03:26:11PM +, Stefan Chulski wrote: > > -Original Message- > > From: Russell King - ARM Linux admin > > Sent: Monday, November 23, 2020 5:11 PM > > To: Stefan Chulski > > Cc: netdev@vger.kernel.org; thomas.petazz...@bootlin.com; > > da...@davemloft.net; Nadav H

Re: [PATCH net] bonding: fix feature flag setting at init time

2020-11-23 Thread kernel test robot
Hi Jarod, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on next-20201123] [cannot apply to net/master linux/master linus/master sparc-next/master v5.10-rc5] [If your patch is applied to the wrong git tree, kindly drop us a

[PATCH net-next 03/15] net: phy: icplus: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt(), .did_

[PATCH net-next 05/15] net: phy: meson-gxl: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt(), .did_

[PATCH net-next 07/15] net: phy: micrel: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt(), .did_

[PATCH net-next 08/15] net: phy: micrel: remove the use of .ack_interrupt()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing interrupt

[PATCH net-next 09/15] net: phy: national: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt(), .did_

[PATCH net-next 10/15] net: phy: national: remove the use of the .ack_interrupt()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing interrupt

[PATCH net-next 13/15] net: phy: qsemi: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt(), .did_

[PATCH net-next 11/15] net: phy: ti: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt(), .did_

[PATCH net-next 14/15] net: phy: qsemi: remove the use of .ack_interrupt()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing interrupt

[PATCH net-next 04/15] net: phy: icplus: remove the use .ack_interrupt()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing interrupt

[PATCH net-next 12/15] net: phy: ti: remove the use of .ack_interrupt()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing interrupt

[PATCH net-next 06/15] net: phy: meson-gxl: remove the use of .ack_callback()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing interrupt

[PATCH net-next 15/15] net: phy: remove the .did_interrupt() and .ack_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei Now that all the PHY drivers have been migrated to directly implement the generic .handle_interrupt() callback for a seamless support of shared IRQs and all the .config_inter() implementations clear any pending interrupts, we can safely remove the two callbacks. With this pat

[PATCH net-next 00/15] net: phy: add support for shared interrupts (part 3)

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei This patch set aims to actually add support for shared interrupts in phylib and not only for multi-PHY devices. While we are at it, streamline the interrupt handling in phylib. For a bit of context, at the moment, there are multiple phy_driver ops that deal with this subject:

[PATCH net-next 01/15] net: phy: intel-xway: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt(), .did_

[PATCH net-next 02/15] net: phy: intel-xway: remove the use of .ack_interrupt()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing interrupt

RE: [EXT] Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Stefan Chulski
> > > On Mon, Nov 23, 2020 at 04:52:40PM +0200, stef...@marvell.com wrote: > > > > From: Stefan Chulski > > > > > > > > Tx/Rx FIFO is a HW resource limited by total size, but shared by > > > > all ports of same CP110 and impacting port-performance. > > > > Do not divide the FIFO for ports which ar

[PATCH v2 net-next] net: page_pool: Add page_pool_put_page_bulk() to page_pool.rst

2020-11-23 Thread Lorenzo Bianconi
Introduce page_pool_put_page_bulk() entry into the API section of page_pool.rst Acked-by: Ilias Apalodimas Signed-off-by: Lorenzo Bianconi --- Changes since v1: - addressed Ilias's comments --- Documentation/networking/page_pool.rst | 8 1 file changed, 8 insertions(+) diff --git a/Do

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-23 Thread Jani Nikula
On Sat, 21 Nov 2020, James Bottomley wrote: > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: >> A difficult part of automating commits is composing the subsystem >> preamble in the commit log. For the ongoing effort of a fixer >> producing >> one or two fixes a release the use of 'tre

Re: [EXT] Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Russell King - ARM Linux admin
On Mon, Nov 23, 2020 at 03:44:05PM +, Stefan Chulski wrote: > > > > On Mon, Nov 23, 2020 at 04:52:40PM +0200, stef...@marvell.com wrote: > > > > > From: Stefan Chulski > > > > > > > > > > Tx/Rx FIFO is a HW resource limited by total size, but shared by > > > > > all ports of same CP110 and imp

[PATCH] entry: Fix boot for !CONFIG_GENERIC_ENTRY

2020-11-23 Thread Gabriel Krisman Bertazi
Gabriel Krisman Bertazi writes: > Jann Horn writes: >> As part of fixing this, it might be a good idea to put "enum >> syscall_work_bit" behind a "#ifdef CONFIG_GENERIC_ENTRY" to avoid >> future accidents like this? > > Hi Jan, Arnd, > > That is correct. This is a copy pasta mistake. My apolog

Re: [PATCH] drivers: Fix the Raspberry Pi debug version compile

2020-11-23 Thread Kalle Valo
byhoo writes: > The steps: > 1. add "#define DEBUG" in > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c line 61. > 2. make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=../Out_Linux > bcm2835_defconfig > 3. make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=../Out_Linux/ > zImage modules

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread James Bottomley
On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote: > On Sun, Nov 22, 2020 at 11:36 PM James Bottomley > wrote: > > Well, it seems to be three years of someone's time plus the > > maintainer review time and series disruption of nearly a thousand > > patches. Let's be conservative and assume th

Re: [PATCH] drivers: Fix the Raspberry Pi debug version compile

2020-11-23 Thread Kalle Valo
hby writes: > enable the DEBUG in source code, and it will compile fail, > modify the DEBUG macro, to adapt the compile > > Signed-off-by: hby > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This has nothing to do wit

RE: [EXT] Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Stefan Chulski
> -Original Message- > From: Russell King - ARM Linux admin > Sent: Monday, November 23, 2020 5:52 PM > To: Stefan Chulski > Cc: netdev@vger.kernel.org; thomas.petazz...@bootlin.com; > da...@davemloft.net; Nadav Haklai ; Yan Markman > ; linux-ker...@vger.kernel.org; k...@kernel.org; >

pull-request: wireless-drivers-2020-11-23

2020-11-23 Thread Kalle Valo
Hi, here's a pull request to net tree, more info below. Please let me know if there are any problems. Kalle The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) are available in the git repository at: git://git.kernel.org/

Re: [PATCH net] netdevice.h: Fix unintentional disable of ALL_FOR_ALL features on upper device

2020-11-23 Thread Tariq Toukan
On 11/23/2020 4:55 PM, Eric Dumazet wrote: On Mon, Nov 23, 2020 at 3:13 PM Tariq Toukan wrote: Calling netdev_increment_features() on upper/master device from netdev_add_tso_features() implies unintentional clearance of ALL_FOR_ALL features supported by all slaves. Fix it by passing ALL_FO

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-23 Thread Lukas Bulwahn
On Mon, Nov 23, 2020 at 4:52 PM Jani Nikula wrote: > > On Sat, 21 Nov 2020, James Bottomley > wrote: > > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: > >> A difficult part of automating commits is composing the subsystem > >> preamble in the commit log. For the ongoing effort of a

Re: [PATCH V2 net 4/4] net: ena: return error code from ena_xdp_xmit_buff

2020-11-23 Thread Jakub Kicinski
On Sun, 22 Nov 2020 09:19:05 +0200 Shay Agroskin wrote: > Jakub Kicinski writes: > > > On Thu, 19 Nov 2020 22:28:51 +0200 Shay Agroskin wrote: > >> The function mistakenly returns NETDEV_TX_OK regardless of the > >> transmission success. This patch fixes this behavior by > >> returning the > >

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Rafael J. Wysocki
On Mon, Nov 23, 2020 at 4:58 PM James Bottomley wrote: > > On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote: > > On Sun, Nov 22, 2020 at 11:36 PM James Bottomley > > wrote: [cut] > > > > Maintainers routinely review 1-line trivial patches, not to mention > > internal API changes, etc. > >

[PATCH] tools/testing: add kselftest shell helper library

2020-11-23 Thread Willem de Bruijn
From: Willem de Bruijn Kselftest expects processes to signal pass/fail/skip through exitcode. C programs can include kselftest.h for readable definitions. Add analogous kselftest.sh for shell tests. Extract the existing definitions from udpgso_bench.sh. Tested: make TARGETS=net kselftest Link:

[PATCH] nfc: s3fwrn5: use signed integer for parsing GPIO numbers

2020-11-23 Thread Krzysztof Kozlowski
GPIOs - as returned by of_get_named_gpio() and used by the gpiolib - are signed integers, where negative number indicates error. The return value of of_get_named_gpio() should not be assigned to an unsigned int because in case of !CONFIG_GPIOLIB such number would be a valid GPIO. Fixes: c04c674fa

Re: [PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Horatiu Vultur
The 11/23/2020 14:13, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 23/11/2020 13:14, Horatiu Vultur wrote: > > Extend MRP to support LC mode(link check) for the interconnect port. > > This applies only to the inte

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Joe Perches
On Mon, 2020-11-23 at 07:58 -0800, James Bottomley wrote: > We're also complaining about the inability to recruit maintainers: > > https://www.theregister.com/2020/06/30/hard_to_find_linux_maintainers_says_torvalds/ > > And burn out: > > http://antirez.com/news/129 https://www.wired.com/story/o

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread James Bottomley
On Mon, 2020-11-23 at 07:03 -0600, Gustavo A. R. Silva wrote: > On Sun, Nov 22, 2020 at 11:53:55AM -0800, James Bottomley wrote: > > On Sun, 2020-11-22 at 11:22 -0800, Joe Perches wrote: > > > On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote: > > > > On Sun, 2020-11-22 at 10:25 -0800, Joe P

Re: [net v3] net/tls: missing received data after fast remote close

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 13:40:46 + Vadim Fedorenko wrote: > On 20.11.2020 18:26, Jakub Kicinski wrote: > > On Thu, 19 Nov 2020 18:59:48 +0300 Vadim Fedorenko wrote: > >> In case when tcp socket received FIN after some data and the > >> parser haven't started before reading data caller will receiv

[PATCH net] dpaa2-eth: Fix compile error due to missing devlink support

2020-11-23 Thread Ioana Ciornei
From: Ezequiel Garcia The dpaa2 driver depends on devlink, so it should select NET_DEVLINK in order to fix compile errors, such as: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err': dpaa2-eth.c:(.text+0x3cec): undefined reference to `devlink_trap_report' drivers/

Re: inconsistent lock state in io_file_data_ref_zero

2020-11-23 Thread Jens Axboe
On 11/23/20 2:55 AM, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:27bba9c5 Merge tag 'scsi-fixes' of git://git.kernel.org/pu.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=11041f1e50 > kernel config: https://syz

Re: [PATCH v4] aquantia: Remove the build_skb path

2020-11-23 Thread Jakub Kicinski
On Sun, 22 Nov 2020 22:36:22 + Ramsay, Lincoln wrote: > > (Next time please include in the subject the tree that you're targetting > > the patch) > > I guess you mean like [PATCH master v5] ? Should I be targeting > something other than the master branch on the main git repo? > (https://gith

Re: [PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

2020-11-23 Thread Miguel Ojeda
On Mon, Nov 23, 2020 at 4:37 AM Masahiro Yamada wrote: > > I can move it to compiler_attribute.h > > This attribute is supported by gcc, clang, and icc. > https://godbolt.org/z/ehd6so > > I can send v2. > > I do not mind renaming, but it should be done in a separate patch. Of course -- sorry, I d

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-23 Thread Tom Rix
On 11/22/20 10:22 AM, Joe Perches wrote: > On Sun, 2020-11-22 at 08:33 -0800, Tom Rix wrote: >> On 11/21/20 9:10 AM, Joe Perches wrote: >>> On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: A difficult part of automating commits is composing the subsystem preamble in the commit

Re: [kbuild-all] Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 09:13:49 +0800 Rong Chen wrote: > Sorry for the inconvenience, we have optimized the build bot to avoid > this situation. Great to hear, thank you!

Re: [EXT] Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Russell King - ARM Linux admin
On Mon, Nov 23, 2020 at 04:03:00PM +, Stefan Chulski wrote: > > -Original Message- > > From: Russell King - ARM Linux admin > > Sent: Monday, November 23, 2020 5:52 PM > > To: Stefan Chulski > > Cc: netdev@vger.kernel.org; thomas.petazz...@bootlin.com; > > da...@davemloft.net; Nadav H

Re: memory leak in inet_create (2)

2020-11-23 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:418baf2c Linux 5.10-rc5 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=161c84ed50 kernel config: https://syzkaller.appspot.com/x/.config?x=5524c10373633a9c dashboard link: https://syz

[PATCH net-next v4 1/7] dpaa_eth: add struct for software backpointers

2020-11-23 Thread Camelia Groza
We maintain an skb backpointer in the software annotations area of Tx frames. Introduce a structure for explicit handling. Acked-by: Madalin Bucur Signed-off-by: Camelia Groza --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 16 +--- drivers/net/ethernet/freescale/dpaa/dpaa_eth.

[PATCH net-next v4 0/7] dpaa_eth: add XDP support

2020-11-23 Thread Camelia Groza
Enable XDP support for the QorIQ DPAA1 platforms. Implement all the current actions (DROP, ABORTED, PASS, TX, REDIRECT). No Tx batching is added at this time. Additional XDP_PACKET_HEADROOM bytes are reserved in each frame's headroom. After transmit, a reference to the xdp_frame is saved in the

[PATCH net-next v4 5/7] dpaa_eth: add XDP_REDIRECT support

2020-11-23 Thread Camelia Groza
After transmission, the frame is returned on confirmation queues for cleanup. For this, store a backpointer to the xdp_frame in the private reserved area at the start of the TX buffer. No TX batching support is implemented at this time. Acked-by: Madalin Bucur Signed-off-by: Camelia Groza ---

[PATCH net-next v4 2/7] dpaa_eth: add basic XDP support

2020-11-23 Thread Camelia Groza
Implement the XDP_DROP and XDP_PASS actions. Avoid draining and reconfiguring the buffer pool at each XDP setup/teardown by increasing the frame headroom and reserving XDP_PACKET_HEADROOM bytes from the start. Since we always reserve an entire page per buffer, this change only impacts Jumbo frame

[PATCH net-next v4 3/7] dpaa_eth: limit the possible MTU range when XDP is enabled

2020-11-23 Thread Camelia Groza
Implement the ndo_change_mtu callback to prevent users from setting an MTU that would permit processing of S/G frames. The maximum MTU size is dependent on the buffer size. Acked-by: Madalin Bucur Signed-off-by: Camelia Groza --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 40 +

[PATCH net-next v4 7/7] dpaa_eth: implement the A050385 erratum workaround for XDP

2020-11-23 Thread Camelia Groza
For XDP TX, even tough we start out with correctly aligned buffers, the XDP program might change the data's alignment. For REDIRECT, we have no control over the alignment either. Create a new workaround for xdp_frame structures to verify the erratum conditions and move the data to a fresh buffer i

[PATCH net-next v4 4/7] dpaa_eth: add XDP_TX support

2020-11-23 Thread Camelia Groza
Use an xdp_frame structure for managing the frame. Store a backpointer to the structure at the start of the buffer before enqueueing for cleanup on TX confirmation. Reserve DPAA_TX_PRIV_DATA_SIZE bytes from the frame size shared with the XDP program for this purpose. Use the XDP API for freeing the

[PATCH net-next v4 6/7] dpaa_eth: rename current skb A050385 erratum workaround

2020-11-23 Thread Camelia Groza
Explicitly point that the current workaround addresses skbs. This change is in preparation for adding a workaround for XDP scenarios. Acked-by: Madalin Bucur Signed-off-by: Camelia Groza --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v5 0/9] "Task_isolation" mode

2020-11-23 Thread Alex Belits
This is an update of task isolation work that was originally done by Chris Metcalf and maintained by him until November 2017. It is adapted to the current kernel and cleaned up to implement its functionality in a more complete and cleaner manner. Previous version is at https://lore.kernel.org/net

[PATCH net-next] netfilter: bridge: reset skb->pkt_type after NF_INET_POST_ROUTING traversal

2020-11-23 Thread Antoine Tenart
Netfilter changes PACKET_OTHERHOST to PACKET_HOST before invoking the hooks as, while it's an expected value for a bridge, routing expects PACKET_HOST. The change is undone later on after hook traversal. This can be seen with pairs of functions updating skb>pkt_type and then reverting it to its ori

RE: [EXT] Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Stefan Chulski
> -Original Message- > From: Russell King - ARM Linux admin > Sent: Monday, November 23, 2020 7:30 PM > To: Stefan Chulski > Cc: netdev@vger.kernel.org; thomas.petazz...@bootlin.com; > da...@davemloft.net; Nadav Haklai ; Yan Markman > ; linux-ker...@vger.kernel.org; k...@kernel.org; >

[PATCH bpf v2] net, xsk: Avoid taking multiple skbuff references

2020-11-23 Thread Björn Töpel
From: Björn Töpel Commit 642e450b6b59 ("xsk: Do not discard packet when NETDEV_TX_BUSY") addressed the problem that packets were discarded from the Tx AF_XDP ring, when the driver returned NETDEV_TX_BUSY. Part of the fix was bumping the skbuff reference count, so that the buffer would not be free

[PATCH v5 1/9] task_isolation: vmstat: add quiet_vmstat_sync function

2020-11-23 Thread Alex Belits
From: Chris Metcalf In commit f01f17d3705b ("mm, vmstat: make quiet_vmstat lighter") the quiet_vmstat() function became asynchronous, in the sense that the vmstat work was still scheduled to run on the core when the function returned. For task isolation, we need a synchronous version of the func

[PATCH v2] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread stefanc
From: Stefan Chulski Tx/Rx FIFO is a HW resource limited by total size, but shared by all ports of same CP110 and impacting port-performance. Do not divide the FIFO for ports which are not enabled in DTS, so active ports could have more FIFO. No change in FIFO allocation if all 3 ports on the com

[PATCH v5 3/9] task_isolation: userspace hard isolation from kernel

2020-11-23 Thread Alex Belits
The existing nohz_full mode is designed as a "soft" isolation mode that makes tradeoffs to minimize userspace interruptions while still attempting to avoid overheads in the kernel entry/exit path, to provide 100% kernel semantics, etc. However, some applications require a "hard" commitment from th

[PATCH v5 2/9] task_isolation: vmstat: add vmstat_idle function

2020-11-23 Thread Alex Belits
From: Chris Metcalf This function checks to see if a vmstat worker is not running, and the vmstat diffs don't require an update. The function is called from the task-isolation code to see if we need to actually do some work to quiet vmstat. Signed-off-by: Chris Metcalf Signed-off-by: Alex Beli

[PATCH v5 5/9] task_isolation: Add driver-specific hooks

2020-11-23 Thread Alex Belits
Some drivers don't call functions that call task_isolation_kernel_enter() in interrupt handlers. Call it directly. Signed-off-by: Alex Belits --- drivers/irqchip/irq-armada-370-xp.c | 6 ++ drivers/irqchip/irq-gic-v3.c| 3 +++ drivers/irqchip/irq-gic.c | 3 +++ drivers/s390

[PATCH v5 4/9] task_isolation: Add task isolation hooks to arch-independent code

2020-11-23 Thread Alex Belits
Kernel entry and exit functions for task isolation are added to context tracking and common entry points. Common handling of pending work on exit to userspace now processes isolation breaking, cleanup and start. Signed-off-by: Chris Metcalf [abel...@marvell.com: adapted for kernel 5.10] Signed-of

[PATCH v5 6/9] task_isolation: arch/arm64: enable task isolation functionality

2020-11-23 Thread Alex Belits
In do_notify_resume(), call task_isolation_before_pending_work_check() first, to report isolation breaking, then after handling all pending work, call task_isolation_start() for TIF_TASK_ISOLATION tasks. Add _TIF_TASK_ISOLATION to _TIF_WORK_MASK, and _TIF_SYSCALL_WORK, define local NOTIFY_RESUME_L

[PATCH v5 9/9] task_isolation: kick_all_cpus_sync: don't kick isolated cpus

2020-11-23 Thread Alex Belits
From: Yuri Norov Make sure that kick_all_cpus_sync() does not call CPUs that are running isolated tasks. Signed-off-by: Yuri Norov [abel...@marvell.com: use safe task_isolation_cpumask() implementation] Signed-off-by: Alex Belits --- kernel/smp.c | 14 +- 1 file changed, 13 insert

[PATCH v5 8/9] task_isolation: ringbuffer: don't interrupt CPUs running isolated tasks on buffer resize

2020-11-23 Thread Alex Belits
From: Yuri Norov CPUs running isolated tasks are in userspace, so they don't have to perform ring buffer updates immediately. If ring_buffer_resize() schedules the update on those CPUs, isolation is broken. To prevent that, updates for CPUs running isolated tasks are performed locally, like for o

[PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-11-23 Thread Alex Belits
From: Yuri Norov For nohz_full CPUs the desirable behavior is to receive interrupts generated by tick_nohz_full_kick_cpu(). But for hard isolation it's obviously not desirable because it breaks isolation. This patch adds check for it. Signed-off-by: Yuri Norov [abel...@marvell.com: updated, on

Re: [PATCH net-next 0/2] TLS TX HW offload for Bond

2020-11-23 Thread Jakub Kicinski
On Sun, 22 Nov 2020 14:48:04 +0200 Tariq Toukan wrote: > On 11/19/2020 6:38 PM, Jakub Kicinski wrote: > > On Thu, 19 Nov 2020 17:59:38 +0200 Tariq Toukan wrote: > >> On 11/19/2020 2:02 AM, Jakub Kicinski wrote: > >>> On Sun, 15 Nov 2020 15:42:49 +0200 Tariq Toukan wrote: > This series op

[net-next v3 4/8] seg6: add callbacks for customizing the creation/destruction of a behavior

2020-11-23 Thread Andrea Mayer
We introduce two callbacks used for customizing the creation/destruction of a SRv6 behavior. Such callbacks are defined in the new struct seg6_local_lwtunnel_ops and hereafter we provide a brief description of them: - build_state(...): used for calling the custom constructor of the behavior du

[iproute2-next v1 1/1] seg6: add support for vrftable attribute in End.DT4/DT6 behaviors

2020-11-23 Thread Andrea Mayer
introduces the "vrftable" attribute for supporting the End.DT4 and End.DT6 behaviors in iproute2. The "vrftable" attribute indicates the routing table associated with the VRF device used by SRv6 End.DT4/DT6 for routing IPv4/IPv6 packets. The End.DT4/DT6 is used to implement IPv4/IPv6 L3 VPNs based

[net-next v3 0/8] seg6: add support for SRv6 End.DT4/DT6 behavior

2020-11-23 Thread Andrea Mayer
This patchset provides support for the SRv6 End.DT4 and SRv6 End.DT6 (VRF mode) behavior. The SRv6 End.DT4 is used to implement multi-tenant IPv4 L3 VPN. It decapsulates the received packets and performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux implementation

[net-next v3 5/8] seg6: add support for the SRv6 End.DT4 behavior

2020-11-23 Thread Andrea Mayer
SRv6 End.DT4 is defined in the SRv6 Network Programming [1]. The SRv6 End.DT4 is used to implement IPv4 L3VPN use-cases in multi-tenants environments. It decapsulates the received packets and it performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux implementation

[net-next v3 7/8] selftests: add selftest for the SRv6 End.DT4 behavior

2020-11-23 Thread Andrea Mayer
this selftest is designed for evaluating the new SRv6 End.DT4 behavior used, in this example, for implementing IPv4 L3 VPN use cases. Signed-off-by: Andrea Mayer Reviewed-by: David Ahern --- .../selftests/net/srv6_end_dt4_l3vpn_test.sh | 494 ++ 1 file changed, 494 insertions(+

[net-next v3 6/8] seg6: add VRF support for SRv6 End.DT6 behavior

2020-11-23 Thread Andrea Mayer
SRv6 End.DT6 is defined in the SRv6 Network Programming [1]. The Linux kernel already offers an implementation of the SRv6 End.DT6 behavior which permits IPv6 L3 VPNs over SRv6 networks. This implementation is not particularly suitable in contexts where we need to deploy IPv6 L3 VPNs among differe

[net-next v3 1/8] vrf: add mac header for tunneled packets when sniffer is attached

2020-11-23 Thread Andrea Mayer
Before this patch, a sniffer attached to a VRF used as the receiving interface of L3 tunneled packets detects them as malformed packets and it complains about that (i.e.: tcpdump shows bogus packets). The reason is that a tunneled L3 packet does not carry any L2 information and when the VRF is set

[net-next v3 2/8] seg6: improve management of behavior attributes

2020-11-23 Thread Andrea Mayer
Depending on the attribute (i.e.: SEG6_LOCAL_SRH, SEG6_LOCAL_TABLE, etc), the parse() callback performs some validity checks on the provided input and updates the tunnel state (slwt) with the result of the parsing operation. However, an attribute may also need to reserve some additional resources (

[net-next v3 8/8] selftests: add selftest for the SRv6 End.DT6 (VRF) behavior

2020-11-23 Thread Andrea Mayer
this selftest is designed for evaluating the new SRv6 End.DT6 (VRF) behavior used, in this example, for implementing IPv6 L3 VPN use cases. Signed-off-by: Andrea Mayer Signed-off-by: Paolo Lungaroni --- .../selftests/net/srv6_end_dt6_l3vpn_test.sh | 502 ++ 1 file changed, 502

[net-next v3 3/8] seg6: add support for optional attributes in SRv6 behaviors

2020-11-23 Thread Andrea Mayer
Before this patch, each SRv6 behavior specifies a set of required attributes that must be provided by the userspace application when such behavior is going to be instantiated. If at least one of the required attributes is not provided, the creation of the behavior fails. The SRv6 behavior framewor

Re: [PATCH net-next] netfilter: bridge: reset skb->pkt_type after NF_INET_POST_ROUTING traversal

2020-11-23 Thread Florian Westphal
Antoine Tenart wrote: > Netfilter changes PACKET_OTHERHOST to PACKET_HOST before invoking the > hooks as, while it's an expected value for a bridge, routing expects > PACKET_HOST. The change is undone later on after hook traversal. This > can be seen with pairs of functions updating skb>pkt_type a

Re: [PATCH net-next v5] net/tun: Call netdev notifiers

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 07:18:07 +0100 Martin Schiller wrote: > On 2020-11-20 19:28, Jakub Kicinski wrote: > > On Wed, 18 Nov 2020 07:39:19 +0100 Martin Schiller wrote: > >> Call netdev notifiers before and after changing the device type. > >> > >> Signed-off-by: Martin Schiller > > > > This is

Re: [PATCH v8] tcp: fix race condition when creating child sockets from syncookies

2020-11-23 Thread Eric Dumazet
On 11/20/20 12:11 PM, Ricardo Dias wrote: > When the TCP stack is in SYN flood mode, the server child socket is > created from the SYN cookie received in a TCP packet with the ACK flag > set. > > The child socket is created when the server receives the first TCP > packet with a valid SYN cookie

Re: netconsole deadlock with virtnet

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 09:31:28 -0500 Steven Rostedt wrote: > On Mon, 23 Nov 2020 13:08:55 +0200 > Leon Romanovsky wrote: > > > > [ 10.028024] Chain exists of: > > [ 10.028025] console_owner --> target_list_lock --> _xmit_ETHER#2 > > Note, the problem is that we have a location that grab

<    1   2   3   4   >