On 11/23/2020 4:55 PM, Eric Dumazet wrote:
On Mon, Nov 23, 2020 at 3:13 PM Tariq Toukan <tar...@nvidia.com> wrote:
Calling netdev_increment_features() on upper/master device from
netdev_add_tso_features() implies unintentional clearance of ALL_FOR_ALL
features supported by all slaves. Fix it by passing ALL_FOR_ALL in
addition to ALL_TSO.
Fixes: b0ce3508b25e ("bonding: allow TSO being set on bonding master")
I think you should give more details to your bug report, because
netdev_add_tso_features() is used from different
places.
Thanks.
Right. I'll include these in the re-spin:
Fixes: 247f6d0f8667 ("team: allow TSO being set on master")
Fixes: f902e8812ef6 ("bridge: Add ability to enable TSO")
I wonder though if netdev_increment_features() is expected to clear
features that are not part of the mask.
Thanks.
