CPT RVU Local Functions(LFs) needs to be attached to the
PF/VF to submit the instructions to CPT.
This patch adds the interface to initialize and attach
the LFs. It also adds interface to register the LF's
interrupts.
Signed-off-by: Suheil Chandran
Signed-off-by: Lukasz Bartosik
Signed-off-by: S
Attach LFs to CPT VF to process the crypto requests and register
LF interrupts.
Signed-off-by: Suheil Chandran
Signed-off-by: Lukasz Bartosik
Signed-off-by: Srujana Challa
---
drivers/crypto/marvell/octeontx2/Makefile | 2 +-
.../marvell/octeontx2/otx2_cpt_common.h | 3 +
.../mar
Hi Peilin,
> `num_reports` is not being properly checked. A malformed event packet with
> a large `num_reports` number makes hci_le_direct_adv_report_evt() read out
> of bounds. Fix it.
>
> Cc: sta...@vger.kernel.org
> Fixes: 2f010b55884e ("Bluetooth: Add support for handling LE Direct
> Adverti
Hi Howard,
> This patch implements the interleaving between allowlist scan and
> no-filter scan. It'll be used to save power when at least one monitor is
> registered and at least one pending connection or one device to be
> scanned for.
>
> The durations of the allowlist scan and the no-filter s
Hi Howard,
> This patch adds code to handle the system suspension during interleave
> scan. The interleave scan will be canceled when the system is going to
> sleep, and will be restarted after waking up.
>
> Commit-changes 5:
> - Remove the change in hci_req_config_le_suspend_scan
this does not
Hi Howard,
> This adds support of variable length parameter in mgmt_config.
I don’t see how this commit message describes the change correctly.
>
> Signed-off-by: Howard Chung
> ---
>
> (no changes since v1)
>
> net/bluetooth/mgmt_config.c | 140 +---
> 1 file
Fixes of two data lifetime bugs found by testing with valgrind: one use
after free, one memory leak.
Michal Kubecek (2):
netlink: fix use after free in netlink_run_handler()
netlink: fix leaked instances of struct nl_socket
netlink/netlink.c | 21 +++--
netlink/nlsock.c | 3
Valgrind detected use after free in netlink_run_handler(): some members of
struct nl_context are accessed after the netlink context is freed by
netlink_done(). Use local variables to store the two flags and check them
instead.
Fixes: 6c19c0d559c8 ("netlink: use genetlink ops information to decide
Valgrind detected memory leaks caused by missing cleanup of netlink
context's ethnl_socket, ethnl2_socket and rtnl_socket. Also, contrary to
its description, nlsock_done() does not free struct nl_socket itself.
Fix nlsock_done() to free the structure and use it to dispose of sockets
pointed to by s
On Mon, Nov 09, 2020 at 12:05:19PM +0100, Tobias Waldekranz wrote:
> On Mon, Nov 09, 2020 at 12:03, Vladimir Oltean wrote:
> > On Mon, Nov 09, 2020 at 09:09:37AM +0100, Tobias Waldekranz wrote:
> >> one. But now you have also increased the background load of an already
> >> choked resource, the MD
Hi Daniel,
> When an LE connection request is made, advertising is disabled and never
> resumed. When a client has an active advertisement, this is disruptive.
> This change adds resume logic for client-configured (non-directed)
> advertisements after the connection attempt.
>
> The patch was tes
On Mon, Nov 09, 2020 at 02:31:11PM +0200, Vladimir Oltean wrote:
> I need to sit on this for a while. How many DSA drivers do we have that
> don't do SA learning in hardware for CPU-injected packets? ocelot/felix
> and mv88e6xxx? Who else? Because if there aren't that many (or any at
> all except f
From: Colin Ian King
The left shift of u16 variable high is promoted to the type int and
then sign extended to a 64 bit u64 value. If the top bit of high is
set then the upper 32 bits of the result end up being set by the
sign extension. Fix this by explicitly casting the value in high to
a u64
This patch makes mdiobus_scan() to try on C45 first as C45 can access
all devices. This allows the function available for the PHY that
supports for both C45 and C22.
Reviewed-by: Voon Weifeng
Reviewed-by: Ong Boon Leong
Signed-off-by: Wong Vee Khee
---
drivers/net/phy/mdio_bus.c | 5 +
inc
On Tue, Nov 03, 2020 at 11:25:38AM +0800, Yunsheng Lin wrote:
> commit 2fb541c862c9 ("net: sch_generic: aviod concurrent reset and enqueue op
> for lockless qdisc")
>
> When the above upstream commit is backported to stable kernel,
> one assignment is missing, which causes two problems reported
>
On Mon Nov 09 2020, Colin King wrote:
> From: Colin Ian King
>
> The left shift of u16 variable high is promoted to the type int and
> then sign extended to a 64 bit u64 value. If the top bit of high is
> set then the upper 32 bits of the result end up being set by the
> sign extension. Fix this
From: Colin Ian King
Currently the assignment of pointer net from the sock_net(sk) call
is potentially dereferencing a null pointer sk. sk points to the
same location as pointer msk and msk is being null checked after
the sock_net call. Fix this by calling sock_net after the null
check on pointe
From: Menglong Dong
'before(*seq, TCP_SKB_CB(skb)->seq) == true' means that one or more
skbs are lost somehow. Once this happen, it seems that it will
never recover automatically. As a result, a warning will be printed
and a '-EAGAIN' will be returned in non-block mode.
As a general suituation,
在 2020/11/08 6:09, Jakub Kicinski 写道:
On Sat, 7 Nov 2020 17:09:25 +0800 Yu Kuai wrote:
if of_find_device_by_node() succeed, fman_port_probe() doesn't have a
corresponding put_device(). Thus add jump target to fix the exception
handling for this function implementation.
Fixes: 0572054617f3 ("fsl
Hello,
syzbot found the following issue on:
HEAD commit:bf3e7628 Merge branch 'mtd/fixes' of git://git.kernel.org/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=16d76e2a50
kernel config: https://syzkaller.appspot.com/x/.config?x=e791ddf0875adf65
das
Hi
>
> On Mon, Nov 9, 2020 at 9:05 AM Zhang Qilong
> wrote:
> >
> > In many case, we need to check return value of pm_runtime_get_sync,
> > but it brings a trouble to the usage counter processing. Many callers
> > forget to decrease the usage counter when it failed. It has been
> > discussed a lo
On Sun 08 Nov 2020 at 01:30, we...@ucloud.cn wrote:
> From: wenxu
>
> Currently kernel tc subsystem can do conntrack in act_ct. But when several
> fragment packets go through the act_ct, function tcf_ct_handle_fragments
> will defrag the packets to a big one. But the last action will redirect
> mi
The reference to device obtained with of_find_device_by_node() should
be dropped. Thus add jump target to fix the exception handling for this
function implementation.
Fixes: 73a7f0a90641("memory: tegra: Add EMC (external memory controller)
driver")
Signed-off-by: Yu Kuai
---
drivers/memory/tegr
On Mon Nov 09 2020, Colin King wrote:
> From: Colin Ian King
>
> The left shift of u16 variable high is promoted to the type int and
> then sign extended to a 64 bit u64 value. If the top bit of high is
> set then the upper 32 bits of the result end up being set by the
> sign extension. Fix this
On Mon, Nov 9, 2020 at 2:24 PM zhangqilong wrote:
>
> Hi
> >
> > On Mon, Nov 9, 2020 at 9:05 AM Zhang Qilong
> > wrote:
> > >
> > > In many case, we need to check return value of pm_runtime_get_sync,
> > > but it brings a trouble to the usage counter processing. Many callers
> > > forget to decre
From: Ido Schimmel
With the ioctl interface, when autoneg is enabled, but without
specifying speed, duplex or link modes, the advertised link modes are
set to the supported link modes by the ethtool user space utility.
This does not happen when using the netlink interface. Fix this
incompatibili
When called with group_style = PARSER_GROUP_MSG, nl_parser() not only
parses the command line and composes the messages but also sends them to
kernel and processes the replies. This is inconsistent with other modes and
also impractical as it takes the control over the process from caller where
it b
Restore special behavior of "ethtool -s autoneg on" if no advertised
modes, speed and duplex are requested: ioctl code enables all link modes
supported by the device. This is most important for network devices which
report no advertised modes when autonegotiation is disabled.
First patch cleans u
On Mon, Nov 09, 2020 at 08:43:47PM +0800, Wong Vee Khee wrote:
> This patch makes mdiobus_scan() to try on C45 first as C45 can access
> all devices. This allows the function available for the PHY that
> supports for both C45 and C22.
>
> Reviewed-by: Voon Weifeng
> Reviewed-by: Ong Boon Leong
>
Hi
Static analysis on linux-next with Coverity has detected a potential
null pointer dereference issue on the following commit:
commit f0d4ba9eff75a79fccb7793f4d9f12303d458603
Author: Kamil Alkhouri
Date: Tue Nov 3 08:10:58 2020 +0100
net: dsa: hellcreek: Add support for hardware timestam
On Mon. 9 Nov 2020 at 19:26, Oliver Hartkopp wrote:
> diff --git a/include/linux/can/dev.h b/include/linux/can/dev.h
> index b2e8df8e4cb0..72671184a7a2 100644
> --- a/include/linux/can/dev.h
> +++ b/include/linux/can/dev.h
> @@ -183,12 +183,12 @@ static inline void can_set_static_ctrlmode(struct
>
On Mon, Nov 9, 2020 at 9:05 AM Zhang Qilong wrote:
>
> In many case, we need to check return value of pm_runtime_get_sync, but
> it brings a trouble to the usage counter processing. Many callers forget
> to decrease the usage counter when it failed. It has been discussed a
> lot[0][1]. So we add a
Hi,
>
> On Mon, Nov 9, 2020 at 2:24 PM zhangqilong
> wrote:
> >
> > Hi
> > >
> > > On Mon, Nov 9, 2020 at 9:05 AM Zhang Qilong
> > >
> > > wrote:
> > > >
> > > > In many case, we need to check return value of
> > > > pm_runtime_get_sync, but it brings a trouble to the usage counter
> > > > proc
Hi Claire,
> Avoid multiple attempts to create the debugfs entry, force_bredr_smp,
> by moving it from the SMP registration to the BR/EDR controller init
> section. hci_debugfs_create_bredr is only called when HCI_SETUP and
> HCI_CONFIG is not set.
>
> Signed-off-by: Claire Chang
> ---
> v2: cor
On Mon Nov 9, 2020 at 3:38 PM CET, Vladimir Oltean wrote:
> On Mon, Nov 09, 2020 at 02:31:11PM +0200, Vladimir Oltean wrote:
> > I need to sit on this for a while. How many DSA drivers do we have that
> > don't do SA learning in hardware for CPU-injected packets? ocelot/felix
> > and mv88e6xxx? Who
Hi Colin,
On Mon Nov 09 2020, Colin Ian King wrote:
> Hi
>
> Static analysis on linux-next with Coverity has detected a potential
> null pointer dereference issue on the following commit:
>
> commit f0d4ba9eff75a79fccb7793f4d9f12303d458603
> Author: Kamil Alkhouri
> Date: Tue Nov 3 08:10:58 202
Fix the following Smatch complaint:
net/mptcp/pm_netlink.c:213 mptcp_pm_add_timer()
warn: variable dereferenced before check 'msk' (see line 208)
net/mptcp/pm_netlink.c
207 struct mptcp_sock *msk = entry->sock;
208 struct sock *sk = (struct sock *)msk;
209
On Sun, Nov 08, 2020 at 12:46:15AM +, Alexander Lobakin wrote:
> After updating userspace Ethtool from 5.7 to 5.9, I noticed that
> NETDEV_FEAT_CHANGE is no more raised when changing netdev features
> through Ethtool.
> That's because the old Ethtool ioctl interface always calls
> netdev_featur
This patch added NULL pointer check for mptcp_pm_alloc_anno_list, and
avoided similar static checker warnings in mptcp_pm_add_timer.
Signed-off-by: Geliang Tang
Reviewed-by: Dan Carpenter
---
net/mptcp/pm_netlink.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/mp
This patchset fixed static checker warnings in mptcp_pm_add_timer and
mptcp_pm_alloc_anno_list.
Geliang Tang (2):
mptcp: fix static checker warnings in mptcp_pm_add_timer
mptcp: cleanup for mptcp_pm_alloc_anno_list
net/mptcp/pm_netlink.c | 9 +
1 file changed, 5 insertions(+), 4 dele
kmemleak report a memory leak as follows:
unreferenced object 0x88810a596800 (size 512):
comm "ip", pid 21558, jiffies 4297568990 (age 112.120s)
hex dump (first 32 bytes):
00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .N..
ff ff ff ff ff ff ff ff 00 83 60 b0 ff ff ff
On Mon, Nov 9, 2020 at 2:46 PM zhangqilong wrote:
>
> Hi,
>
> >
> > On Mon, Nov 9, 2020 at 2:24 PM zhangqilong
> > wrote:
> > >
> > > Hi
> > > >
> > > > On Mon, Nov 9, 2020 at 9:05 AM Zhang Qilong
> > > >
> > > > wrote:
> > > > >
> > > > > In many case, we need to check return value of
> > > > >
On 09/11/2020 13:59, Kurt Kanzenbach wrote:
> Hi Colin,
>
> On Mon Nov 09 2020, Colin Ian King wrote:
>> Hi
>>
>> Static analysis on linux-next with Coverity has detected a potential
>> null pointer dereference issue on the following commit:
>>
>> commit f0d4ba9eff75a79fccb7793f4d9f12303d458603
>>
> On Mon, Nov 9, 2020 at 2:46 PM zhangqilong
> wrote:
> >
> > Hi,
> >
> > >
> > > On Mon, Nov 9, 2020 at 2:24 PM zhangqilong
> > > wrote:
> > > >
> > > > Hi
> > > > >
> > > > > On Mon, Nov 9, 2020 at 9:05 AM Zhang Qilong
> > > > >
> > > > > wrote:
> > > > > >
> > > > > > In many case, we need to
> -Original Message-
> From: Peter Zijlstra
> Sent: 09 November 2020 11:29
> To: Alexei Starovoitov
> Cc: Kevin Sheldrake ; Ingo Molnar
> ; Daniel Borkmann ; Network
> Development ; b...@vger.kernel.org; Andrii
> Nakryiko ; KP Singh
> Subject: [EXTERNAL] Re: [PATCH bpf-next v2] Update
On Thu, Nov 05, 2020 at 02:02:24PM +, Matthew Wilcox wrote:
> On Thu, Nov 05, 2020 at 02:21:25PM +0100, Eric Dumazet wrote:
> > On 11/5/20 5:21 AM, Matthew Wilcox (Oracle) wrote:
> > > When the machine is under extreme memory pressure, the page_frag allocator
> > > signals this to the networkin
On 11/9/20 3:32 PM, Matthew Wilcox wrote:
> On Thu, Nov 05, 2020 at 02:02:24PM +, Matthew Wilcox wrote:
>> On Thu, Nov 05, 2020 at 02:21:25PM +0100, Eric Dumazet wrote:
>>> On 11/5/20 5:21 AM, Matthew Wilcox (Oracle) wrote:
When the machine is under extreme memory pressure, the page_fra
On Sat, Nov 7, 2020 at 8:11 PM Alexander Lobakin wrote:
>
> While testing UDP GSO fraglists forwarding through driver that uses
> Fast GRO (via napi_gro_frags()), I was observing lots of out-of-order
> iperf packets:
>
> [ ID] Interval Transfer Bitrate Jitter
> [SUM] 0.0-40.
When mv88e6xxx_fid_map return error, we lost free the table.
Fix it.
Fixes: bfb255428966 ("net: dsa: mv88e6xxx: Add devlink regions")
Reported-by: Hulk Robot
Signed-off-by: zhangxiaoxu
---
drivers/net/dsa/mv88e6xxx/devlink.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
On Mon, Nov 09, 2020 at 09:44:16AM -0500, zhangxiaoxu wrote:
> When mv88e6xxx_fid_map return error, we lost free the table.
>
> Fix it.
>
> Fixes: bfb255428966 ("net: dsa: mv88e6xxx: Add devlink regions")
> Reported-by: Hulk Robot
> Signed-off-by: zhangxiaoxu
Reviewed-by: Andrew Lunn
And
On Mon, Nov 9, 2020 at 9:36 PM Eric Dumazet wrote:
>
> I do not think this patch is useful. That is simply code churn.
>
> Can you trigger the WARN() in the latest upstream version ?
> If yes this is a serious bug that needs urgent attention.
>
> Make sure you have backported all needed fixes into
On Mon, Nov 09, 2020 at 03:24:37PM +0200, Vlad Buslov wrote:
> On Sun 08 Nov 2020 at 01:30, we...@ucloud.cn wrote:
...
> > @@ -974,9 +974,22 @@ config NET_ACT_TUNNEL_KEY
> > To compile this code as a module, choose M here: the
> > module will be called act_tunnel_key.
> >
> > +config
On Mon. 9 Nov 2020 at 19:26, Oliver Hartkopp wrote:
>
> The extension of struct can_frame with the len8_dlc element and the
> can_dlc naming issue required an update of the documentation.
>
> Additionally introduce the term 'Classical CAN' which has been established
> by CAN in Automation to separa
在 2020/11/9 21:24, Vlad Buslov 写道:
> On Sun 08 Nov 2020 at 01:30, we...@ucloud.cn wrote:
>> From: wenxu
>>
>> Currently kernel tc subsystem can do conntrack in act_ct. But when several
>> fragment packets go through the act_ct, function tcf_ct_handle_fragments
>> will defrag the packets to a big
pm_runtime_get_sync() will increment pm usage at first and it will
resume the device later. If runtime of the device has error or
device is in inaccessible state(or other error state), resume
operation will fail. If we do not call put operation to decrease
the reference, it will result in reference
In many case, we need to check return value of pm_runtime_get_sync, but
it brings a trouble to the usage counter processing. Many callers forget
to decrease the usage counter when it failed. It has been discussed a
lot[0][1]. So we add a function to deal with the usage counter for better
coding.
[
In many case, we need to check return value of pm_runtime_get_sync,
but it brings a trouble to the usage counter processing. Many callers
forget to decrease the usage counter when it failed. It has been
discussed a lot[0][1]. So we add a function to deal with the usage
counter for better coding and
On Mon, Nov 9, 2020 at 4:05 AM Oliver Herms
wrote:
>
>
> On 04.11.20 20:52, Willem de Bruijn wrote:
> Fixes: c54419321455 ("GRE: Refactor GRE tunneling code.")
> >>>
> >>> How did you arrive at this SHA1?
> >> I think the legacy usage of hard_header_len in ipv6/sit.c was overseen in
> >> c54
From: Guvenc Gulce
Use active link of the connection directly and not
via linkgroup array structure when obtaining link
data of the connection.
Signed-off-by: Guvenc Gulce
Signed-off-by: Karsten Graul
---
net/smc/smc_diag.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
dif
From: Guvenc Gulce
Add link counters to the structure of the smc ib device, one counter per
ib port. Increase/decrease the counters as needed in the corresponding
routines.
Signed-off-by: Guvenc Gulce
Signed-off-by: Karsten Graul
---
net/smc/smc_core.c | 13 +
net/smc/smc_ib.h |
From: Guvenc Gulce
Refactor the netlink reply processing routine so that
it provides sub functions for specific parts of the processing.
Signed-off-by: Guvenc Gulce
Signed-off-by: Karsten Graul
---
net/smc/smc_diag.c | 218 +++--
1 file changed, 133 ins
The helper smc_connect_abort() can be used by the listen processing
functions, too. And rename this helper to smc_conn_abort() to make the
purpose clearer.
No functional change.
Signed-off-by: Karsten Graul
---
net/smc/af_smc.c | 17 +
1 file changed, 5 insertions(+), 12 deletion
From: Guvenc Gulce
Introduce get link command which loops through
all available links of all available link groups. It
uses the SMC-R linkgroup list as entry point, not
the socket list, which makes linkgroup diagnosis
possible, in case linkgroup does not contain active
connections anymore.
Signe
From: Guvenc Gulce
Deliver SMCD Linkgroup information via netlink based
diagnostic interface.
Signed-off-by: Guvenc Gulce
Signed-off-by: Karsten Graul
---
include/uapi/linux/smc_diag.h | 7 +++
net/smc/smc_core.c| 7 +++
net/smc/smc_core.h| 2 +
net/smc/smc_diag.
From: Guvenc Gulce
Introduce get linkgroup command which loops through
all available SMCR linkgroups. It uses the SMC-R linkgroup
list as entry point, not the socket list, which makes
linkgroup diagnosis possible, in case linkgroup does not
contain active connections anymore.
Signed-off-by: Guve
>
-
Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de la
Longeraie 7, 1110, Morges, Switzerland
-
-Original Message-
> From: Florian Fainelli
> Sent: Wednesday, November 04, 2020 5:02 PM
> To: Badel
Please apply the following patch series for smc to netdev's net-next tree.
This patch series refactors the current netlink API in smc_diag module
which is used for diagnostic purposes and extends the netlink API in a
backward compatible way so that the extended API can provide information
about SM
From: Guvenc Gulce
Encapsulate the smc ism v2 capability boolean value
in a function for better information hiding.
Signed-off-by: Guvenc Gulce
Signed-off-by: Karsten Graul
---
net/smc/af_smc.c | 12 ++--
net/smc/smc_ism.c | 8 +++-
net/smc/smc_ism.h | 5 ++---
3 files changed,
From: Guvenc Gulce
Deliver SMCR device information via netlink based
diagnostic interface.
Signed-off-by: Guvenc Gulce
Signed-off-by: Karsten Graul
---
include/uapi/linux/smc_diag.h | 6 ++
net/smc/smc_core.c| 7 ++
net/smc/smc_core.h| 2 +
net/smc/smc_diag.c
From: Guvenc Gulce
Add new netlink command to obtain system information
of the smc module.
Signed-off-by: Guvenc Gulce
Signed-off-by: Karsten Graul
---
include/uapi/linux/smc.h | 1 +
include/uapi/linux/smc_diag.h | 17 ++
net/smc/smc_clc.c | 5 +++
net/smc/smc_clc.
From: Guvenc Gulce
During link creation add network and ib-device name to
link structure. This is needed for diagnostic purposes.
When diagnostic information is gathered, we need to traverse
device, linkgroup and link structures, to be able to do that
we need to hold a spinlock for the linkgroup
From: Guvenc Gulce
smc_diag module should be able to work with legacy and
extended netlink api. This is done by using the sequence field
of the netlink message header. Sequence field is optional and was
filled with a constant value MAGIC_SEQ in the current
implementation.
New constant values MAGI
From: Guvenc Gulce
During smc ib-device creation, add network device name to smc
ib-device structure. Register for netdevice name changes and
update ib-device accordingly. This is needed for diagnostic purposes.
Signed-off-by: Guvenc Gulce
Signed-off-by: Karsten Graul
---
net/smc/smc_ib.c |
From: Guvenc Gulce
Deliver SMCD device information via netlink based
diagnostic interface.
Signed-off-by: Guvenc Gulce
Signed-off-by: Karsten Graul
---
include/uapi/linux/smc.h | 2 +
include/uapi/linux/smc_diag.h | 20
net/smc/smc_core.h| 8 +++
net/smc/smc_diag.c
From: Guvenc Gulce
Add connection counters to the structure of the link.
Increase/decrease the counters as needed in the corresponding
routines.
Signed-off-by: Guvenc Gulce
Signed-off-by: Karsten Graul
---
net/smc/smc_core.c | 16 ++--
net/smc/smc_core.h | 1 +
2 files changed, 1
On Mon, Nov 9, 2020 at 4:00 PM Zhang Qilong wrote:
>
> In many case, we need to check return value of pm_runtime_get_sync, but
> it brings a trouble to the usage counter processing. Many callers forget
> to decrease the usage counter when it failed. It has been discussed a
> lot[0][1]. So we add a
On Fri, Nov 06, 2020 at 11:12:21AM -0800, Jakub Kicinski wrote:
> On Wed, 4 Nov 2020 15:30:27 +0200 Ido Schimmel wrote:
> > *flags |= (nhc->nhc_flags & RTNH_F_ONLINK);
> > if (nhc->nhc_flags & RTNH_F_OFFLOAD)
> > *flags |= RTNH_F_OFFLOAD;
> > + if (nhc->nhc_flags & RTNH_F_TRA
can_get_len8_dlc: get value to fill len8_dlc at frame reception time
can_get_cc_dlc: get DLC value to be written into CAN controller
Signed-off-by: Oliver Hartkopp
---
include/linux/can/dev.h | 19 +++
1 file changed, 19 insertions(+)
diff --git a/include/linux/can/dev.h b/inclu
The helper functions can_len2dlc and can_dlc2len are only relevant for
CAN FD data length code (DLC) conversion.
To fit the introduced can_cc_dlc2len for Classical CAN we rename:
can_dlc2len -> can_fd_dlc2len to get the payload length from the DLC
can_len2dlc -> can_fd_len2dlc to get the DLC from
The macro was always used together with can_dlc2len() which sanitizes the
given dlc value on its own.
Signed-off-by: Oliver Hartkopp
---
drivers/net/can/flexcan.c | 2 +-
drivers/net/can/peak_canfd/peak_canfd.c | 2 +-
drivers/net/can/spi/mcp251xfd/mcp251xfd-cor
The extension of struct can_frame with the len8_dlc element and the
can_dlc naming issue required an update of the documentation.
Additionally introduce the term 'Classical CAN' which has been established
by CAN in Automation to separate the original CAN2.0 A/B from CAN FD.
Updated some data stru
Support the Classical CAN raw DLC functionality to send and receive DLC
values from 9 .. 15 on various Classical CAN capable USB network drivers:
- gs_usb
- pcan_usb
- pcan_usb_fd
- usb_8dev
Tested-by: Oliver Hartkopp
Signed-off-by: Oliver Hartkopp
---
drivers/net/can/usb/gs_usb.c
The get_can_dlc() macro is used to ensure the payload length information of
the Classical CAN frame to be max 8 bytes (the CAN_MAX_DLEN).
Rename the macro and use the correct constant in preparation of the len/dlc
cleanup for Classical CAN frames.
Signed-off-by: Oliver Hartkopp
---
drivers/net/
ISO 11898-1 Chapter 8.4.2.3 defines a 4 bit data length code (DLC) table which
maps the DLC to the payload length of the CAN frame in bytes:
DLC -> payload length
0 .. 8 -> 0 .. 8
9 .. 15 -> 8
Although the DLC values 8 .. 15 in Classical CAN always result in a payload
lengt
Introduce improved DLC handling for Classic CAN with introduces a new
element 'len8_dlc' to the struct can_frame and additionally rename
the 'can_dlc' element to 'len' as it represents a plain payload length.
Before implementing the CAN_CTRLMODE_CC_LEN8_DLC handling on driver level
this patch set
The naming of can_dlc as element of struct can_frame and also as variable
name is misleading as it claims to be a 'data length CODE' but in reality
it always was a plain data length.
With the indroduction of a new 'len' element in struct can_frame we can now
remove can_dlc as name and make clear w
Hi Vincent,
On 09.11.20 13:59, Vincent MAILHOL wrote:
On Mon. 9 Nov 2020 at 19:26, Oliver Hartkopp wrote:
diff --git a/include/linux/can/dev.h b/include/linux/can/dev.h
index b2e8df8e4cb0..72671184a7a2 100644
--- a/include/linux/can/dev.h
+++ b/include/linux/can/dev.h
@@ -183,12 +183,12 @@ stat
On 11/9/20 3:48 PM, Menglong Dong wrote:
> On Mon, Nov 9, 2020 at 9:36 PM Eric Dumazet wrote:
>>
>> I do not think this patch is useful. That is simply code churn.
>>
>> Can you trigger the WARN() in the latest upstream version ?
>> If yes this is a serious bug that needs urgent attention.
>>
>
On Fri, Nov 06, 2020 at 11:31:59AM -0800, Jakub Kicinski wrote:
> On Wed, 4 Nov 2020 15:30:22 +0200 Ido Schimmel wrote:
> > From: Ido Schimmel
> >
> > This patch set adds support for nexthop objects offload with a dummy
> > implementation over netdevsim. mlxsw support will be added later.
> >
>
Hi Nick,
I love your patch! Perhaps something to improve:
[auto build test WARNING on nf-next/master]
[also build test WARNING on nf/master ipvs/master v5.10-rc3 next-20201109]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use
From: Ioana Ciornei
The referenced commit added in .config_intr() the part of code which upon
configuration of the IRQ state it also clears up any pending IRQ. If
there were actually pending IRQs, a read on the IRQ status register will
return something non zero. This should not result in the call
On Mon 09 Nov 2020 at 16:50, Marcelo Ricardo Leitner
wrote:
> On Mon, Nov 09, 2020 at 03:24:37PM +0200, Vlad Buslov wrote:
>> On Sun 08 Nov 2020 at 01:30, we...@ucloud.cn wrote:
> ...
>> > @@ -974,9 +974,22 @@ config NET_ACT_TUNNEL_KEY
>> > To compile this code as a module, choose M here:
> operation to deal with usage counter
>
> On Mon, Nov 9, 2020 at 4:00 PM Zhang Qilong
> wrote:
> >
> > In many case, we need to check return value of pm_runtime_get_sync,
> > but it brings a trouble to the usage counter processing. Many callers
> > forget to decrease the usage counter when it fa
On Mon, 9 Nov 2020 at 16:20, Rafael J. Wysocki wrote:
>
> On Mon, Nov 9, 2020 at 4:00 PM Zhang Qilong wrote:
> >
> > In many case, we need to check return value of pm_runtime_get_sync, but
> > it brings a trouble to the usage counter processing. Many callers forget
> > to decrease the usage count
On Mon 09 Nov 2020 at 16:54, wenxu wrote:
> 在 2020/11/9 21:24, Vlad Buslov 写道:
>> On Sun 08 Nov 2020 at 01:30, we...@ucloud.cn wrote:
>>> From: wenxu
>>>
>>> Currently kernel tc subsystem can do conntrack in act_ct. But when several
>>> fragment packets go through the act_ct, function tcf_ct_ha
On 09.11.20 15:50, Vincent MAILHOL wrote:
On Mon. 9 Nov 2020 at 19:26, Oliver Hartkopp wrote:
The extension of struct can_frame with the len8_dlc element and the
can_dlc naming issue required an update of the documentation.
Additionally introduce the term 'Classical CAN' which has been esta
On Mon, Nov 9, 2020 at 4:50 PM Ulf Hansson wrote:
>
> On Mon, 9 Nov 2020 at 16:20, Rafael J. Wysocki wrote:
> >
> > On Mon, Nov 9, 2020 at 4:00 PM Zhang Qilong wrote:
> > >
> > > In many case, we need to check return value of pm_runtime_get_sync, but
> > > it brings a trouble to the usage counte
On Mon, Nov 9, 2020 at 4:50 PM zhangqilong wrote:
>
> > operation to deal with usage counter
> >
> > On Mon, Nov 9, 2020 at 4:00 PM Zhang Qilong
> > wrote:
> > >
> > > In many case, we need to check return value of pm_runtime_get_sync,
> > > but it brings a trouble to the usage counter processing
Daire Byrne reports a ~50% aggregrate throughput regression on his
Linux NFS server after commit da1661b93bf4 ("SUNRPC: Teach server to
use xprt_sock_sendmsg for socket sends"), which replaced
kernel_send_page() calls in NFSD's socket send path with calls to
sock_sendmsg() using iov_iter.
Investig
On Mon, 9 Nov 2020 at 16:54, Rafael J. Wysocki wrote:
>
> On Mon, Nov 9, 2020 at 4:50 PM Ulf Hansson wrote:
> >
> > On Mon, 9 Nov 2020 at 16:20, Rafael J. Wysocki wrote:
> > >
> > > On Mon, Nov 9, 2020 at 4:00 PM Zhang Qilong
> > > wrote:
> > > >
> > > > In many case, we need to check return v
1 - 100 of 437 matches
Mail list logo
