On Fri, Nov 06, 2020 at 11:12:21AM -0800, Jakub Kicinski wrote: > On Wed, 4 Nov 2020 15:30:27 +0200 Ido Schimmel wrote: > > *flags |= (nhc->nhc_flags & RTNH_F_ONLINK); > > if (nhc->nhc_flags & RTNH_F_OFFLOAD) > > *flags |= RTNH_F_OFFLOAD; > > + if (nhc->nhc_flags & RTNH_F_TRAP) > > + *flags |= RTNH_F_TRAP; > > Out of curiosity - why use this if construct like OFFLOAD rather than > the more concise mask like ONLINK does?
Good question :) > In fact looks like the mask could just be extended there instead? Yes, good suggestion. Will do that.
