On Fri, Nov 06, 2020 at 11:31:59AM -0800, Jakub Kicinski wrote: > On Wed, 4 Nov 2020 15:30:22 +0200 Ido Schimmel wrote: > > From: Ido Schimmel <ido...@nvidia.com> > > > > This patch set adds support for nexthop objects offload with a dummy > > implementation over netdevsim. mlxsw support will be added later. > > > > The general idea is very similar to route offload in that notifications > > are sent whenever nexthop objects are changed. A listener can veto the > > change and the error will be communicated to user space with extack. > > > > To keep listeners as simple as possible, they not only receive > > notifications for the nexthop object that is changed, but also for all > > the other objects affected by this change. For example, when a single > > nexthop is replaced, a replace notification is sent for the single > > nexthop, but also for all the nexthop groups this nexthop is member in. > > This relieves listeners from the need to track such dependencies. > > > > To simplify things further for listeners, the notification info does not > > contain the raw nexthop data structures (e.g., 'struct nexthop'), but > > less complex data structures into which the raw data structures are > > parsed into. > > Applied, thank you!
Great, thank you. And thanks David for the awesome work on the nexthop infrastructure. > > BTW no need to follow up on my else-after-return comment, > just something to keep in mind. Ack
