This patch added NULL pointer check for mptcp_pm_alloc_anno_list, and
avoided similar static checker warnings in mptcp_pm_add_timer.

Signed-off-by: Geliang Tang <geliangt...@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpen...@oracle.com>
---
 net/mptcp/pm_netlink.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 03f2c28f11f5..dfc1bed4a55f 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -266,7 +266,9 @@ static bool mptcp_pm_alloc_anno_list(struct mptcp_sock *msk,
 {
        struct mptcp_pm_add_entry *add_entry = NULL;
        struct sock *sk = (struct sock *)msk;
-       struct net *net = sock_net(sk);
+
+       if (!msk)
+               return false;
 
        if (lookup_anno_list_by_saddr(msk, &entry->addr))
                return false;
@@ -283,7 +285,7 @@ static bool mptcp_pm_alloc_anno_list(struct mptcp_sock *msk,
 
        timer_setup(&add_entry->add_timer, mptcp_pm_add_timer, 0);
        sk_reset_timer(sk, &add_entry->add_timer,
-                      jiffies + mptcp_get_add_addr_timeout(net));
+                      jiffies + mptcp_get_add_addr_timeout(sock_net(sk)));
 
        return true;
 }
-- 
2.26.2

Reply via email to