Zdravstvujte! Vas interesuyut klientskie bazy dannyh?

2019-07-31 Thread netdev
Zdravstvujte! Vas interesuyut klientskie bazy dannyh?

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-07-31 Thread Song Liu
Hi Andy, > On Jul 30, 2019, at 1:20 PM, Andy Lutomirski wrote: > > On Sat, Jul 27, 2019 at 11:20 AM Song Liu wrote: >> >> Hi Andy, >> >> > > Well, yes. sys_bpf() is pretty powerful. > > The goal of /dev/bpf is to enable special users to call sys_bpf(). In > the mean

Re: [PATCH net-next v4 6/6] net: mscc: PTP Hardware Clock (PHC) support

2019-07-31 Thread antoine.ten...@bootlin.com
Hello Saeed, On Fri, Jul 26, 2019 at 08:52:10PM +, Saeed Mahameed wrote: > On Thu, 2019-07-25 at 16:27 +0200, Antoine Tenart wrote: > > > > dev->stats.tx_packets++; > > dev->stats.tx_bytes += skb->len; > > - dev_kfree_skb_any(skb); > > + > > + if (ocelot->ptp && shinfo->tx_flags

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-07-31 Thread Song Liu
> On Jul 30, 2019, at 1:24 PM, Andy Lutomirski wrote: > > On Mon, Jul 29, 2019 at 10:07 PM Song Liu wrote: >> >> Hi Andy, >> >>> On Jul 27, 2019, at 11:20 AM, Song Liu wrote: >>> >>> Hi Andy, >>> >>> [...] >>> >> >> I would like more comments on this. >> >> Currently, bpf permissio

[PATCH net-next 0/6] flow_offload: add indr-block in nf_table_offload

2019-07-31 Thread wenxu
From: wenxu This series patch make nftables offload support the vlan and tunnel device offload through indr-block architecture. The first four patches mv tc indr block to flow offload and rename to flow-indr-block. Because the new flow-indr-block can't get the tcf_block directly. The fifthe patc

[PATCH net-next 4/6] flow_offload: move tc indirect block to flow offload

2019-07-31 Thread wenxu
From: wenxu move tc indirect block to flow_offload and rename it to flow indirect block.The nf_tables can use the indr block architecture. Signed-off-by: wenxu --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 10 +- .../net/ethernet/netronome/nfp/flower/offload.c| 11 +- include/

[PATCH net-next 2/6] cls_api: replace block with flow_block in tc_indr_block_dev

2019-07-31 Thread wenxu
From: wenxu This patch make tc_indr_block_dev can separate from tc subsystem Signed-off-by: wenxu --- net/sched/cls_api.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 2e3b58d..f9643fa 100644

[PATCH net-next 1/6] cls_api: modify the tc_indr_block_ing_cmd parameters.

2019-07-31 Thread wenxu
From: wenxu This patch make tc_indr_block_ing_cmd can't access struct tc_indr_block_dev and tc_indr_block_cb. Signed-off-by: wenxu --- net/sched/cls_api.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c

[PATCH net-next 6/6] netfilter: nf_tables_offload: support indr block call

2019-07-31 Thread wenxu
From: wenxu nftable support indr-block call. It makes nftable an offload vlan and tunnel device. nft add table netdev firewall nft add chain netdev firewall aclout { type filter hook ingress offload device mlx_pf0vf0 priority - 300 \; } nft add rule netdev firewall aclout ip daddr 10.0.0.1 fwd

[PATCH net-next 5/6] flow_offload: support get flow_block immediately

2019-07-31 Thread wenxu
From: wenxu The new flow-indr-block can't get the tcf_block directly. It provide a callback list to find the flow_block immediately when the device register and contain a ingress block. Signed-off-by: wenxu --- include/net/flow_offload.h | 17 + net/core/flow_offload.c| 33

[PATCH net-next 3/6] cls_api: add flow_indr_block_call function

2019-07-31 Thread wenxu
From: wenxu This patch make indr_block_call don't access struct tc_indr_block_cb and tc_indr_block_dev directly Signed-off-by: wenxu --- net/sched/cls_api.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/net/sched/cls_api.c b/net/sched/c

[PATCH] net/ethernet/qlogic/qed: force the string buffer NULL-terminated

2019-07-31 Thread Wang Xiayang
strncpy() does not ensure NULL-termination when the input string size equals to the destination buffer size 30. The output string is passed to qed_int_deassertion_aeu_bit() which calls DP_INFO() and relies NULL-termination. Use strlcpy instead. The other conditional branch above strncpy() needs no

Re: [PATCH v2 bpf-next 02/12] libbpf: implement BPF CO-RE offset relocation algorithm

2019-07-31 Thread Song Liu
> On Jul 30, 2019, at 11:52 PM, Andrii Nakryiko > wrote: > > On Tue, Jul 30, 2019 at 10:19 PM Song Liu wrote: >> >> >> >>> On Jul 30, 2019, at 6:00 PM, Andrii Nakryiko >>> wrote: >>> >>> On Tue, Jul 30, 2019 at 5:39 PM Song Liu wrote: > On Jul 30, 2019, at 12:53

Re: [PATCH 0/2] tools: bpftool: add net (un)load command to load XDP

2019-07-31 Thread Jesper Dangaard Brouer
On Tue, 30 Jul 2019 18:52:40 -0700 Alexei Starovoitov wrote: > On Tue, Jul 30, 2019 at 06:21:44PM -0700, Jakub Kicinski wrote: > > > > Duplicating the same features in bpftool will only diminish the > > > > incentive for moving iproute2 to libbpf. > > > > > > not at all. why do you think so

Re: [PATCH 1/2] tools: bpftool: add net load command to load XDP on interface

2019-07-31 Thread Jesper Dangaard Brouer
On Wed, 31 Jul 2019 03:48:20 +0900 "Daniel T. Lee" wrote: > diff --git a/tools/bpf/bpftool/net.c b/tools/bpf/bpftool/net.c > index 67e99c56bc88..d3a4f18b5b95 100644 > --- a/tools/bpf/bpftool/net.c > +++ b/tools/bpf/bpftool/net.c > @@ -55,6 +55,35 @@ struct bpf_attach_info { > __u32 flow_dis

Re: [PATCH 1/2] tools: bpftool: add net load command to load XDP on interface

2019-07-31 Thread Jesper Dangaard Brouer
On Wed, 31 Jul 2019 03:48:20 +0900 "Daniel T. Lee" wrote: > By this commit, using `bpftool net load`, user can load XDP prog on > interface. New type of enum 'net_load_type' has been made, as stated at > cover-letter, the meaning of 'load' is, prog will be loaded on interface. Why the keyword "l

[PATCH net-next 1/2] selftests: mlxsw: Fix local variable declarations in DSCP tests

2019-07-31 Thread Petr Machata
These two tests have some problems in the global scope pollution and on contrary, contain unnecessary local declarations. Fix them. Signed-off-by: Petr Machata --- .../testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh | 6 -- .../testing/selftests/drivers/net/mlxsw/qos_dscp_router.sh

[PATCH net-next 0/2] mlxsw: Test coverage for DSCP leftover fix

2019-07-31 Thread Petr Machata
This patch set fixes some global scope pollution issues in the DSCP tests (in patch #1), and then proceeds (in patch #2) to add a new test for checking whether, after DSCP prioritization rules are removed from a port, DSCP rewrites consistently to zero, instead of the last removed rule still stayin

[PATCH net-next 2/2] selftests: mlxsw: Add a test for leftover DSCP rule

2019-07-31 Thread Petr Machata
Commit dedfde2fe1c4 ("mlxsw: spectrum_dcb: Configure DSCP map as the last rule is removed") fixed a problem in mlxsw where last DSCP rule to be removed remained in effect when DSCP rewrite was applied. Add a selftest that covers this problem. Signed-off-by: Petr Machata --- .../drivers/net/mlxs

Re: [PATCH net-next] be2net: disable bh with spin_lock in be_process_mcc

2019-07-31 Thread Denis Kirjanov
On 7/30/19, Willem de Bruijn wrote: > On Tue, Jul 30, 2019 at 7:33 AM Denis Kirjanov > wrote: >> >> Signed-off-by: Denis Kirjanov > > This is a partial revert of the previous change to these lines in 2012 > in commit 072a9c486004 ("netpoll: revert 6bdb7fe3104 and fix be_poll() > instead"). > > T

Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)

2019-07-31 Thread Mark Brown
On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: Today's -next fails to build an ARM allmodconfig due to: > allmodconfig (arm, gcc-8) — FAIL, 1 error, 40 warnings, 0 section mismatches > > Errors: > drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > func

Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)

2019-07-31 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote: > On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: > > Today's -next fails to build an ARM allmodconfig due to: > > > allmodconfig (arm, gcc-8) — FAIL, 1 error, 40 warnings, 0 section mismatches > > > > Errors: > >

Re: [PATCH net] drop_monitor: Add missing uAPI file to MAINTAINERS file

2019-07-31 Thread Neil Horman
On Wed, Jul 31, 2019 at 09:38:19AM +0300, Ido Schimmel wrote: > From: Ido Schimmel > > Fixes: 6e43650cee64 ("add maintainer for network drop monitor kernel service") > Signed-off-by: Ido Schimmel > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAI

[PATCH 0/8] netfilter fixes for net

2019-07-31 Thread Pablo Neira Ayuso
Hi, The following patchset contains Netfilter fixes for your net tree: 1) memleak in ebtables from the error path for the 32/64 compat layer, from Florian Westphal. 2) Fix inverted meta ifname/ifidx matching when no interface is set on either from the input/output path, from Phil Sutter.

[PATCH 1/8] netfilter: ebtables: fix a memory leak bug in compat

2019-07-31 Thread Pablo Neira Ayuso
From: Wenwen Wang In compat_do_replace(), a temporary buffer is allocated through vmalloc() to hold entries copied from the user space. The buffer address is firstly saved to 'newinfo->entries', and later on assigned to 'entries_tmp'. Then the entries in this temporary buffer is copied to the int

[PATCH 3/8] netfilter: nft_meta_bridge: Eliminate 'out' label

2019-07-31 Thread Pablo Neira Ayuso
From: Phil Sutter The label is used just once and the code it points at is not reused, no point in keeping it. Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- net/bridge/netfilter/nft_meta_bridge.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/brid

[PATCH 7/8] netfilter: ipset: Fix rename concurrency with listing

2019-07-31 Thread Pablo Neira Ayuso
From: Jozsef Kadlecsik Shijie Luo reported that when stress-testing ipset with multiple concurrent create, rename, flush, list, destroy commands, it can result ipset : Broken LIST kernel message: missing DATA part! error messages and broken list results. The problem was the rename operation was

[PATCH 2/8] netfilter: nf_tables: Make nft_meta expression more robust

2019-07-31 Thread Pablo Neira Ayuso
From: Phil Sutter nft_meta_get_eval()'s tendency to bail out setting NFT_BREAK verdict in situations where required data is missing leads to unexpected behaviour with inverted checks like so: | meta iifname != eth0 accept This rule will never match if there is no input interface (or it is not k

[PATCH 8/8] netfilter: ebtables: also count base chain policies

2019-07-31 Thread Pablo Neira Ayuso
From: Florian Westphal ebtables doesn't include the base chain policies in the rule count, so we need to add them manually when we call into the x_tables core to allocate space for the comapt offset table. This lead syzbot to trigger: WARNING: CPU: 1 PID: 9012 at net/netfilter/x_tables.c:649 xt_

[PATCH 5/8] netfilter: ipset: Actually allow destination MAC address for hash:ip,mac sets too

2019-07-31 Thread Pablo Neira Ayuso
From: Stefano Brivio In commit 8cc4ccf58379 ("ipset: Allow matching on destination MAC address for mac and ipmac sets"), ipset.git commit 1543514c46a7, I removed the KADT check that prevents matching on destination MAC addresses for hash:mac sets, but forgot to remove the same check for hash:ip,m

[PATCH 4/8] netfilter: add include guard to xt_connlabel.h

2019-07-31 Thread Pablo Neira Ayuso
From: Masahiro Yamada Add a header include guard just in case. Signed-off-by: Masahiro Yamada Acked-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/uapi/linux/netfilter/xt_connlabel.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/uapi/linux/netfilter/xt_

[PATCH 6/8] netfilter: ipset: Copy the right MAC address in bitmap:ip,mac and hash:ip,mac sets

2019-07-31 Thread Pablo Neira Ayuso
From: Stefano Brivio In commit 8cc4ccf58379 ("ipset: Allow matching on destination MAC address for mac and ipmac sets"), ipset.git commit 1543514c46a7, I added to the KADT functions for sets matching on MAC addreses the copy of source or destination MAC address depending on the configured match.

[PATCH nf,v2] netfilter: nf_tables: map basechain priority to hardware priority

2019-07-31 Thread Pablo Neira Ayuso
This patch adds initial support for offloading basechains using the priority range from -8192 to 8191. The software priority -8192 is mapped to the hardware priority 0xC000 + 1. tcf_auto_prio() uses 0xC000 if the user specifies no priority, then it subtracts 1 for each new tcf_proto object. This p

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

2019-07-31 Thread Neil Horman
On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote: > On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wrote: > > On Tue, Jul 30, 2019 at 10:04:37PM -0700, Joe Perches wrote: > > > fallthrough may become a pseudo reserved keyword so this only use of > > > fallthrough is better renamed to all

Re: [Intel-wired-lan] [PATCH bpf-next v4 03/11] libbpf: add flags to umem config

2019-07-31 Thread Björn Töpel
On Tue, 30 Jul 2019 at 19:43, Kevin Laatz wrote: > > This patch adds a 'flags' field to the umem_config and umem_reg structs. > This will allow for more options to be added for configuring umems. > > The first use for the flags field is to add a flag for unaligned chunks > mode. These flags can ei

[PATCH] net: mediatek: Drop unneeded dependency on NET_VENDOR_MEDIATEK

2019-07-31 Thread Geert Uytterhoeven
The whole block is protected by "if NET_VENDOR_MEDIATEK", so there is no need for individual driver config symbols to duplicate this dependency. Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/mediatek/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/med

[PATCH v2] isdn: hfcsusb: Fix mISDN driver crash caused by transfer buffer on the stack

2019-07-31 Thread Juliana Rodrigueiro
Since linux 4.9 it is not possible to use buffers on the stack for DMA transfers. During usb probe the driver crashes with "transfer buffer is on stack" message. This fix k-allocates a buffer to be used on "read_reg_atomic", which is a macro that calls "usb_control_msg" under the hood. Kernel 4

Re: [PATCH bpf-next 1/9] selftests/bpf: prevent headers to be compiled as C code

2019-07-31 Thread Ilya Leoshkevich
> Am 27.07.2019 um 20:53 schrieb Andrii Nakryiko : > > On Fri, Jul 26, 2019 at 3:01 PM Stanislav Fomichev wrote: >> >> On 07/26, Andrii Nakryiko wrote: >>> On Fri, Jul 26, 2019 at 2:21 PM Stanislav Fomichev wrote: On 07/26, Andrii Nakryiko wrote: > Apprently listing header as a n

[PATCH 8/8] net: samsung: Spelling s/case/cause/

2019-07-31 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/samsung/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/samsung/Kconfig b/drivers/net/ethernet/samsung/Kconfig index 027938017579130f..e92a178a76df0849 100644 --- a/drivers/net/ethernet/sa

Re: [PATCH net-next] net/tls: prevent skb_orphan() from leaking TLS plain text with offload

2019-07-31 Thread Boris Pismenny
Hi Jacub, On 7/31/2019 12:12 AM, Jakub Kicinski wrote: > sk_validate_xmit_skb() and drivers depend on the sk member of > struct sk_buff to identify segments requiring encryption. > Any operation which removes or does not preserve the original TLS > socket such as skb_orphan() or skb_clone() will c

Re: [Intel-wired-lan] [PATCH bpf-next v4 03/11] libbpf: add flags to umem config

2019-07-31 Thread Björn Töpel
On Tue, 30 Jul 2019 at 19:43, Kevin Laatz wrote: > > This patch adds a 'flags' field to the umem_config and umem_reg structs. > This will allow for more options to be added for configuring umems. > > The first use for the flags field is to add a flag for unaligned chunks > mode. These flags can ei

Re: [PATCH net 0/2] mlxsw: Two small fixes

2019-07-31 Thread David Miller
From: Ido Schimmel Date: Wed, 31 Jul 2019 09:33:13 +0300 > From: Ido Schimmel > > Patch #1 from Jiri fixes the error path of the module initialization > function. Found during manual code inspection. > > Patch #2 from Petr further reduces the default shared buffer pool sizes > in order to work

Re: [PATCH net] drop_monitor: Add missing uAPI file to MAINTAINERS file

2019-07-31 Thread David Miller
From: Ido Schimmel Date: Wed, 31 Jul 2019 09:38:19 +0300 > From: Ido Schimmel > > Fixes: 6e43650cee64 ("add maintainer for network drop monitor kernel service") > Signed-off-by: Ido Schimmel Applied.

RE: [PATCH net-next v4 0/4] enetc: Add mdio bus driver for the PCIe MDIO endpoint

2019-07-31 Thread Claudiu Manoil
>-Original Message- >From: David Miller >Sent: Tuesday, July 30, 2019 7:54 PM >To: Claudiu Manoil >Cc: and...@lunn.ch; robh...@kernel.org; Leo Li ; >Alexandru Marginean ; >netdev@vger.kernel.org; devicet...@vger.kernel.org; linux-arm- >ker...@lists.infradead.org; linux-ker...@vger.kernel.

Re: [PATCH net-next 0/2] mlxsw: Test coverage for DSCP leftover fix

2019-07-31 Thread David Miller
From: Petr Machata Date: Wed, 31 Jul 2019 10:30:25 + > This patch set fixes some global scope pollution issues in the DSCP tests > (in patch #1), and then proceeds (in patch #2) to add a new test for > checking whether, after DSCP prioritization rules are removed from a port, > DSCP rewrites

Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)

2019-07-31 Thread David Miller
From: Greg Kroah-Hartman Date: Wed, 31 Jul 2019 13:35:22 +0200 > On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote: >> On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: >> >> Today's -next fails to build an ARM allmodconfig due to: >> >> > allmodconfig (arm, gcc-8) ― FA

Re: [PATCH 0/8] netfilter fixes for net

2019-07-31 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 31 Jul 2019 13:51:49 +0200 > The following patchset contains Netfilter fixes for your net tree: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks.

Re: [PATCH] net: mediatek: Drop unneeded dependency on NET_VENDOR_MEDIATEK

2019-07-31 Thread David Miller
From: Geert Uytterhoeven Date: Wed, 31 Jul 2019 15:12:02 +0200 > The whole block is protected by "if NET_VENDOR_MEDIATEK", so there is > no need for individual driver config symbols to duplicate this > dependency. > > Signed-off-by: Geert Uytterhoeven Applied.

Re: [PATCH v2] isdn: hfcsusb: Fix mISDN driver crash caused by transfer buffer on the stack

2019-07-31 Thread David Miller
From: Juliana Rodrigueiro Date: Wed, 31 Jul 2019 15:17:23 +0200 > Since linux 4.9 it is not possible to use buffers on the stack for DMA > transfers. > > During usb probe the driver crashes with "transfer buffer is on stack" > message. > > This fix k-allocates a buffer to be used on "read_reg

Re: [PATCH net-next] net/tls: prevent skb_orphan() from leaking TLS plain text with offload

2019-07-31 Thread Willem de Bruijn
On Tue, Jul 30, 2019 at 5:13 PM Jakub Kicinski wrote: > > sk_validate_xmit_skb() and drivers depend on the sk member of > struct sk_buff to identify segments requiring encryption. > Any operation which removes or does not preserve the original TLS > socket such as skb_orphan() or skb_clone() will

Re: [PATCH net v2] ipvs: Improve robustness to the ipvs sysctl

2019-07-31 Thread hujunwei
Hello, Julian On 2019/7/31 3:29, Julian Anastasov wrote: > > Hello, > > On Tue, 30 Jul 2019, hujunwei wrote: > >> From: Junwei Hu >> >> The ipvs module parse the user buffer and save it to sysctl, >> then check if the value is valid. invalid value occurs >> over a period of time. >> Here

Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)

2019-07-31 Thread Greg KH
On Wed, Jul 31, 2019 at 08:48:24AM -0700, David Miller wrote: > From: Greg Kroah-Hartman > Date: Wed, 31 Jul 2019 13:35:22 +0200 > > > On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote: > >> On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: > >> > >> Today's -next fails

[PATCH net v3] ipvs: Improve robustness to the ipvs sysctl

2019-07-31 Thread hujunwei
From: Junwei Hu The ipvs module parse the user buffer and save it to sysctl, then check if the value is valid. invalid value occurs over a period of time. Here, I add a variable, struct ctl_table tmp, used to read the value from the user buffer, and save only when it is valid. I delete proc_do_sy

Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)

2019-07-31 Thread Nathan Chancellor
COMPILE_TEST [=y]) > > >> > > >> which is triggered by the staging OCTEON_ETHERNET driver which misses a > > >> 64BIT dependency but added COMPILE_TEST in 171a9bae68c72f2 > > >> (staging/octeon: Allow test build on !MIPS). > > > > > &

Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)

2019-07-31 Thread David Miller
From: Nathan Chancellor Date: Wed, 31 Jul 2019 09:35:09 -0700 > In file included from ../drivers/net/phy/mdio-octeon.c:14: > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > function 'writeq'; did you mean 'writeb'? > [-Werror=implicit-function-declaration] > 111 | #d

Re: [PATCH bpf-next 1/9] selftests/bpf: prevent headers to be compiled as C code

2019-07-31 Thread Andrii Nakryiko
On Wed, Jul 31, 2019 at 6:21 AM Ilya Leoshkevich wrote: > > > Am 27.07.2019 um 20:53 schrieb Andrii Nakryiko : > > > > On Fri, Jul 26, 2019 at 3:01 PM Stanislav Fomichev wrote: > >> > >> On 07/26, Andrii Nakryiko wrote: > >>> On Fri, Jul 26, 2019 at 2:21 PM Stanislav Fomichev > >>> wrote: > >>>

Re: [PATCH v2 bpf-next 02/12] libbpf: implement BPF CO-RE offset relocation algorithm

2019-07-31 Thread Andrii Nakryiko
On Wed, Jul 31, 2019 at 1:30 AM Song Liu wrote: > > > > > On Jul 30, 2019, at 11:52 PM, Andrii Nakryiko > > wrote: > > > > On Tue, Jul 30, 2019 at 10:19 PM Song Liu wrote: > >> > >> > >> > >>> On Jul 30, 2019, at 6:00 PM, Andrii Nakryiko > >>> wrote: > >>> > >>> On Tue, Jul 30, 2019 at 5:39 P

Re: [PATCH net v3] ipvs: Improve robustness to the ipvs sysctl

2019-07-31 Thread Julian Anastasov
Hello, On Thu, 1 Aug 2019, hujunwei wrote: > From: Junwei Hu > > The ipvs module parse the user buffer and save it to sysctl, > then check if the value is valid. invalid value occurs > over a period of time. > Here, I add a variable, struct ctl_table tmp, used to read > the value from

Re: [PATCH bpf-next v4 04/11] xsk: add support to allow unaligned chunk placement

2019-07-31 Thread Jonathan Lemon
On 30 Jul 2019, at 1:53, Kevin Laatz wrote: Currently, addresses are chunk size aligned. This means, we are very restricted in terms of where we can place chunk within the umem. For example, if we have a chunk size of 2k, then our chunks can only be placed at 0,2k,4k,6k,8k... and so on (ie.

Re: [PATCH bpf-next v4 07/11] mlx5e: modify driver for handling offsets

2019-07-31 Thread Jonathan Lemon
On 30 Jul 2019, at 1:53, Kevin Laatz wrote: With the addition of the unaligned chunks option, we need to make sure we handle the offsets accordingly based on the mode we are currently running in. This patch modifies the driver to appropriately mask the address for each case. Signed-off-by

Re: [oss-drivers] Re: [PATCH net-next] net/tls: prevent skb_orphan() from leaking TLS plain text with offload

2019-07-31 Thread Jakub Kicinski
On Wed, 31 Jul 2019 11:57:10 -0400, Willem de Bruijn wrote: > On Tue, Jul 30, 2019 at 5:13 PM Jakub Kicinski wrote: > > sk_validate_xmit_skb() and drivers depend on the sk member of > > struct sk_buff to identify segments requiring encryption. > > Any operation which removes or does not preserve th

Re: [PATCH 1/2] tools: bpftool: add net load command to load XDP on interface

2019-07-31 Thread Daniel T. Lee
On Wed, Jul 31, 2019 at 7:08 PM Jesper Dangaard Brouer wrote: > > On Wed, 31 Jul 2019 03:48:20 +0900 > "Daniel T. Lee" wrote: > > > By this commit, using `bpftool net load`, user can load XDP prog on > > interface. New type of enum 'net_load_type' has been made, as stated at > > cover-letter, the

Re: [PATCH bpf-next v4 09/11] samples/bpf: add buffer recycling for unaligned chunks to xdpsock

2019-07-31 Thread Jonathan Lemon
On 30 Jul 2019, at 1:53, Kevin Laatz wrote: This patch adds buffer recycling support for unaligned buffers. Since we don't mask the addr to 2k at umem_reg in unaligned mode, we need to make sure we give back the correct (original) addr to the fill queue. We achieve this using the new descri

Re: [PATCH net-next] net/tls: prevent skb_orphan() from leaking TLS plain text with offload

2019-07-31 Thread Jakub Kicinski
On Wed, 31 Jul 2019 13:57:26 +, Boris Pismenny wrote: > > diff --git a/Documentation/networking/tls-offload.rst > > b/Documentation/networking/tls-offload.rst > > index 048e5ca44824..2bc3ab5515d8 100644 > > --- a/Documentation/networking/tls-offload.rst > > +++ b/Documentation/networking/tls-o

[PATCH] net: mdio-octeon: Fix build error and Kconfig warning

2019-07-31 Thread Nathan Chancellor
arm allyesconfig warns: WARNING: unmet direct dependencies detected for MDIO_OCTEON Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y] Selected by [y]: - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES [=y]

Re: [oss-drivers] Re: [PATCH net-next] net/tls: prevent skb_orphan() from leaking TLS plain text with offload

2019-07-31 Thread Willem de Bruijn
On Wed, Jul 31, 2019 at 2:12 PM Jakub Kicinski wrote: > > On Wed, 31 Jul 2019 11:57:10 -0400, Willem de Bruijn wrote: > > On Tue, Jul 30, 2019 at 5:13 PM Jakub Kicinski wrote: > > > sk_validate_xmit_skb() and drivers depend on the sk member of > > > struct sk_buff to identify segments requiring en

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-07-31 Thread Andy Lutomirski
On Wed, Jul 31, 2019 at 1:10 AM Song Liu wrote: > > > > > On Jul 30, 2019, at 1:24 PM, Andy Lutomirski wrote: > > > > On Mon, Jul 29, 2019 at 10:07 PM Song Liu wrote: > >> > >> Hi Andy, > >> > >>> On Jul 27, 2019, at 11:20 AM, Song Liu wrote: > >>> > >>> Hi Andy, > >>> > >>> > > [...] > > >>> >

Re: [PATCH net-next 0/6] flow_offload: add indr-block in nf_table_offload

2019-07-31 Thread Jiri Pirko
Wed, Jul 31, 2019 at 10:12:27AM CEST, we...@ucloud.cn wrote: >From: wenxu > >This series patch make nftables offload support the vlan and >tunnel device offload through indr-block architecture. > >The first four patches mv tc indr block to flow offload and >rename to flow-indr-block. >Because the

Re: [PATCH v2 bpf-next 02/12] libbpf: implement BPF CO-RE offset relocation algorithm

2019-07-31 Thread Song Liu
> On Jul 31, 2019, at 10:18 AM, Andrii Nakryiko > wrote: > > On Wed, Jul 31, 2019 at 1:30 AM Song Liu wrote: >> >> >> >>> On Jul 30, 2019, at 11:52 PM, Andrii Nakryiko >>> wrote: >>> >>> On Tue, Jul 30, 2019 at 10:19 PM Song Liu wrote: > On Jul 30, 2019, at 6:00

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-31 Thread Jiri Pirko
Wed, Jul 31, 2019 at 12:39:52AM CEST, jakub.kicin...@netronome.com wrote: >On Tue, 30 Jul 2019 10:57:32 +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> All devlink instances are created in init_net and stay there for a >> lifetime. Allow user to be able to move devlink instances into >> namesp

Re: [PATCH bpf 1/2] bpf: fix x64 JIT code generation for jmp to 1st insn

2019-07-31 Thread Song Liu
> On Jul 30, 2019, at 6:38 PM, Alexei Starovoitov wrote: > > Introduction of bounded loops exposed old bug in x64 JIT. > JIT maintains the array of offsets to the end of all instructions to > compute jmp offsets. > addrs[0] - offset of the end of the 1st insn (that includes prologue). > addrs[

Re: [PATCH bpf 2/2] selftests/bpf: tests for jmp to 1st insn

2019-07-31 Thread Song Liu
> On Jul 30, 2019, at 6:38 PM, Alexei Starovoitov wrote: > > Add 2 tests that check JIT code generation to jumps to 1st insn. > 1st test is similar to syzbot reproducer. > The backwards branch is never taken at runtime. > 2nd test has branch to 1st insn that executes. > The test is written as

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-31 Thread David Ahern
On 7/31/19 1:26 PM, Jiri Pirko wrote: > Wed, Jul 31, 2019 at 12:39:52AM CEST, jakub.kicin...@netronome.com wrote: >> On Tue, 30 Jul 2019 10:57:32 +0200, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> All devlink instances are created in init_net and stay there for a >>> lifetime. Allow user to be

Re: [PATCH] net: usb: pegasus: fix improper read if get_registers() fail

2019-07-31 Thread Petko Manolov
On 19-07-31 22:10:39, Petko Manolov wrote: > On 19-07-30 15:13:57, Denis Kirjanov wrote: > > get_registers() may fail with -ENOMEM and in this > > case we can read a garbage from the status variable tmp. > > > > Reported-by: syzbot+3499a83b2d062ae40...@syzkaller.appspotmail.com > > Signed-off-by:

Re: [PATCH] net: usb: pegasus: fix improper read if get_registers() fail

2019-07-31 Thread Petko Manolov
On 19-07-30 15:13:57, Denis Kirjanov wrote: > get_registers() may fail with -ENOMEM and in this > case we can read a garbage from the status variable tmp. > > Reported-by: syzbot+3499a83b2d062ae40...@syzkaller.appspotmail.com > Signed-off-by: Denis Kirjanov > --- > drivers/net/usb/pegasus.c | 2

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-31 Thread Jiri Pirko
Wed, Jul 31, 2019 at 09:41:10PM CEST, dsah...@gmail.com wrote: >On 7/31/19 1:26 PM, Jiri Pirko wrote: >> Wed, Jul 31, 2019 at 12:39:52AM CEST, jakub.kicin...@netronome.com wrote: >>> On Tue, 30 Jul 2019 10:57:32 +0200, Jiri Pirko wrote: From: Jiri Pirko All devlink instances are cre

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-31 Thread David Ahern
On 7/31/19 1:45 PM, Jiri Pirko wrote: >> check. e.g., what happens if a resource controller has been configured >> for the devlink instance and it is moved to a namespace whose existing >> config exceeds those limits? > > It's moved with all the values. The whole instance is moved. > The values

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-31 Thread David Ahern
On 7/31/19 1:46 PM, David Ahern wrote: > On 7/31/19 1:45 PM, Jiri Pirko wrote: >>> check. e.g., what happens if a resource controller has been configured >>> for the devlink instance and it is moved to a namespace whose existing >>> config exceeds those limits? >> >> It's moved with all the values.

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-31 Thread David Ahern
On 7/31/19 1:58 PM, David Ahern wrote: > On 7/31/19 1:46 PM, David Ahern wrote: >> On 7/31/19 1:45 PM, Jiri Pirko wrote: check. e.g., what happens if a resource controller has been configured for the devlink instance and it is moved to a namespace whose existing config exceeds those

[net-next 10/16] ice: Update number of VF queue before setting VSI resources

2019-07-31 Thread Jeff Kirsher
From: Akeem G Abodunrin In case there is a request from a VF to change its number of queues, and the request was successful, we need to update number of queues configured on the VF before updating corresponding VSI for that VF, especially LAN Tx queue tree and TC update, otherwise, we would conti

[net-next 00/16][pull request] 100GbE Intel Wired LAN Driver Updates 2019-07-31

2019-07-31 Thread Jeff Kirsher
This series contains updates to ice driver only. Paul adds support for reporting what the link partner is advertising for flow control settings. Jake fixes the hardware statistics register which is prone to rollover since the statistic registers are either 32 or 40 bits wide, depending on which r

[net-next 16/16] ice: Bump version number

2019-07-31 Thread Jeff Kirsher
From: Tony Nguyen Update driver version to 0.7.5 Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/driv

[net-next 05/16] ice: separate out control queue lock creation

2019-07-31 Thread Jeff Kirsher
From: Jacob Keller The ice_init_all_ctrlq and ice_shutdown_all_ctrlq functions create and destroy the locks used to protect the send and receive process of each control queue. This is problematic, as the driver may use these functions to shutdown and re-initialize the control queues at run time.

[net-next 07/16] ice: Disable VFs until reset is completed

2019-07-31 Thread Jeff Kirsher
From: Akeem G Abodunrin This patch adds code to clear VFs enable status until reset is completed, and Tx/Rx rings are setup. Without this patch, the code flow request Tx queues to be disabled after reset, especially PFR - where VF VSI Tx rings have already been wiped off in the NVM and result to

[net-next 01/16] ice: add lp_advertising flow control support

2019-07-31 Thread Jeff Kirsher
From: Paul Greenwalt Add support for reporting link partner advertising when ETHTOOL_GLINKSETTINGS defined. Get pause param reports the Tx/Rx pause configured, and then ethtool issues ETHTOOL_GSET ioctl and ice_get_settings_link_up reports the negotiated Tx/Rx pause. Negotiated pause frame report

[net-next 11/16] ice: Add stats for Rx drops at the port level

2019-07-31 Thread Jeff Kirsher
From: Brett Creeley Currently we are not reporting dropped counts at the port level to ethtool or netlink. This was found when debugging Rx dropped issues and the total packets sent did not equal the total packets received minus the rx_dropped, which was very confusing. To determine dropped count

[net-next 13/16] ice: Don't return error for disabling LAN Tx queue that does exist

2019-07-31 Thread Jeff Kirsher
From: Akeem G Abodunrin Since Tx rings are being managed by FW/NVM, Tx rings might have not been set up or driver had already wiped them off - In that case, call to disable LAN Tx queue is being returned as not in existence. This patch makes sure we don't return unnecessary error for such scenari

[net-next 14/16] ice: Remove unnecessary flag ICE_FLAG_MSIX_ENA

2019-07-31 Thread Jeff Kirsher
From: Brett Creeley This flag is not needed and is called every time we re-enable interrupts in the hotpath so remove it. Also remove ice_vsi_req_irq() because it was a wrapper function for ice_vsi_req_irq_msix() whose sole purpose was checking the ICE_FLAG_MSIX_ENA flag. Signed-off-by: Brett Cr

[net-next 15/16] ice: Remove flag to track VF interrupt status

2019-07-31 Thread Jeff Kirsher
From: Akeem G Abodunrin As a result of refactoring of VF VSIs interrupts code, there is no need to track its configuration status again with ICE_VF_STATE_CFG_INTR flag - In fact, it is not being checked anywhere in the code right now, so this patch removes the dead code as applicable to the flag.

[net-next 12/16] ice: Remove duplicate code in ice_alloc_rx_bufs

2019-07-31 Thread Jeff Kirsher
From: Brett Creeley Currently if the call to ice_alloc_mapped_page() fails we jump to the no_buf label, possibly call ice_release_rx_desc(), and return true indicating that there is more work to do. In the success case we just fall out of the while loop, possibly call ice_alloc_mapped_page(), and

[net-next 03/16] ice: Move vector base setup to PF VSI

2019-07-31 Thread Jeff Kirsher
From: Tony Nguyen When interrupt tracking was refactored, during rebuild, the call to ice_vsi_setup_vector_base() was inadvertently removed from the PF VSI instead of being removed from the VF VSI. During reset, the failure to properly setup the vector base generates a call trace. Correct this so

[net-next 02/16] ice: track hardware stat registers past rollover

2019-07-31 Thread Jeff Kirsher
From: Jacob Keller Currently, ice_stat_update32 and ice_stat_update40 will limit the value of the software statistic to 32 or 40 bits wide, depending on which register is being read. This means that if a driver is running for a long time, the displayed software register values will roll over to

[net-next 09/16] ice: Set up Tx scheduling tree based on alloc VSI Tx queues

2019-07-31 Thread Jeff Kirsher
From: Akeem G Abodunrin This patch uses allocated number of Tx queues per VSI to set up its scheduling tree instead of using total number of available Tx queues. Only PF VSIs have total number of allocated Tx queues equal to number of available Tx queues, other VSIs have different number of queue

[net-next 04/16] ice: Always set prefena when configuring an Rx queue

2019-07-31 Thread Jeff Kirsher
From: Brett Creeley Currently we are always setting prefena to 0. This is causing the hardware to only fetch descriptors when there are none free in the cache for a received packet instead of prefetching when it has used the last descriptor regardless of incoming packets. Fix this by allowing the

[net-next 08/16] ice: Only bump Rx tail and release buffers once per napi_poll

2019-07-31 Thread Jeff Kirsher
From: Brett Creeley Currently we bump the Rx tail and release/give buffers to hardware every 16 descriptors. This causes us to bump Rx tail up to 4 times per napi_poll call. Also we are always bumping tail on an odd index and this is a problem because hardware ignores the lower 3 bits in the QRX_

[net-next 06/16] ice: Do not configure port with no media

2019-07-31 Thread Jeff Kirsher
From: Tony Nguyen The firmware reports an error when trying to configure a port with no media. Instead of always configuring the port, check for media before attempting to configure it. In the absence of media, turn off link and poll for media to become available before re-enabling link. Move ic

[PATCH net] net: phy: fix race in genphy_update_link

2019-07-31 Thread Heiner Kallweit
In phy_start_aneg() autoneg is started, and immediately after that link and autoneg status are read. As reported in [0] it can happen that at time of this read the PHY has reset the "aneg complete" bit but not yet the "link up" bit, what can result in a false link-up detection. To fix this don't re

Re: [patch net-next 0/3] net: devlink: Finish network namespace support

2019-07-31 Thread David Ahern
On 7/30/19 12:08 AM, Jiri Pirko wrote: > Mon, Jul 29, 2019 at 10:17:25PM CEST, dsah...@gmail.com wrote: >> On 7/27/19 3:44 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Devlink from the beginning counts with network namespaces, but the >>> instances has been fixed to init_net. The first patch

Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning

2019-07-31 Thread Randy Dunlap
9bae68c7 ("staging/octeon: > Allow test build on !MIPS") in these files. > > Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS") > Reported-by: kbuild test robot > Reported-by: Mark Brown > Reported-by: Randy Dunlap > Signed-off-by: Nathan Cha

Re: [PATCH 0/2] tools: bpftool: add net (un)load command to load XDP

2019-07-31 Thread David Ahern
On 7/30/19 7:21 PM, Jakub Kicinski wrote: > If bpftool was taught to do equivalent of 'ip link' that would be very different story and I would be opposed to that. >>> Yes, that'd be pretty clear cut, only the XDP stuff is a bit more >>> of a judgement call. >> bpftool must be able t

  1   2   >