Wed, Jul 31, 2019 at 09:41:10PM CEST, dsah...@gmail.com wrote: >On 7/31/19 1:26 PM, Jiri Pirko wrote: >> Wed, Jul 31, 2019 at 12:39:52AM CEST, jakub.kicin...@netronome.com wrote: >>> On Tue, 30 Jul 2019 10:57:32 +0200, Jiri Pirko wrote: >>>> From: Jiri Pirko <j...@mellanox.com> >>>> >>>> All devlink instances are created in init_net and stay there for a >>>> lifetime. Allow user to be able to move devlink instances into >>>> namespaces. >>>> >>>> Signed-off-by: Jiri Pirko <j...@mellanox.com> >>> >>> I'm no namespace expert, but seems reasonable, so FWIW: >>> >>> Acked-by: Jakub Kicinski <jakub.kicin...@netronome.com> >>> >>> If I read things right we will only send the devlink instance >>> notification to other namespaces when it moves, but not >>> notifications for sub-objects like ports. Is the expectation >>> that the user space dumps the objects it cares about or will >>> the other notifications be added as needed (or option 3 - I >>> misread the code). >> >> You are correct. I plan to take care of the notifications of all objects >> in the follow-up patchset. But I can do it in this one if needed. Up to >> you. >> > >seems like it should be a part of this one. If a devlink instance >changes namespaces, all of its associated resources should as well.
Okay. Will do. > >Also, seems like you are missing a 'can this devlink instance be moved' I don't see why not. >check. e.g., what happens if a resource controller has been configured >for the devlink instance and it is moved to a namespace whose existing >config exceeds those limits? It's moved with all the values. The whole instance is moved.
