From: wenxu <we...@ucloud.cn>

This patch make indr_block_call don't access struct tc_indr_block_cb
and tc_indr_block_dev directly

Signed-off-by: wenxu <we...@ucloud.cn>
---
 net/sched/cls_api.c | 33 ++++++++++++++++++++-------------
 1 file changed, 20 insertions(+), 13 deletions(-)

diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index f9643fa..617b098 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -783,13 +783,30 @@ void tc_indr_block_cb_unregister(struct net_device *dev,
 }
 EXPORT_SYMBOL_GPL(tc_indr_block_cb_unregister);
 
+static void flow_indr_block_call(struct flow_block *flow_block,
+                                struct net_device *dev,
+                                struct flow_block_offload *bo,
+                                enum flow_block_command command)
+{
+       struct tc_indr_block_cb *indr_block_cb;
+       struct tc_indr_block_dev *indr_dev;
+
+       indr_dev = tc_indr_block_dev_lookup(dev);
+       if (!indr_dev)
+               return;
+
+       indr_dev->flow_block = command == FLOW_BLOCK_BIND ? flow_block : NULL;
+
+       list_for_each_entry(indr_block_cb, &indr_dev->cb_list, list)
+               indr_block_cb->cb(dev, indr_block_cb->cb_priv, TC_SETUP_BLOCK,
+                                 bo);
+}
+
 static void tc_indr_block_call(struct tcf_block *block, struct net_device *dev,
                               struct tcf_block_ext_info *ei,
                               enum flow_block_command command,
                               struct netlink_ext_ack *extack)
 {
-       struct tc_indr_block_cb *indr_block_cb;
-       struct tc_indr_block_dev *indr_dev;
        struct flow_block_offload bo = {
                .command        = command,
                .binder_type    = ei->binder_type,
@@ -800,17 +817,7 @@ static void tc_indr_block_call(struct tcf_block *block, 
struct net_device *dev,
        };
        INIT_LIST_HEAD(&bo.cb_list);
 
-       indr_dev = tc_indr_block_dev_lookup(dev);
-       if (!indr_dev)
-               return;
-
-       indr_dev->flow_block = command == FLOW_BLOCK_BIND ?
-                                         &block->flow_block : NULL;
-
-       list_for_each_entry(indr_block_cb, &indr_dev->cb_list, list)
-               indr_block_cb->cb(dev, indr_block_cb->cb_priv, TC_SETUP_BLOCK,
-                                 &bo);
-
+       flow_indr_block_call(&block->flow_block, dev, &bo, command);
        tcf_block_setup(block, &bo);
 }
 
-- 
1.8.3.1

Reply via email to