Wed, Jul 31, 2019 at 12:39:52AM CEST, jakub.kicin...@netronome.com wrote: >On Tue, 30 Jul 2019 10:57:32 +0200, Jiri Pirko wrote: >> From: Jiri Pirko <j...@mellanox.com> >> >> All devlink instances are created in init_net and stay there for a >> lifetime. Allow user to be able to move devlink instances into >> namespaces. >> >> Signed-off-by: Jiri Pirko <j...@mellanox.com> > >I'm no namespace expert, but seems reasonable, so FWIW: > >Acked-by: Jakub Kicinski <jakub.kicin...@netronome.com> > >If I read things right we will only send the devlink instance >notification to other namespaces when it moves, but not >notifications for sub-objects like ports. Is the expectation >that the user space dumps the objects it cares about or will >the other notifications be added as needed (or option 3 - I >misread the code).
You are correct. I plan to take care of the notifications of all objects in the follow-up patchset. But I can do it in this one if needed. Up to you. > >I was also wondering it moving the devlink instance during a >multi-part transaction could be an issue. But AFAIU it should >be fine - the flashing doesn't release the instance lock, and >health stuff should complete correctly even if devlink is moved >half way through? Yes, I don't see any issue there as well.
