On Wed, Dec 2, 2020 at 2:09 AM Jiri Pirko wrote:
> >I'm not suggesting the port split be dynamic at all. I'm suggesting that if
> >the admin wants or needs to force PAM4 on a port that would otherwise
> >be able to achieve the given speed using more lanes with NRZ, then the
> >admin should split
Wed, Dec 02, 2020 at 01:32:46AM CET, edwin.p...@broadcom.com wrote:
>On Tue, Dec 1, 2020 at 3:22 AM Jiri Pirko wrote:
>
>> >Consider a physical QSFP connector comprising 4 lanes. Today, if the
>> >speed is forced, we would achieve 100G speeds using all 4 lanes with
>> >NRZ encoding. If we configur
On Tue, Dec 1, 2020 at 9:23 AM Danielle Ratson wrote:
> The suggestions I have are:
> 1. Add a bit that for unknown media for each link (something like
> ETHTOOL_LINK_MODE_10unknown_Full_BIT). I am not sure it is even possible
> or makes sense.
> 2. Pass the link mode as bitmap.
>
> Do you
On Wed, Nov 25, 2020 at 10:35:35AM +, Danielle Ratson wrote:
> > > In ethtool, for speed 100G and 4 lanes for example, there are few link
> > > modes that fits:
> > > ETHTOOL_LINK_MODE_10baseKR4_Full_BIT
> > > ETHTOOL_LINK_MODE_10baseSR4_Full_BIT
> > > ETHTOOL_LINK_MODE_10baseCR4_
On Tue, Dec 1, 2020 at 3:22 AM Jiri Pirko wrote:
> >Consider a physical QSFP connector comprising 4 lanes. Today, if the
> >speed is forced, we would achieve 100G speeds using all 4 lanes with
> >NRZ encoding. If we configure the port for PAM4 encoding at the same
> >speed, then we only require 2
gmail.com; mlxsw
> ; Ido Schimmel ;
> johan...@sipsolutions.net
> Subject: Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI
> with lanes
>
> On Wed, Nov 25, 2020 at 10:35:35AM +, Danielle Ratson wrote:
> > > > What do you think of passing the link mod
Mon, Nov 30, 2020 at 07:00:16PM CET, edwin.p...@broadcom.com wrote:
>On Mon, Nov 30, 2020 at 9:14 AM Jiri Pirko wrote:
>
>> >> There is a crucial difference. Split port is configured alwasy by user.
>> >> Each split port has a devlink instace, netdevice associated with it.
>> >> It is one level ab
On Mon, Nov 30, 2020 at 9:14 AM Jiri Pirko wrote:
> >> There is a crucial difference. Split port is configured alwasy by user.
> >> Each split port has a devlink instace, netdevice associated with it.
> >> It is one level above the lanes.
> >
> >Right, but the one still implies the other. Splitti
Mon, Nov 30, 2020 at 06:01:43PM CET, edwin.p...@broadcom.com wrote:
>On Mon, Nov 23, 2020 at 1:40 AM Jiri Pirko wrote:
>
>> >Why can't this be implied by port break-out configuration? For higher
>> >speed signalling modes like PAM4, what's the difference between a
>> >port with unused lanes vs the
On Mon, Nov 23, 2020 at 1:40 AM Jiri Pirko wrote:
> >Why can't this be implied by port break-out configuration? For higher
> >speed signalling modes like PAM4, what's the difference between a
> >port with unused lanes vs the same port split into multiple logical
> >ports? In essence, the driver c
On Wed, Nov 25, 2020 at 10:35:35AM +, Danielle Ratson wrote:
> > > What do you think of passing the link modes you have suggested as a
> > > bitmask, similar to "supported", that contains only one positive bit?
> > > Something like that:
>
> Hi Michal,
>
> Thanks for your response.
>
> Actua
gmail.com; mlxsw
> ; Ido Schimmel ;
> johan...@sipsolutions.net
> Subject: Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI
> with lanes
>
> On Mon, Nov 23, 2020 at 09:47:53AM +, Danielle Ratson wrote:
> >
> >
> > > -Original Message---
Ido Schimmel
> > ; netdev@vger.kernel.org; da...@davemloft.net; Jiri
> > Pirko ; f.faine...@gmail.com; mlxsw
> > ; Ido Schimmel ;
> > johan...@sipsolutions.net
> > Subject: Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI
> > with
; mlxsw
> ; Ido Schimmel ;
> johan...@sipsolutions.net
> Subject: Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI
> with lanes
>
> On Thu, Oct 22, 2020 at 06:15:48AM +, Danielle Ratson wrote:
> > > -Original Message-
> > > From: M
Thu, Nov 19, 2020 at 09:38:34PM CET, edwin.p...@broadcom.com wrote:
>On Sat, Oct 10, 2020 at 3:54 PM Ido Schimmel wrote:
>
>> Add 'ETHTOOL_A_LINKMODES_LANES' attribute and expand 'struct
>> ethtool_link_settings' with lanes field in order to implement a new
>> lanes-selector that will enable the u
On Sat, Oct 10, 2020 at 3:54 PM Ido Schimmel wrote:
> Add 'ETHTOOL_A_LINKMODES_LANES' attribute and expand 'struct
> ethtool_link_settings' with lanes field in order to implement a new
> lanes-selector that will enable the user to advertise a specific number
> of lanes as well.
Why can't this be
On Thu, Oct 22, 2020 at 06:15:48AM +, Danielle Ratson wrote:
> > -Original Message-
> > From: Michal Kubecek
> > Sent: Wednesday, October 21, 2020 11:48 AM
> >
> > Ah, right, it does. But as you extend struct ethtool_link_ksettings
> > and drivers will need to be updated to provide th
; mlxsw ; Ido
> Schimmel ; johan...@sipsolutions.net
> Subject: Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI
> with lanes
>
> On Wed, Oct 21, 2020 at 07:20:22AM +, Danielle Ratson wrote:
> > > -Original Message-
> > > From: Michal
On Wed, Oct 21, 2020 at 07:20:22AM +, Danielle Ratson wrote:
> > -Original Message-
> > From: Michal Kubecek
> > Sent: Wednesday, October 21, 2020 10:08 AM
> >
> > On Tue, Oct 20, 2020 at 07:39:13AM +, Danielle Ratson wrote:
> > > > -Original Message-
> > > > From: Michal
; mlxsw ; Ido
> Schimmel ; johan...@sipsolutions.net
> Subject: Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI
> with lanes
>
> On Tue, Oct 20, 2020 at 07:39:13AM +, Danielle Ratson wrote:
> > > -Original Message-
> > > From: Mic
On Tue, Oct 20, 2020 at 07:39:13AM +, Danielle Ratson wrote:
> > -Original Message-
> > From: Michal Kubecek
> > Sent: Monday, October 19, 2020 4:25 PM
> >
> > As I said, I meant the extension suggested in my mail as independent of what
> > this series is about. For lanes count select
; mlxsw ;
> Ido Schimmel ; johan...@sipsolutions.net
> Subject: Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI
> with lanes
>
> On Mon, Oct 19, 2020 at 02:26:43PM +0200, Jiri Pirko wrote:
> > Mon, Oct 19, 2020 at 01:04:22PM CEST, mkube...@suse.cz wrote:
> >
On Mon, Oct 19, 2020 at 02:26:43PM +0200, Jiri Pirko wrote:
> Mon, Oct 19, 2020 at 01:04:22PM CEST, mkube...@suse.cz wrote:
> >
> >It would be quite easy to extend the ethtool command line parser to
> >allow also
> >
> > ethtool -s advertise ...
> >
> >in addition to already supported
> >
> > e
> >> 10baseKR2/Full
> >> 10baseSR2/Full
> >> 10baseCR2/Full
> >> 10baseLR2_ER2_FR2/Full
> >> 10baseDR2/Full
> >
> >I'm
Mon, Oct 19, 2020 at 01:04:22PM CEST, mkube...@suse.cz wrote:
>On Mon, Oct 19, 2020 at 07:19:34AM +, Danielle Ratson wrote:
>> > -Original Message-
>> > From: Andrew Lunn
>> > Sent: Saturday, October 17, 2020 1:16 AM
>> >
>> > I'm not sure i fully understand all these different link m
Sat, Oct 17, 2020 at 12:15:53AM CEST, and...@lunn.ch wrote:
>> Example:
>> - swp1 is a 200G port with 4 lanes.
>> - QSFP28 is plugged in.
>> - The user wants to select configuration of 100G speed using 2 lanes, 50G
>> each.
>>
>> $ ethtool swp1
>> Settings for swp1:
>> Supported ports: [
On Mon, Oct 19, 2020 at 07:19:34AM +, Danielle Ratson wrote:
> > -Original Message-
> > From: Andrew Lunn
> > Sent: Saturday, October 17, 2020 1:16 AM
> >
> > I'm not sure i fully understand all these different link modes, but
> > i thought these 5 are all 100G using 2 lanes? So why c
; Ido Schimmel ;
> johan...@sipsolutions.net
> Subject: Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI
> with lanes
>
> > Example:
> > - swp1 is a 200G port with 4 lanes.
> > - QSFP28 is plugged in.
> > - The user wants to select configuration of
> Example:
> - swp1 is a 200G port with 4 lanes.
> - QSFP28 is plugged in.
> - The user wants to select configuration of 100G speed using 2 lanes, 50G
> each.
>
> $ ethtool swp1
> Settings for swp1:
> Supported ports: [ FIBRE Backplane ]
> Supported link modes: 1000baseT
On Tue, 13 Oct 2020 14:29:29 + Danielle Ratson wrote:
> > On Mon, 12 Oct 2020 15:33:45 + Danielle Ratson wrote:
> > > > What's the use for this in practical terms? Isn't the lane count
> > > > basically implied by the module that gets plugged in?
> > >
> > > The use is to enable the use
do
> Schimmel ; johan...@sipsolutions.net
> Subject: Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI
> with lanes
>
> On Mon, 12 Oct 2020 15:33:45 + Danielle Ratson wrote:
> > > What's the use for this in practical terms? Isn't the lane count
>
On Mon, 12 Oct 2020 21:10:53 +0200 Johannes Berg wrote:
> Hi,
>
> Sorry, somehow didn't see this until now.
>
> > > +/* Lanes, 1, 2, 4 or 8. */
> > > +#define ETHTOOL_LANES_1 1
> > > +#define ETHTOOL_LANES_2 2
> > > +#define ETHTOOL_LANES_4 4
> >
Hi,
Sorry, somehow didn't see this until now.
> > +/* Lanes, 1, 2, 4 or 8. */
> > +#define ETHTOOL_LANES_11
> > +#define ETHTOOL_LANES_22
> > +#define ETHTOOL_LANES_44
> > +#define ETHTOOL_LANES_88
>
> Not an extreme
On Sat, Oct 10, 2020 at 06:41:14PM +0300, Ido Schimmel wrote:
> From: Danielle Ratson
>
> Currently, when auto negotiation is on, the user can advertise all the
> linkmodes which correspond to a specific speed, but does not have a
> similar selector for the number of lanes. This is significant wh
On Mon, Oct 12, 2020 at 03:33:45PM +, Danielle Ratson wrote:
> >
> > > +/* Lanes, 1, 2, 4 or 8. */
> > > +#define ETHTOOL_LANES_1 1
> > > +#define ETHTOOL_LANES_2 2
> > > +#define ETHTOOL_LANES_4 4
> > > +#define ETHTOOL_LANES_8
On Mon, 12 Oct 2020 15:33:45 + Danielle Ratson wrote:
> > What's the use for this in practical terms? Isn't the lane count basically
> > implied by the module that gets plugged in?
>
> The use is to enable the user to decide how to achieve a certain speed.
> For example, if he wants to get
; Ido Schimmel ;
> johan...@sipsolutions.net
> Subject: Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI
> with lanes
>
> On Sat, 10 Oct 2020 18:41:14 +0300 Ido Schimmel wrote:
> > From: Danielle Ratson
> >
> > Currently, when auto negotiation is on, the
On Sat, 10 Oct 2020 18:41:14 +0300 Ido Schimmel wrote:
> From: Danielle Ratson
>
> Currently, when auto negotiation is on, the user can advertise all the
> linkmodes which correspond to a specific speed, but does not have a
> similar selector for the number of lanes. This is significant when a
>
From: Danielle Ratson
Currently, when auto negotiation is on, the user can advertise all the
linkmodes which correspond to a specific speed, but does not have a
similar selector for the number of lanes. This is significant when a
specific speed can be achieved using different number of lanes. Fo
39 matches
Mail list logo
