On Thu, Oct 22, 2020 at 06:15:48AM +0000, Danielle Ratson wrote: > > -----Original Message----- > > From: Michal Kubecek <mkube...@suse.cz> > > Sent: Wednesday, October 21, 2020 11:48 AM > > > > Ah, right, it does. But as you extend struct ethtool_link_ksettings > > and drivers will need to be updated to provide this information, > > wouldn't it be more useful to let the driver provide link mode in > > use instead (and derive number of lanes from it)? > > This is the way it is done with the speed parameter, so I have aligned > it to it. Why the lanes should be done differently comparing to the > speed?
Speed and duplex have worked this way since ages and the interface was probably introduced back in times when combination of speed and duplex was sufficient to identify the link mode. This is no longer the case and even adding number of lanes wouldn't make the combination unique. So if we are going to extend the interface now and update drivers to provide extra information, I believe it would be more useful to provide full information. Michal
