On Wed, Nov 25, 2020 at 10:35:35AM +0000, Danielle Ratson wrote: > > > What do you think of passing the link modes you have suggested as a > > > bitmask, similar to "supported", that contains only one positive bit? > > > Something like that: > > Hi Michal, > > Thanks for your response. > > Actually what I said is not very accurate. > In ethtool, for speed 100G and 4 lanes for example, there are few link modes > that fits: > ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT > ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT > ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT > ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT > > The difference is the media. And in the driver we shrink into one bit. > But maybe that makes passing a bitmask more sense, or am I missing something?
But as far as I understand, at any moment, only one of these will be actually in use so that's what the driver should report. Or is the problem that the driver cannot identify the media in use? (To be precise: by "cannot identify" I mean "it's not possible for the driver to find out", not "current code does not distinguish".) Michal
