On Mon, Oct 12, 2020 at 03:33:45PM +0000, Danielle Ratson wrote:
> >
> > > +/* Lanes, 1, 2, 4 or 8. */
> > > +#define ETHTOOL_LANES_1 1
> > > +#define ETHTOOL_LANES_2 2
> > > +#define ETHTOOL_LANES_4 4
> > > +#define ETHTOOL_LANES_8 8
> >
> > Not an extremely useful set of defines, not sure Michal would agree.
I don't see much use for them either. Such defines or enums make sense
when the numbers represent some values which have symbolic names but
these values only represent number of lanes so a number is IMHO
sufficient.
> > > +#define ETHTOOL_LANES_UNKNOWN 0
> >
> > > struct link_mode_info {
> > > int speed;
> > > + int lanes;
> >
> > why signed?
>
> I have aligned it to the speed.
For speed, signed type was used mostly because SPEED_UNKNOWN is defined
as -1 (even if it's cast to u32 in most places), I don't think there is
a reason to use a signed type.
Michal
