Re: [PATCH v13 2/4] phy: Add ethernet serdes configuration option

2021-02-03 Thread Vinod Koul
On 29-01-21, 14:07, Steen Hegelund wrote: > Provide a new ethernet phy configuration structure, that > allow PHYs used for ethernet to be configured with > speed, media type and clock information. This lgtm, Kishon ? > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund > Reviewed-by

Re: [PATCH 2/4] batman-adv: Update copyright years for 2021

2021-02-03 Thread Sven Eckelmann
On Thursday, 4 February 2021 01:35:06 CET Jakub Kicinski wrote: [...] > Is this how copyright works? I'm not a layer, but I thought it was > supposed to reflect changes done to given file in a given year. Because we all know that the first thing a person is doing when submitting a change is to up

Re: [PATCH net-next v4 1/2] net: mhi-net: Add de-aggeration support

2021-02-03 Thread Loic Poulain
Hi Jesse, On Thu, 4 Feb 2021 at 00:16, Jesse Brandeburg wrote: > > Loic Poulain wrote: > > > When device side MTU is larger than host side MTU, the packets > > (typically rmnet packets) are split over multiple MHI transfers. > > In that case, fragments must be re-aggregated to recover the packet

Re: [PATCH 1/4] batman-adv: Start new development cycle

2021-02-03 Thread Sven Eckelmann
On Thursday, 4 February 2021 01:33:02 CET Jakub Kicinski wrote: [...] > For just comment adjustments and the sizeof() change? The process is basically: 1. update the version information for a development period 2. queue up whatever comes in during that time 3. send it to netdev for net-next when

Re: [PATCH net-next v2 1/3] net: mhi: Add RX/TX fixup callbacks

2021-02-03 Thread Loic Poulain
Hi Jakub, On Thu, 4 Feb 2021 at 00:08, Jakub Kicinski wrote: > > Please put the maintainers or the list thru which you expect the patch > to be applied in the To: field of your emails. > > On Mon, 1 Feb 2021 22:05:40 +0100 Loic Poulain wrote: > > + if (proto && proto->tx_fixup) { > > +

[PATCH net-next] xfrm: Return the correct errno code

2021-02-03 Thread Zheng Yongjun
When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/xfrm/xfrm_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index d0c32a8fcc4a..ad63a6c77edd 100644 --- a/net/xfrm/xfr

Re: [PATCH] ath11k: remove h from printk format specifier

2021-02-03 Thread Kalle Valo
t...@redhat.com wrote: > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is already done and %hx and %hhx is useless > so do not encourag

Re: [PATCH] ath10k: remove h from printk format specifier

2021-02-03 Thread Kalle Valo
t...@redhat.com wrote: > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is already done and %hx and %hhx is useless > so do not encourag

[PATCH net-next] net: sched: Return the correct errno code

2021-02-03 Thread Zheng Yongjun
When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/sched/em_nbyte.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/em_nbyte.c b/net/sched/em_nbyte.c index 2c1192a2ee5e..a83b237cbeb0 100644 --- a/net/sched/em

[PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-03 Thread Eli Cohen
When a change of memory map occurs, the hardware resources are destroyed and then re-created again with the new memory map. In such case, we need to restore the hardware available and used indices. The driver failed to restore the used index which is added here. Also, since the driver also fails t

[PATCH net-next] net: Return the correct errno code

2021-02-03 Thread Zheng Yongjun
When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/mpls/af_mpls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index f2868a8a50c3..7e73611c48dd 100644 --- a/net/mpls/af_mpls.c

[PATCH net-next] ipv6: Return the correct errno code

2021-02-03 Thread Zheng Yongjun
When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/ipv6/addrconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 8b6eb384bac7..347b95bc00fd 100644 --- a/net/ipv6/addrco

[PATCH net-next] dccp: Return the correct errno code

2021-02-03 Thread Zheng Yongjun
When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/dccp/feat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dccp/feat.c b/net/dccp/feat.c index 788dd629c420..4cb813bee7b4 100644 --- a/net/dccp/feat.c +++ b/net/d

[PATCH net-next] net: ipv4: Return the correct errno code

2021-02-03 Thread Zheng Yongjun
When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/ipv4/devinet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 123a6d39438f..fa586e915621 100644 --- a/net/ipv4/devinet.c

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-02-03 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 12:07 AM Nathan Chancellor wrote: > > On Wed, Jan 13, 2021 at 02:38:27PM -0800, Andrii Nakryiko wrote: > > Hm.. Just saw Linus proposing using $(error-if) in Kconfig for an > > unrelated issue ([0]). If we can make this work, then it would catch > > such issue early on, yet

Re: [PATCH] vdpa/mlx5: Restore the hardware used index after change map

2021-02-03 Thread Eli Cohen
On Wed, Feb 03, 2021 at 12:33:26PM -0800, Si-Wei Liu wrote: > On Tue, Feb 2, 2021 at 10:48 PM Eli Cohen wrote: > > > > On Tue, Feb 02, 2021 at 09:14:02AM -0800, Si-Wei Liu wrote: > > > On Tue, Feb 2, 2021 at 6:34 AM Eli Cohen wrote: > > > > > > > > When a change of memory map occurs, the hardware

Re: [PATCH net-next 1/4] PCI/VPD: Remove Chelsio T3 quirk

2021-02-03 Thread Heiner Kallweit
On 04.02.2021 03:30, Jakub Kicinski wrote: > On Tue, 2 Feb 2021 21:35:55 +0100 Heiner Kallweit wrote: >> cxgb3 driver doesn't use the PCI core code for VPD access, it has its own >> implementation. Therefore we don't need a quirk for it in the core code. >> >> Signed-off-by: Heiner Kallweit > > W

Re: [PATCH] vdpa/mlx5: Restore the hardware used index after change map

2021-02-03 Thread Eli Cohen
On Wed, Feb 03, 2021 at 12:33:26PM -0800, Si-Wei Liu wrote: > On Tue, Feb 2, 2021 at 10:48 PM Eli Cohen wrote: > > > > On Tue, Feb 02, 2021 at 09:14:02AM -0800, Si-Wei Liu wrote: > > > On Tue, Feb 2, 2021 at 6:34 AM Eli Cohen wrote: > > > > > > > > When a change of memory map occurs, the hardware

[PATCH] net: bridge: mcast: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

2021-02-03 Thread Xu Wang
Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). net/bridge/br_multicast.c:1246:9-16: WARNING: ERR_CAST can be used with mp Generated by: scripts/coccinelle/api/err_cast.cocci Signed-off-by: Xu Wang --- net/bridge/br_multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH 1/2] vdpa/mlx5: Avoid unnecessary query virtqueue

2021-02-03 Thread Eli Cohen
On Wed, Feb 03, 2021 at 03:19:40PM -0800, Si-Wei Liu wrote: > On Tue, Feb 2, 2021 at 9:16 PM Jason Wang wrote: > > > > > > On 2021/2/3 上午1:54, Si-Wei Liu wrote: > > > On Tue, Feb 2, 2021 at 1:23 AM Eli Cohen wrote: > > >> On Tue, Feb 02, 2021 at 12:38:51AM -0800, Si-Wei Liu wrote: > > >>> Thanks

Re: [PATCH net-next v2 2/4] net: Introduce {netdev,napi}_alloc_frag_align()

2021-02-03 Thread Kevin Hao
On Tue, Feb 02, 2021 at 08:26:19AM -0800, Alexander Duyck wrote: > On Sun, Jan 31, 2021 at 12:17 AM Kevin Hao wrote: > > > > In the current implementation of {netdev,napi}_alloc_frag(), it doesn't > > have any align guarantee for the returned buffer address, But for some > > hardwares they do requ

Re: [PATCH net-next v2 1/4] mm: page_frag: Introduce page_frag_alloc_align()

2021-02-03 Thread Kevin Hao
On Tue, Feb 02, 2021 at 08:19:54AM -0800, Alexander Duyck wrote: > On Sat, Jan 30, 2021 at 11:54 PM Kevin Hao wrote: > > > > In the current implementation of page_frag_alloc(), it doesn't have > > any align guarantee for the returned buffer address. But for some > > hardwares they do require the D

Re: [PATCH bpf-next v4 1/6] xsk: add tracepoints for packet drops

2021-02-03 Thread Song Liu
On Wed, Feb 3, 2021 at 12:13 AM Ciara Loftus wrote: > > This commit introduces tracing infrastructure for AF_XDP sockets > (xsks) and a new trace event called 'xsk_packet_drop'. This trace > event is triggered when a packet cannot be processed by the socket > due to one of the following issues: >

Re: [PATCH net] net: hdlc_x25: Return meaningful error code in x25_open

2021-02-03 Thread Martin Schiller
On 2021-02-03 08:15, Xie He wrote: It's not meaningful to pass on LAPB error codes to HDLC code or other parts of the system, because they will not understand the error codes. Instead, use system-wide recognizable error codes. Fixes: f362e5fe0f1f ("wan/hdlc_x25: make lapb params configurable")

Re: [PATCH net-next 0/7] GTP

2021-02-03 Thread Pravin Shelar
On Mon, Feb 1, 2021 at 10:53 PM Jonas Bonn wrote: > > There's ongoing work in this driver to provide support for IPv6, GRO, > GSO, and "collect metadata" mode operation. In order to facilitate this > work going forward, this short series accumulates already ACK:ed patches > that are ready for the

[PATCH net 1/1] net: stmmac: set TxQ mode back to DCB after disabling CBS

2021-02-03 Thread Song Yoong Siang
From: Mohammad Athari Bin Ismail When disable CBS, mode_to_use parameter is not updated even the operation mode of Tx Queue is changed to Data Centre Bridging (DCB). Therefore, when tc_setup_cbs() function is called to re-enable CBS, the operation mode of Tx Queue remains at DCB, which causing CB

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Bjorn Andersson
On Wed 03 Feb 12:40 CST 2021, Jakub Kicinski wrote: > On Wed, 3 Feb 2021 19:28:28 +0100 Loic Poulain wrote: > > On Wed, 3 Feb 2021 at 19:05, Jakub Kicinski wrote: > > > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > > > The current patchset only supports QMI channel so I'd

Re: [PATCH] xen/netback: avoid race in xenvif_rx_ring_slots_available()

2021-02-03 Thread Jürgen Groß
On 04.02.21 00:48, Jakub Kicinski wrote: On Tue, 2 Feb 2021 08:09:38 +0100 Juergen Gross wrote: Since commit 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding") xenvif_rx_ring_slots_available() is no longer called only from the rx queue kernel thread, so it needs to access the rx queue w

Re: [PATCH] rt2x00: remove duplicate word in comment

2021-02-03 Thread wengjianfeng
On Wed, 3 Feb 2021 16:33:37 -0800 Randy Dunlap wrote: > On 2/3/21 4:30 PM, wengjianfeng wrote: > > On Wed, 3 Feb 2021 07:16:17 -0800 > > Randy Dunlap wrote: > > > >> On 2/2/21 10:38 PM, samirweng1979 wrote: > >>> From: wengjianfeng > >>> > >>> remove duplicate word 'we' in comment > >>> > >>>

[PATCH net] net/sched: cls_flower: Return invalid for unknown ct_state flags rules

2021-02-03 Thread wenxu
From: wenxu Reject the unknown ct_state flags of cls flower rules. This also make the userspace like ovs to probe the ct_state flags support in the kernel. Signed-off-by: wenxu --- include/uapi/linux/pkt_cls.h | 9 + net/sched/cls_flower.c | 4 2 files changed, 13 insertions

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Manivannan Sadhasivam
On Wed, Feb 03, 2021 at 10:40:28AM -0800, Jakub Kicinski wrote: > On Wed, 3 Feb 2021 19:28:28 +0100 Loic Poulain wrote: > > On Wed, 3 Feb 2021 at 19:05, Jakub Kicinski wrote: > > > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > > > The current patchset only supports QMI chan

Re: [PATCH net-next v4 0/8] Support setting lanes via ethtool

2021-02-03 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 2 Feb 2021 20:06:04 +0200 you wrote: > Some speeds can be achieved with different number of lanes. For example, > 100Gbps can be achieved using two lanes of 50Gbps or four lanes of > 25Gbps. This patchset adds a ne

Re: [PATCH net-next] net: dsa: fix SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING getting ignored

2021-02-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 3 Feb 2021 01:31:09 +0200 you wrote: > From: Vladimir Oltean > > The bridge emits VLAN filtering events and quite a few others via > switchdev with orig_dev = br->dev. After the blamed commit, these events > star

Re: [PATCH net-next] tcp: use a smaller percpu_counter batch size for sk_alloc

2021-02-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 2 Feb 2021 11:34:08 -0800 you wrote: > Currently, a percpu_counter with the default batch size (2*nr_cpus) is > used to record the total # of active sockets per protocol. This means > sk_sockets_allocated_read_posi

Re: [PATCH V3] drivers: net: ethernet: i825xx: Fix couple of spellings in the file ether1.c

2021-02-03 Thread Randy Dunlap
On 2/3/21 7:16 PM, Bhaskar Chowdhury wrote: > > > s/initialsation/initialisation/ > s/specifiing/specifying/ > > Signed-off-by: Bhaskar Chowdhury Aside from the Subject: being longer than needed, as Jakub commented, it's fine for me. Thanks. Acked-by: Randy Dunlap > --- > Changes from V2:

Re: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c

2021-02-03 Thread Randy Dunlap
On 2/3/21 6:32 PM, Bhaskar Chowdhury wrote: > On 18:09 Wed 03 Feb 2021, Randy Dunlap wrote: >> On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote: >>> >>> s/initialsation/initialisation/ >>> s/specifiing/specifying/ >>> >>> Plus get rid of few blank lines. >>> >>> Signed-off-by: Bhaskar Chowdhury >>> ---

Re: [PATCH net-next 2/7] net: hns3: RSS indirection table and key use device specifications

2021-02-03 Thread Huazhong Tan
On 2021/2/4 8:50, Jakub Kicinski wrote: On Tue, 2 Feb 2021 20:39:48 +0800 Huazhong Tan wrote: struct hclgevf_rss_cfg { - u8 rss_hash_key[HCLGEVF_RSS_KEY_SIZE]; /* user configured hash keys */ + /* user configured hash keys */ + u8 rss_hash_key[HCLGEVF_RSS_KEY_SIZE_MAX];

[PATCH net-next] net: core: Return the correct errno code

2021-02-03 Thread Zheng Yongjun
When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/core/rtnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 7d7223691783..6df8fb25668b 100644 --- a/net/core/rtn

Re: [PATCH iproute2-next v3 0/5] Add vdpa device management tool

2021-02-03 Thread Jason Wang
On 2021/2/2 下午6:35, Parav Pandit wrote: Linux vdpa interface allows vdpa device management functionality. This includes adding, removing, querying vdpa devices. vdpa interface also includes showing supported management devices which support such operations. This patchset includes kernel uapi

[PATCH V3] drivers: net: ethernet: i825xx: Fix couple of spellings in the file ether1.c

2021-02-03 Thread Bhaskar Chowdhury
s/initialsation/initialisation/ s/specifiing/specifying/ Signed-off-by: Bhaskar Chowdhury --- Changes from V2: Adjust and make changes which are obvious as per Randy's suggestions drivers/net/ethernet/i825xx/ether1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

Re: [PATCH RESEND iproute2 5.11] iplink_can: add Classical CAN frame LEN8_DLC support

2021-02-03 Thread David Ahern
On 2/3/21 12:04 PM, Oliver Hartkopp wrote: > My only fault was, that I did not send the patch for iproute2-next at > the time when the len8_dlc patches were in net-next, right? yes

Re: [PATCHv17 bpf-next 0/6] xdp: add a new helper for dev map multicast support

2021-02-03 Thread Hangbin Liu
On Wed, Feb 03, 2021 at 06:53:20PM -0800, John Fastabend wrote: > Hangbin Liu wrote: > > Hi Daniel, Alexei, > > > > It has been one week after Maciej, Toke, John's review/ack. What should > > I do to make a progress for this patch set? > > > > Patchwork is usually the first place to check: Than

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-03 Thread Josh Poimboeuf
On Wed, Feb 03, 2021 at 09:44:48PM -0500, Steven Rostedt wrote: > > > [ 128.441287][C0] RIP: 0010:skcipher_walk_next > > > (crypto/skcipher.c:322 crypto/skcipher.c:384) > > Why do we have an RIP in skcipher_walk_next, if its the unwinder that > had a bug? Or are they related? > > Or did skci

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-03 Thread Jason Wang
On 2021/2/4 上午2:28, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 12:33 AM Jason Wang wrote: On 2021/2/2 下午10:37, Willem de Bruijn wrote: On Mon, Feb 1, 2021 at 10:09 PM Jason Wang wrote: On 2021/1/29 上午8:21, Wei Wang wrote: With the implementation of napi-tx in virtio driver, we clean

Re: [PATCH] rt2x00: remove duplicate word in comment

2021-02-03 Thread wengjianfeng
On Wed, 3 Feb 2021 07:16:17 -0800 Randy Dunlap wrote: > On 2/2/21 10:38 PM, samirweng1979 wrote: > > From: wengjianfeng > > > > remove duplicate word 'we' in comment > > > > Signed-off-by: wengjianfeng > > --- > > drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +- > > 1 file changed,

[PATCH net-next] net: core: Remove extra spaces

2021-02-03 Thread Zheng Yongjun
Do codingstyle clean up to remove extra spaces. Signed-off-by: Zheng Yongjun --- net/core/neighbour.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 9500d28a43b0..72ea94ec8c4a 100644 --- a/net/core/neighbour.c +++ b/net/core/

Re: [PATCH net-next] seg6: fool-proof the processing of SRv6 behavior attributes

2021-02-03 Thread David Ahern
On 2/3/21 7:27 PM, Andrea Mayer wrote: > > I think there is an issue here because BITS_PER_TYPE(unsigned long) is greater > than the SEG6_LOCAL_MAX (currently = 9). > > I think it should be like this: > > BUILD_BUG_ON(SEG6_LOCAL_MAX + 1 > BITS_PER_TYPE(unsigned long)) > > I will send a v2 with

Re: [PATCH 1/2] vdpa/mlx5: Avoid unnecessary query virtqueue

2021-02-03 Thread Jason Wang
On 2021/2/4 上午7:19, Si-Wei Liu wrote: On Tue, Feb 2, 2021 at 9:16 PM Jason Wang wrote: On 2021/2/3 上午1:54, Si-Wei Liu wrote: On Tue, Feb 2, 2021 at 1:23 AM Eli Cohen wrote: On Tue, Feb 02, 2021 at 12:38:51AM -0800, Si-Wei Liu wrote: Thanks Eli and Jason for clarifications. See inline. O

Re: [PATCHv17 bpf-next 0/6] xdp: add a new helper for dev map multicast support

2021-02-03 Thread John Fastabend
Hangbin Liu wrote: > Hi Daniel, Alexei, > > It has been one week after Maciej, Toke, John's review/ack. What should > I do to make a progress for this patch set? > Patchwork is usually the first place to check: https://patchwork.kernel.org/project/netdevbpf/list/?series=421095&state=* Looks l

Re: [net-next] selftests/tls: fix selftest with CHACHA20-POLY1305

2021-02-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 3 Feb 2021 23:37:14 +0300 you wrote: > TLS selftests were broken also because of use of structure that > was not exported to UAPI. Fix by defining the union in tests. > > Fixes: 3502bd9b5762 (selftests/tls: fix selftes

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-03 Thread Steven Rostedt
On Tue, 2 Feb 2021 19:09:44 -0800 Ivan Babrou wrote: > On Thu, Jan 28, 2021 at 7:35 PM Ivan Babrou wrote: > > > > Hello, > > > > We've noticed the following regression in Linux 5.10 branch: > > > > [ 128.367231][C0] > > == > >

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-03 Thread Josh Poimboeuf
On Wed, Feb 03, 2021 at 04:52:42PM -0800, Ivan Babrou wrote: > We also have the following stack that doesn't touch any crypto: > > * https://gist.github.com/bobrik/40e2559add2f0b26ae39da30dc451f1e Can you also run this through decode_stacktrace.sh? Both are useful (until I submit a fix for decod

Re: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c

2021-02-03 Thread Bhaskar Chowdhury
On 18:09 Wed 03 Feb 2021, Randy Dunlap wrote: On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote: s/initialsation/initialisation/ s/specifiing/specifying/ Plus get rid of few blank lines. Signed-off-by: Bhaskar Chowdhury --- Changes from V1: Fix typo in the subject line Give explanation of all

Re: [PATCH net-next 0/4] chelsio: improve PCI VPD handling

2021-02-03 Thread Jakub Kicinski
On Tue, 2 Feb 2021 21:34:49 +0100 Heiner Kallweit wrote: > Working on PCI VPD core code I came across the Chelsio drivers. > Let's improve the way how they handle PCI VPD. > > This series touches only device-specific quirks in the core code, > therefore I think it should go via the netdev tree. R

Re: [PATCH net-next 1/4] PCI/VPD: Remove Chelsio T3 quirk

2021-02-03 Thread Jakub Kicinski
On Tue, 2 Feb 2021 21:35:55 +0100 Heiner Kallweit wrote: > cxgb3 driver doesn't use the PCI core code for VPD access, it has its own > implementation. Therefore we don't need a quirk for it in the core code. > > Signed-off-by: Heiner Kallweit Would this not affect the size of the file under sysf

Re: [PATCH net-next] seg6: fool-proof the processing of SRv6 behavior attributes

2021-02-03 Thread Andrea Mayer
Hi David, thanks for your time. On Wed, 3 Feb 2021 08:59:40 -0700 David Ahern wrote: > On 2/2/21 11:56 AM, Andrea Mayer wrote: > > diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c > > index b07f7c1c82a4..7cc50d506902 100644 > > --- a/net/ipv6/seg6_local.c > > +++ b/net/ipv6/seg6_local.

Re: [PATCH net-next] cxgb4: Add new T6 PCI device id 0x6092

2021-02-03 Thread Jakub Kicinski
On Tue, 2 Feb 2021 23:55:11 +0530 Raju Rangoju wrote: > Signed-off-by: Raju Rangoju Does this device require any code which only exists in net-next? Pure device id patches are okay for net.

Re: [PATCH net] net: psample: Fix the netlink skb length

2021-02-03 Thread Jakub Kicinski
On Wed, 3 Feb 2021 11:10:28 +0800 Chris Mi wrote: > Currently, the netlink skb length only includes metadata and data > length. It doesn't include the psample generic netlink header length. But what's the bug? Did you see oversized messages on the socket? Did one of the nla_put() fail? > Fixes:

Re: [PATCH net-next v2] netlink: add tracepoint at NL_SET_ERR_MSG

2021-02-03 Thread David Ahern
On 2/3/21 6:48 PM, Marcelo Ricardo Leitner wrote: > From: Marcelo Ricardo Leitner > > Often userspace won't request the extack information, or they don't log it > because of log level or so, and even when they do, sometimes it's not > enough to know exactly what caused the error. > > Netlink ext

Re: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c

2021-02-03 Thread Randy Dunlap
On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote: > > s/initialsation/initialisation/ > s/specifiing/specifying/ > > Plus get rid of few blank lines. > > Signed-off-by: Bhaskar Chowdhury > --- > Changes from V1: >Fix typo in the subject line >Give explanation of all the changes in changelog t

Re: [PATCH net-next 04/15] ice: add devlink parameters to read and write minimum security revision

2021-02-03 Thread Jakub Kicinski
On Wed, 3 Feb 2021 17:34:24 -0800 Jacob Keller wrote: > On 2/3/2021 12:41 PM, Jakub Kicinski wrote: > > On Thu, 28 Jan 2021 16:43:21 -0800 Tony Nguyen wrote: > >> From: Jacob Keller > >> > >> The ice NVM flash has a security revision field for the main NVM bank > >> and the Option ROM bank. In a

Re: [PATCH net-next 4/7] net: hns3: add support for obtaining the maximum frame length

2021-02-03 Thread Huazhong Tan
On 2021/2/4 8:56, Jakub Kicinski wrote: On Tue, 2 Feb 2021 20:39:50 +0800 Huazhong Tan wrote: From: Yufeng Mo Since the newer hardware may supports different frame size, so add support to obtain the capability from the firmware instead of the fixed value. Signed-off-by: Yufeng Mo Signed-of

Re: [PATCH net-next v2] netlink: add tracepoint at NL_SET_ERR_MSG

2021-02-03 Thread Marcelo Ricardo Leitner
On Wed, Feb 03, 2021 at 10:48:16PM -0300, Marcelo Ricardo Leitner wrote: > From: Marcelo Ricardo Leitner > > Often userspace won't request the extack information, or they don't log it > because of log level or so, and even when they do, sometimes it's not > enough to know exactly what caused the

Re: [PATCH 0/2] chelsio: cxgb: Use threaded interrupts for deferred work

2021-02-03 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 2 Feb 2021 18:01:02 +0100 you wrote: > Patch #2 fixes an issue in which del_timer_sync() and tasklet_kill() is > invoked from the interrupt handler. This is probably a rare error case > since it disables interrupt

Re: [PATCH v2,net-next,0/3] Support for OcteonTX2 98xx CPT block.

2021-02-03 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 2 Feb 2021 20:57:06 +0530 you wrote: > OcteonTX2 series of silicons have multiple variants, the > 98xx variant has two crypto (CPT) blocks to double the crypto > performance. This patchset adds support for new CPT

[PATCH net-next v2] netlink: add tracepoint at NL_SET_ERR_MSG

2021-02-03 Thread Marcelo Ricardo Leitner
From: Marcelo Ricardo Leitner Often userspace won't request the extack information, or they don't log it because of log level or so, and even when they do, sometimes it's not enough to know exactly what caused the error. Netlink extack is the standard way of reporting erros with descriptive erro

Re: [PATCH iproute2-next v3 1/5] Add kernel headers

2021-02-03 Thread David Ahern
On 2/2/21 3:35 AM, Parav Pandit wrote: > Add kernel headers to commit from kernel tree [1]. >79991caf5202c7 ("vdpa_sim_net: Add support for user supported devices") > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git branch: > linux-next > Thinking about this flow a bit mo

Re: [PATCH net-next 04/15] ice: add devlink parameters to read and write minimum security revision

2021-02-03 Thread Jacob Keller
On 2/3/2021 12:41 PM, Jakub Kicinski wrote: > On Thu, 28 Jan 2021 16:43:21 -0800 Tony Nguyen wrote: >> From: Jacob Keller >> >> The ice NVM flash has a security revision field for the main NVM bank >> and the Option ROM bank. In addition to the revision within the module, >> the device also has

linux-next: build failure after merge of the net-next tree

2021-02-03 Thread Stephen Rothwell
pv4_mtu" [vmlinux] is a static EXPORT_SYMBOL ERROR: modpost: "ip6_mtu" [vmlinux] is a static EXPORT_SYMBOL Caused by commits f67fbeaebdc0 ("net: use indirect call helpers for dst_mtu") bbd807dfbf20 ("net: indirect call helpers for ipv4/ipv6 dst_check functions&q

Re: [PATCH net-next] net: mscc: ocelot: fix error handling bugs in mscc_ocelot_init_ports()

2021-02-03 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 2 Feb 2021 12:12:38 +0300 you wrote: > There are several error handling bugs in mscc_ocelot_init_ports(). I > went through the code, and carefully audited it and made fixes and > cleanups. > > 1) The ocelot_probe

Re: [PATCH v2] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-02-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 2 Feb 2021 15:32:39 +0100 you wrote: > The mdio_bus reset code first de-asserted the reset by allocating with > GPIOD_OUT_LOW, then asserted and de-asserted again. In other words, if > the reset signal defaulted to

[PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c

2021-02-03 Thread Bhaskar Chowdhury
s/initialsation/initialisation/ s/specifiing/specifying/ Plus get rid of few blank lines. Signed-off-by: Bhaskar Chowdhury --- Changes from V1: Fix typo in the subject line Give explanation of all the changes in changelog text drivers/net/ethernet/i825xx/ether1.c | 9 +++-- 1 file

[PATCH net v2] net: ipa: set error code in gsi_channel_setup()

2021-02-03 Thread Alex Elder
In gsi_channel_setup(), we check to see if the configuration data contains any information about channels that are not supported by the hardware. If one is found, we abort the setup process, but the error code (ret) is not set in this case. Fix this bug. Fixes: 650d1603825d8 ("soc: qcom: ipa: th

Re: [PATCH net-next 4/7] net: hns3: add support for obtaining the maximum frame length

2021-02-03 Thread Jakub Kicinski
On Tue, 2 Feb 2021 20:39:50 +0800 Huazhong Tan wrote: > From: Yufeng Mo > > Since the newer hardware may supports different frame size, > so add support to obtain the capability from the firmware > instead of the fixed value. > > Signed-off-by: Yufeng Mo > Signed-off-by: Huazhong Tan > @@ -96

Re: [PATCH v2] rt2x00: remove duplicate word and fix typo in comment

2021-02-03 Thread Randy Dunlap
On 2/3/21 4:51 PM, samirweng1979 wrote: > From: wengjianfeng > > remove duplicate word 'we' in comment > change 'then' to 'than' in comment > > Signed-off-by: wengjianfeng Acked-by: Randy Dunlap Thanks. > --- > drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +- > 1 file changed, 1 i

RE: [PATCH net-next v1 2/6] lan743x: support rx multi-buffer packets

2021-02-03 Thread Bryan.Whitehead
> On Wed, Feb 3, 2021 at 3:14 PM wrote: > > > > We can test on x86 PC. We will just need about a week after you release > your next version. > > > > That's great. If you have any suggestions on how I can improve testing on my > end, feel free to reach out. If you are able, in addition to basic r

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-03 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 4:17 PM Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 03:30:35PM -0800, Ivan Babrou wrote: > > > > > Can you recreate with this patch, and add "unwind_debug" to the > > > > > cmdline? > > > > > It will spit out a bunch of stack data. > > > > > > > > Here's the three I'm

[PATCH v2] rt2x00: remove duplicate word and fix typo in comment

2021-02-03 Thread samirweng1979
From: wengjianfeng remove duplicate word 'we' in comment change 'then' to 'than' in comment Signed-off-by: wengjianfeng --- drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c b

[PATCH net-next 08/15] igc: Remove unused local receiver mask

2021-02-03 Thread Tony Nguyen
From: Sasha Neftin Local receiver mask SR_1000T_LOCAL_RX_STATUS not in use in i225 device and could be removed Signed-off-by: Sasha Neftin Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_defines.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/

Re: [PATCH net-next 2/7] net: hns3: RSS indirection table and key use device specifications

2021-02-03 Thread Jakub Kicinski
On Tue, 2 Feb 2021 20:39:48 +0800 Huazhong Tan wrote: > struct hclgevf_rss_cfg { > - u8 rss_hash_key[HCLGEVF_RSS_KEY_SIZE]; /* user configured hash keys */ > + /* user configured hash keys */ > + u8 rss_hash_key[HCLGEVF_RSS_KEY_SIZE_MAX]; > u32 hash_algo; > u32 rss_size;

[PATCH net-next 03/15] igc: Remove MULR mask define

2021-02-03 Thread Tony Nguyen
From: Sasha Neftin Multiple Tx Data Read Requests is hardware pipeline feature and is not controlled by software Signed-off-by: Sasha Neftin Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_defines.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/inte

[PATCH net-next 10/15] igc: Fix TDBAL register show incorrect value

2021-02-03 Thread Tony Nguyen
From: Sasha Neftin Fixed a typo which caused the registers dump function to read the RDBAL register when printing TDBAL register values. _reg_dump method has been partially derived from i210 and have same typo. Suggested-by: Gal Hammer Signed-off-by: Sasha Neftin Signed-off-by: Tony Nguyen --

[PATCH net-next 15/15] e1000: drop unneeded assignment in e1000_set_itr()

2021-02-03 Thread Tony Nguyen
From: Sudip Mukherjee The variable 'current_itr' is assigned to 0 before jumping to 'set_itr_now' but it has not been used after the jump. So, remove the unneeded assignment. Signed-off-by: Sudip Mukherjee Reviewed-by: Lukas Bulwahn Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/e

[PATCH net-next 06/15] igc: Expose the gPHY firmware version

2021-02-03 Thread Tony Nguyen
From: Sasha Neftin Extend reporting of NVM image version to include the gPHY (i225 PHY) firmware version. Signed-off-by: Sasha Neftin Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc.h | 2 +- drivers/net/ethernet/intel/igc/igc_ethtool.c | 9 +++-- drivers/net/e

[PATCH net-next 07/15] igc: Prefer strscpy over strlcpy

2021-02-03 Thread Tony Nguyen
From: Sasha Neftin Use the strscpy method instead of strlcpy method. See: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr _i_uTL=v6a6g1ouzcprm...@mail.gmail.com/ Signed-off-by: Sasha Neftin Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +- 1 file chan

[PATCH net-next 13/15] igb: remove h from printk format specifier

2021-02-03 Thread Tony Nguyen
From: Tom Rix This change fixes the checkpatch warning described in this commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[

[PATCH net-next 05/15] igc: Expose the NVM version

2021-02-03 Thread Tony Nguyen
From: Sasha Neftin Expose the NVM map version via drvinfo in ethtool NVM image version is reported as firmware version for i225 device Minor typo fix - remove space Signed-off-by: Sasha Neftin Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc.h | 2 ++ drivers/net/eth

[PATCH net-next 12/15] igb: Enable RSS for Intel I211 Ethernet Controller

2021-02-03 Thread Tony Nguyen
From: Nick Lowe The Intel I211 Ethernet Controller supports 2 Receive Side Scaling (RSS) queues. It should not be excluded from having this feature enabled. Via commit c883de9fd787 ("igb: rename igb define to be more generic") E1000_MRQC_ENABLE_RSS_4Q was renamed to E1000_MRQC_ENABLE_RSS_MQ to i

[PATCH net-next 14/15] e1000e: remove the redundant value assignment in e1000_update_nvm_checksum_spt

2021-02-03 Thread Tony Nguyen
From: Kaixu Xia Both of the statements are value assignment of the variable act_offset. The first value assignment is overwritten by the second and is useless. Remove it. Reported-by: Tosk Robot Signed-off-by: Kaixu Xia Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/e1000e/ich8lan

[PATCH net-next 11/15] igb: fix TDBAL register show incorrect value

2021-02-03 Thread Tony Nguyen
From: Gal Hammer Fixed a typo which caused the registers dump function to read the RDBAL register when printing TDBAL register values. Signed-off-by: Gal Hammer Tested-by: David Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 inserti

[PATCH net-next 01/15] igc: Clean up nvm_operations structure

2021-02-03 Thread Tony Nguyen
From: Sasha Neftin valid_led_default function pointer not in use and can be removed from nvm_operations structure. Signed-off-by: Sasha Neftin Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_hw.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i

[PATCH net-next 04/15] igc: Add Host Good Packets Transmitted Count

2021-02-03 Thread Tony Nguyen
From: Sasha Neftin This counter counts the number of good (non-erred) packets transmitted sent by the host. A good transmit packet is considered one that is 64 or more bytes in length (from through , inclusively) in length Signed-off-by: Sasha Neftin Signed-off-by: Tony Nguyen --- drivers/ne

[PATCH net-next 09/15] igc: Remove unused FUNC_1 mask

2021-02-03 Thread Tony Nguyen
From: Sasha Neftin FUNC_1 mask not in use in i225 device and could be removed Signed-off-by: Sasha Neftin Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_defines.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/

[PATCH net-next 02/15] igc: Remove igc_set_fw_version comment

2021-02-03 Thread Tony Nguyen
From: Sasha Neftin i225 device not supported and do not plan to support configuration of fw version string for ethtool Signed-off-by: Sasha Neftin Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/etherne

[PATCH net-next 00/15][pull request] 1GbE Intel Wired LAN Driver Updates 2021-02-03

2021-02-03 Thread Tony Nguyen
This series contains updates to igc, igb, e1000e, and e1000 drivers. Sasha adds counting of good transmit packets and reporting of NVM version and gPHY version in ethtool firmware version. Replaces the use of strlcpy to the preferred strscpy. Fixes a typo that caused the wrong register to be outpu

Re: [PATCH] net/qrtr: restrict user-controlled length in qrtr_tun_write_iter()

2021-02-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Feb 2021 15:20:59 +0600 you wrote: > syzbot found WARNING in qrtr_tun_write_iter [1] when write_iter length > exceeds KMALLOC_MAX_SIZE causing order >= MAX_ORDER condition. > > Additionally, there is no check for 0 l

Re: [PATCH 2/4] batman-adv: Update copyright years for 2021

2021-02-03 Thread Randy Dunlap
On 2/3/21 4:35 PM, Jakub Kicinski wrote: > On Tue, 2 Feb 2021 18:40:34 +0100 Simon Wunderlich wrote: >> From: Sven Eckelmann >> >> Signed-off-by: Sven Eckelmann >> Signed-off-by: Simon Wunderlich >> --- >> include/uapi/linux/batadv_packet.h | 2 +- >> include/uapi/linux/batman_adv.h

Re: [PATCH 2/4] batman-adv: Update copyright years for 2021

2021-02-03 Thread Jakub Kicinski
On Tue, 2 Feb 2021 18:40:34 +0100 Simon Wunderlich wrote: > From: Sven Eckelmann > > Signed-off-by: Sven Eckelmann > Signed-off-by: Simon Wunderlich > --- > include/uapi/linux/batadv_packet.h | 2 +- > include/uapi/linux/batman_adv.h| 2 +- > net/batman-adv/Kconfig

Re: [PATCH] rt2x00: remove duplicate word in comment

2021-02-03 Thread Randy Dunlap
On 2/3/21 4:30 PM, wengjianfeng wrote: > On Wed, 3 Feb 2021 07:16:17 -0800 > Randy Dunlap wrote: > >> On 2/2/21 10:38 PM, samirweng1979 wrote: >>> From: wengjianfeng >>> >>> remove duplicate word 'we' in comment >>> >>> Signed-off-by: wengjianfeng >>> --- >>> drivers/net/wireless/ralink/rt2x00

Re: [PATCH 1/4] batman-adv: Start new development cycle

2021-02-03 Thread Jakub Kicinski
On Tue, 2 Feb 2021 18:40:33 +0100 Simon Wunderlich wrote: > Signed-off-by: Simon Wunderlich > --- > net/batman-adv/main.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h > index 288201630ceb..2486efe4ffa6 100644 > --- a/net/

  1   2   3   4   >