Hi Jesse, On Thu, 4 Feb 2021 at 00:16, Jesse Brandeburg <jesse.brandeb...@intel.com> wrote: > > Loic Poulain wrote: > > > When device side MTU is larger than host side MTU, the packets > > (typically rmnet packets) are split over multiple MHI transfers. > > In that case, fragments must be re-aggregated to recover the packet > > before forwarding to upper layer. > > > > A fragmented packet result in -EOVERFLOW MHI transaction status for > > each of its fragments, except the final one. Such transfer was > > previously considered as error and fragments were simply dropped. > > > > This change adds re-aggregation mechanism using skb chaining, via > > skb frag_list. > > > > A warning (once) is printed since this behavior usually comes from > > a misconfiguration of the device (e.g. modem MTU). > > > > Signed-off-by: Loic Poulain <loic.poul...@linaro.org> > > --- > > v2: use zero-copy skb chaining instead of skb_copy_expand. > > v3: Fix nit in commit msg + remove misleading inline comment for frag_list > > v4: no change > > apologies for the nit, can you please fix the spelling of aggregation in > the subject?
I will, anyway I need to change that since it is not de-aggregation but re-aggregation of fragmented packets. Thanks Loic