Hi Jakub,
On Thu, 4 Feb 2021 at 00:08, Jakub Kicinski <k...@kernel.org> wrote:
>
> Please put the maintainers or the list thru which you expect the patch
> to be applied in the To: field of your emails.
>
> On Mon, 1 Feb 2021 22:05:40 +0100 Loic Poulain wrote:
> > + if (proto && proto->tx_fixup) {
> > + skb = proto->tx_fixup(mhi_netdev, skb);
> > + if (unlikely(!skb))
> > + goto exit_drop;
> > + }
>
> > @@ -170,7 +193,11 @@ static void mhi_net_dl_callback(struct mhi_device
> > *mhi_dev,
> > }
> >
> > skb_put(skb, mhi_res->bytes_xferd);
> > - netif_rx(skb);
> > +
> > + if (proto && proto->rx_fixup)
> > + proto->rx_fixup(mhi_netdev, skb);
> > + else
> > + netif_rx(skb);
> > }
>
> There us a slight asymmetry between tx_fixup and rx_fixup.
> tx_fixup just massages the frame and then mhi_net still takes
> care of transmission. On Rx side rx_fixup actually does the
> netif_rx(skb). Maybe s/rx_fixup/rx/ ?
Yes, that makes sense.
Loic
