On Fri, 30 Aug 2019 12:08:28 +, Igor Russkikh wrote:
> Here is a set of various bug fixes related to vlan filter offload and
> two other rare cases.
LGTM, Fixes tag should had been first there on patch 4.
You should also perhaps check the return value from
napi_complete_done() as an optimizat
On Fri, 30 Aug 2019 05:39:43 -0500, Parav Pandit wrote:
> Two minor cleanup in devlink.
>
> Patch-1 Explicitly defines devlink port index as unsigned int
> Patch-2 Uses switch-case to handle different port flavours attributes
Always nice to see one's comment addressed, even if it takes a while :)
On Fri, 30 Aug 2019 13:20:40 +0300, Ioana Radulescu wrote:
> Recent firmware versions offer access to more DPNI statistics
> counters. Add the relevant ones to ethtool interface stats.
>
> Also we can now make use of a new counter for in flight egress frames
> to avoid sleeping an arbitrary amount
On Fri, 30 Aug 2019 00:42:02 -0700, Sudarsana Reddy Kalluru wrote:
> The patch series adds couple of enhancements to qed/qede drivers.
> - Support for dumping the config id attributes via ethtool -w/W.
> - Support for dumping the GRC data of required memory regions using
> ethtool -w/W inte
On 2019/8/30 17:32, Eric Dumazet wrote:
On 8/30/19 10:35 AM, Zhu Yanjun wrote:
When testing with a background iperf pushing 1Gbit/sec traffic and running
both ifconfig and netstat to collect statistics, some deadlocks occurred.
This is quite a heavy patch trying to fix a bug...
This is to
fseeko(.., 0, SEEK_SET) on a memstream just puts the buffer pointer
to the beginning so when we call fflush on it we get some garbage
log data from the previous test. Let's manually set terminating
byte to zero at the reported buffer size.
To show the issue consider the following snippet:
Copy-paste error from CHECK.
Fixes: d38835b75f67 ("selftests/bpf: test_progs: remove global fail/success
counts")
Signed-off-by: Stanislav Fomichev
---
tools/testing/selftests/bpf/test_progs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_p
On 8/30/19 12:14 PM, Donald Sharp wrote:
> diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
> index 4c81846ccce8..c7e94edae482 100644
> --- a/include/net/ip_fib.h
> +++ b/include/net/ip_fib.h
> @@ -513,7 +513,7 @@ int ip_valid_fib_dump_req(struct net *net, const struct
> nlmsghdr *nlh,
>
+ acct mgr, Stephen
> Prashant Malani 於 2019年8月31日 上午6:24 寫道：
>
> (Adding a few more Realtek folks)
>
> Friendly ping. Any thoughts / feedback, Realtek folks (and others) ?
>
>> On Thu, Aug 29, 2019 at 11:40 AM Prashant Malani
>> wrote:
>>
>> Hi,
>>
>> The r8152 driver source code distri
From: Pablo Neira Ayuso
Date: Fri, 30 Aug 2019 14:06:59 +0200
> The following patchset contains Netfilter fixes for net:
>
> 1) Spurious warning when loading rules using the physdev match,
>from Todd Seidelmann.
>
> 2) Fix FTP conntrack helper debugging output, from Thomas Jarosch.
>
> 3)
From: Daniel Borkmann
Date: Sat, 31 Aug 2019 01:40:06 +0200
> The following pull-request contains BPF updates for your *net* tree.
>
> The main changes are:
>
> 1) Fix 32-bit zero-extension during constant blinding which
>has been causing a regression on ppc64, from Naveen.
>
> 2) Fix a la
From: Michael Chan
Date: Fri, 30 Aug 2019 19:10:38 -0400
> Add a new function bnxt_get_registered_vfs() to handle the work
> of getting the number of registered VFs under #ifdef CONFIG_BNXT_SRIOV.
> The main code will call this function and will always work correctly
> whether CONFIG_BNXT_SRIOV i
On 8/29/19 4:18 PM, Jakub Kicinski wrote:
On Thu, 29 Aug 2019 11:27:16 -0700, Shannon Nelson wrote:
+netdev_tx_t ionic_start_xmit(struct sk_buff *skb, struct net_device *netdev)
+{
+ u16 queue_index = skb_get_queue_mapping(skb);
+ struct ionic_lif *lif = netdev_priv(netdev);
+
Hi David,
The following pull-request contains BPF updates for your *net* tree.
The main changes are:
1) Fix 32-bit zero-extension during constant blinding which
has been causing a regression on ppc64, from Naveen.
2) Fix a latency bug in nfp driver when updating stack index
register, from
On 8/27/19 4:25 AM, Kevin Laatz wrote:
This patch set adds the ability to use unaligned chunks in the XDP umem.
Currently, all chunk addresses passed to the umem are masked to be chunk
size aligned (max is PAGE_SIZE). This limits where we can place chunks
within the umem as well as limiting the
On 8/28/19 1:46 AM, Petar Penkov wrote:
From: Petar Penkov
If a SYN cookie is not issued by tcp_v#_gen_syncookie, then the return
value will be exactly 0, rather than <= 0. Let's change the check to
reflect that, especially since mss is an unsigned value and cannot be
negative.
Fixes: 70d66244
On 8/28/19 7:36 AM, Jakub Kicinski wrote:
Hi!
This set adds a small batching and cache mechanism to the driver.
Map dumps require two operations per element - get next, and
lookup. Each of those needs a round trip to the device, and on
a loaded system scheduling out and in of the dumping process
On 8/30/19 1:00 PM, Quentin Monnet wrote:
Hi,
This set attempts to make it easier to build bpftool, in particular when
passing a specific output directory. This is a follow-up to the
conversation held last month by Lorenz, Ilya and Jakub [0].
The first patch is a minor fix to bpftool's Makefile,
On 8/30/19 3:17 PM, David Miller wrote:
From: Jakub Kicinski
Date: Fri, 30 Aug 2019 15:16:04 -0700
On Fri, 30 Aug 2019 12:31:07 -0700, Shannon Nelson wrote:
On 8/29/19 3:52 PM, Jakub Kicinski wrote:
On Thu, 29 Aug 2019 11:27:08 -0700, Shannon Nelson wrote:
+static void ionic_lif_qcq_deinit(
Add a new function bnxt_get_registered_vfs() to handle the work
of getting the number of registered VFs under #ifdef CONFIG_BNXT_SRIOV.
The main code will call this function and will always work correctly
whether CONFIG_BNXT_SRIOV is set or not.
Fixes: 230d1f0de754 ("bnxt_en: Handle firmware reset
On Fri, 30 Aug 2019 12:25:49 +0200, Davide Caratti wrote:
> When an application configures kernel TLS on top of a TCP socket, it's
> now possible for inet_diag_handler() to collect information regarding the
> protocol version, the cipher type and TX / RX configuration, in case
> INET_DIAG_INFO is r
On 8/30/19 2:35 PM, Jakub Kicinski wrote:
> On Fri, 30 Aug 2019 07:25:54 +, Yonghong Song wrote:
>> On 8/29/19 11:39 AM, Jakub Kicinski wrote:
>>> On Wed, 28 Aug 2019 23:45:02 -0700, Yonghong Song wrote:
Brian Vazquez has proposed BPF_MAP_DUMP command to look up more than one
map en
On Fri, 30 Aug 2019 11:07:10 +0200, Pablo Neira Ayuso wrote:
> > > * The front-end coalesces consecutive pedit actions into one single
> > > word, so drivers can mangle IPv6 and ethernet address fields in one
> > > single go.
> >
> > You still only coalesce up to 16 bytes, no?
>
> You onl
Vladimir Oltean writes:
> taprio_init may fail earlier than this line:
>
> list_add(&q->taprio_list, &taprio_list);
>
> i.e. due to the net device not being multi queue.
>
> Attempting to remove q from the global taprio_list when it is not part
> of it will result in a kernel panic.
>
> Fix
On Fri, 30 Aug 2019 13:11:11 +0300, Vladimir Oltean wrote:
> On Fri, 30 Aug 2019 at 04:21, Jakub Kicinski wrote:
> > On Fri, 30 Aug 2019 03:46:20 +0300, Vladimir Oltean wrote:
> > > - Configuring the switch over SPI cannot apparently be done from this
> > > ndo_setup_tc callback because it runs
On Fri, 30 Aug 2019 14:36:23 -0700, Shannon Nelson wrote:
> On 8/29/19 4:37 PM, Jakub Kicinski wrote:
> > On Thu, 29 Aug 2019 11:27:17 -0700, Shannon Nelson wrote:
> >> When the netdev gets a new name from userland, pass that name
> >> down to the NIC for internal tracking.
> >>
> >> Signed-off-b
On 8/30/19 2:10 PM, Jakub Kicinski wrote:
> On Fri, 30 Aug 2019 20:55:33 +, Yonghong Song wrote:
>>> I guess you can hold off this series a bit and discuss it at LPC,
>>> you have a talk dedicated to that :-) (and afaiu, you are all going)
>>
>> Absolutely. We will have a discussion on map ba
(Adding a few more Realtek folks)
Friendly ping. Any thoughts / feedback, Realtek folks (and others) ?
On Thu, Aug 29, 2019 at 11:40 AM Prashant Malani wrote:
>
> Hi,
>
> The r8152 driver source code distributed by Realtek (on
> www.realtek.com) contains firmware patches. This involves binary
>
On Fri, 30 Aug 2019 14:44:24 -0700, Shannon Nelson wrote:
> On 8/29/19 4:33 PM, Jakub Kicinski wrote:
> > On Thu, 29 Aug 2019 11:27:16 -0700, Shannon Nelson wrote:
> [...]
> > There's definitely a function for helping drivers which can't do full
> > TSO slice up the packet, but I can't find it
From: Jakub Kicinski
Date: Fri, 30 Aug 2019 15:16:04 -0700
> On Fri, 30 Aug 2019 12:31:07 -0700, Shannon Nelson wrote:
>> On 8/29/19 3:52 PM, Jakub Kicinski wrote:
>> > On Thu, 29 Aug 2019 11:27:08 -0700, Shannon Nelson wrote:
>> >> +static void ionic_lif_qcq_deinit(struct ionic_lif *lif, struc
On Fri, 30 Aug 2019 14:25:12 -0700, Shannon Nelson wrote:
> On 8/29/19 4:10 PM, Jakub Kicinski wrote:
> > On Thu, 29 Aug 2019 11:27:15 -0700, Shannon Nelson wrote:
> >> +static int ionic_get_module_eeprom(struct net_device *netdev,
> >> + struct ethtool_eeprom *ee,
> >
On Fri, 30 Aug 2019 12:31:07 -0700, Shannon Nelson wrote:
> On 8/29/19 3:52 PM, Jakub Kicinski wrote:
> > On Thu, 29 Aug 2019 11:27:08 -0700, Shannon Nelson wrote:
> >> +static void ionic_lif_qcq_deinit(struct ionic_lif *lif, struct ionic_qcq
> >> *qcq)
> >> +{
> >> + struct ionic_dev *idev = &
From: Vlad Buslov
Date: Thu, 29 Aug 2019 19:15:15 +0300
> Two fixes for my "Refactor cls hardware offload API to support
> rtnl-independent drivers" series.
Series applied, thanks Vlad.
From: Jiri Pirko
Date: Thu, 29 Aug 2019 15:38:42 +0200
> From: Jiri Pirko
>
> Implement this callback in order to get the offloaded stats added to the
> kernel stats.
>
> Reported-by: Pengfei Liu
> Signed-off-by: Jiri Pirko
Applied.
From: Luke Hsiao
Date: Thu, 29 Aug 2019 10:02:44 -0400
> From: Luke Hsiao
>
> This explicitly clarifies that bbr_bdp() returns the rounded-up value of
> the bandwidth-delay product and why in the comments.
>
> Signed-off-by: Luke Hsiao
> Acked-by: Soheil Hassas Yeganeh
> Acked-by: Neal Cardw
> On 8/22/19 5:02 PM, Ben Wei wrote:
> > This patch extends ncsi-netlink command line utility to send NC-SI command
> > to kernel driver
> > via NCSI_CMD_SEND_CMD command.
> >
> > New command line option -o (opcode) is used to specify NC-SI command and
> > optional payload.
> >
>
> Thank you fo
On Thu, Aug 29, 2019 at 3:45 AM Michal Kubecek wrote:
> On Tue, Aug 27, 2019 at 04:47:04PM -0400, Paul Moore wrote:
> >
> > I'm also not a big fan of inserting the hook in rtnl_fill_ifinfo(); as
> > presented it is way too specific for a LSM hook for me to be happy.
> > However, I do agree that gi
On 8/29/19 4:33 PM, Jakub Kicinski wrote:
On Thu, 29 Aug 2019 11:27:16 -0700, Shannon Nelson wrote:
+static int ionic_tx_tso(struct ionic_queue *q, struct sk_buff *skb)
+{
+ struct ionic_tx_stats *stats = q_to_tx_stats(q);
+ struct ionic_desc_info *abort = q->head;
+ struct dev
On 8/29/19 4:37 PM, Jakub Kicinski wrote:
On Thu, 29 Aug 2019 11:27:17 -0700, Shannon Nelson wrote:
When the netdev gets a new name from userland, pass that name
down to the NIC for internal tracking.
Signed-off-by: Shannon Nelson
There is a precedent in ACPI for telling the FW what OS is run
On Fri, 30 Aug 2019 07:25:54 +, Yonghong Song wrote:
> On 8/29/19 11:39 AM, Jakub Kicinski wrote:
> > On Wed, 28 Aug 2019 23:45:02 -0700, Yonghong Song wrote:
> >> Brian Vazquez has proposed BPF_MAP_DUMP command to look up more than one
> >> map entries per syscall.
> >>
> >> https://lore
On 8/22/19 5:02 PM, Ben Wei wrote:
This patch extends ncsi-netlink command line utility to send NC-SI command to
kernel driver
via NCSI_CMD_SEND_CMD command.
New command line option -o (opcode) is used to specify NC-SI command and
optional payload.
Thank you for posting this Ben.
Something
Le 30/08/2019 à 18:51, Davide Caratti a écrit :
> the following tdc test fails on Fedora:
>
> # ./tdc.py -e 2638
> -- ns/SubPlugin.__init__
> Test 2638: Add matchall and try to get it
> -> prepare stage *** Could not execute: "$TC qdisc add dev $DEV1 clsact"
> -> prepare stage *** Er
On 8/29/19 4:10 PM, Jakub Kicinski wrote:
On Thu, 29 Aug 2019 11:27:15 -0700, Shannon Nelson wrote:
+static int ionic_get_module_eeprom(struct net_device *netdev,
+ struct ethtool_eeprom *ee,
+ u8 *data)
+{
+ struct ionic_li
From: Subash Abhinov Kasiviswanathan
Date: Wed, 28 Aug 2019 21:26:54 -0600
> Reserved ports may have some special use cases which are not suitable
> for use by general userspace applications. Currently, ports specified
> in ip_local_reserved_ports will not be returned only in case of
> automatic
On 08/30, Yonghong Song wrote:
>
>
> On 8/30/19 1:15 PM, Stanislav Fomichev wrote:
> > On 08/29, Jakub Kicinski wrote:
> >> On Thu, 29 Aug 2019 16:13:59 -0700, Brian Vazquez wrote:
> We need a per-map implementation of the exec side, but roughly maps
> would do:
>
> L
From: Vinicius Costa Gomes
Date: Wed, 28 Aug 2019 10:36:15 -0700
> When removing a cbs instance when offloading is enabled, the crash
> below can be observed. Also, the current code doesn't handle correctly
> the case when offload is disabled without removing the qdisc: if the
> link speed change
On Fri, 30 Aug 2019 20:55:33 +, Yonghong Song wrote:
> > I guess you can hold off this series a bit and discuss it at LPC,
> > you have a talk dedicated to that :-) (and afaiu, you are all going)
>
> Absolutely. We will have a discussion on map batching and I signed
> on with that :-)
FWIW
This looks bogus.
Whatever layer tries to access dev refcnt after free_netdev() has been
called is buggy.
I would rather trap early and fix the root cause.
Untested patch :
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index b5d28dadf964..8080f1305417 100644
--- a/include/
From: Michael Chan
Date: Thu, 29 Aug 2019 23:54:43 -0400
> This patchset implements adapter health and error recovery. The status
> is reported through several devlink reporters and the driver will
> initiate and complete the recovery process using the devlink infrastructure.
>
> v2: Added 4 pa
Leonardo Bras wrote:
> A kernel panic can happen if a host has disabled IPv6 on boot and have to
> process guest packets (coming from a bridge) using it's ip6tables.
>
> IPv6 packets need to be dropped if the IPv6 module is not loaded.
>
> Signed-off-by: Leonardo Bras
> ---
> net/bridge/br_net
On 8/30/19 1:15 PM, Stanislav Fomichev wrote:
> On 08/29, Jakub Kicinski wrote:
>> On Thu, 29 Aug 2019 16:13:59 -0700, Brian Vazquez wrote:
We need a per-map implementation of the exec side, but roughly maps
would do:
LIST_HEAD(deleted);
for entry i
On Fri, Aug 30, 2019 at 4:54 AM Eric Dumazet wrote:
>
>
>
> On 8/29/19 9:26 PM, Willem de Bruijn wrote:
>
> > SO_REUSEPORT was not intended to be used in this way. Opening
> > multiple connected sockets with the same local port.
> >
> > But since the interface allowed connect after joining a group
On 08/29, Jakub Kicinski wrote:
> On Thu, 29 Aug 2019 16:13:59 -0700, Brian Vazquez wrote:
> > > We need a per-map implementation of the exec side, but roughly maps
> > > would do:
> > >
> > > LIST_HEAD(deleted);
> > >
> > > for entry in map {
> > > struct map_op_ctx
On 8/29/19 4:06 PM, Jakub Kicinski wrote:
On Thu, 29 Aug 2019 11:27:13 -0700, Shannon Nelson wrote:
@@ -588,8 +866,26 @@ static int ionic_set_features(struct net_device *netdev,
static int ionic_set_mac_address(struct net_device *netdev, void *sa)
{
- netdev_info(netdev, "%s: stubb
On 8/29/19 3:52 PM, Jakub Kicinski wrote:
On Thu, 29 Aug 2019 11:27:08 -0700, Shannon Nelson wrote:
+static void ionic_lif_qcq_deinit(struct ionic_lif *lif, struct ionic_qcq *qcq)
+{
+ struct ionic_dev *idev = &lif->ionic->idev;
+ struct device *dev = lif->ionic->dev;
+
+ if (!
On 8/29/19 3:46 PM, Jakub Kicinski wrote:
On Thu, 29 Aug 2019 11:27:05 -0700, Shannon Nelson wrote:
The port management commands apply to the physical port
associated with the PCI device, which might be shared among
several logical interfaces.
Signed-off-by: Shannon Nelson
---
drivers/net/et
ATTENTION SIR BENEFICIARY SIR / MA
YOU HAVE BEEN COMPENSATE BY THE UN WORLD BANK ORGANIZATION WITH THE SUM OF
$850.000.00 USD ONLY,
I AM WAITING TO HEAR FROM YOU SO THAT YOU WILL RECEIVE YOUR COMPENSATION FUNDS
$850.000.00 USD ONLY FROM UN WORLD BANK ORGANIZATION AND MORE DETAILS CONTACT
ME T
On 8/29/19 3:38 PM, Jakub Kicinski wrote:
On Thu, 29 Aug 2019 11:27:03 -0700, Shannon Nelson wrote:
This patch adds a basic driver framework for the Pensando IONIC
network device. There is no functionality right now other than
the ability to load and unload.
Signed-off-by: Shannon Nelson
diff
When creating a v4 route that uses a v6 nexthop from a nexthop group.
Allow the kernel to properly send the nexthop as v6 via the RTA_VIA
attribute.
Broken behavior:
$ ip nexthop add via fe80::9 dev eth0
$ ip nexthop show
id 1 via fe80::9 dev eth0 scope link
$ ip route add 4.5.6.7/32 nhid 1
$ ip
Hi Michael,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-health-and-error-recovery/20190830-164635
config: x86_64-randconfig-f001-201934 (attached as .config)
compiler: gcc-7
Hi Vladimir,
On Fri, 30 Aug 2019 03:53:25 +0300, Vladimir Oltean wrote:
> The bridge core assumes that enabling/disabling vlan_filtering will
> translate into the simple toggling of a flag for switchdev drivers.
>
> That is clearly not the case for sja1105, which alters the VLAN table
> and the
Hi Rob,
See Documentation/devicetree/bindings/net/dsa/dsa.txt for a list
of additional
required, optional properties and how the integrated switch subnodes must
be specified.
@@ -94,3 +130,185 @@ Example:
};
};
};
+
+Example 2: MT7621: Port 4 i
Fri, Aug 30, 2019 at 04:47:41PM CEST, dsah...@gmail.com wrote:
>On 8/30/19 8:35 AM, Roopa Prabhu wrote:
>> On Wed, Aug 28, 2019 at 10:26 PM Michal Kubecek wrote:
>>>
>>> On Wed, Aug 28, 2019 at 09:36:41PM -0700, Roopa Prabhu wrote:
yes, correct. I mentioned that because I was wondering
Fri, Aug 30, 2019 at 04:35:23PM CEST, ro...@cumulusnetworks.com wrote:
>On Wed, Aug 28, 2019 at 10:26 PM Michal Kubecek wrote:
>>
>> On Wed, Aug 28, 2019 at 09:36:41PM -0700, Roopa Prabhu wrote:
>> >
>> > yes, correct. I mentioned that because I was wondering if we can
>> > think along the same l
the following tdc test fails on Fedora:
# ./tdc.py -e 2638
-- ns/SubPlugin.__init__
Test 2638: Add matchall and try to get it
-> prepare stage *** Could not execute: "$TC qdisc add dev $DEV1 clsact"
-> prepare stage *** Error message: "/bin/sh: ip: command not found"
returncode 127;
On Fri, Aug 30, 2019 at 2:18 AM Leon Romanovsky wrote:
>
> On Mon, Aug 26, 2019 at 09:00:45AM +0300, Leon Romanovsky wrote:
> > On Sun, Aug 25, 2019 at 11:54:54PM -0400, Michael Chan wrote:
> > > Refactor the hardware/firmware configuration portion in
> > > bnxt_sriov_enable() into a new function
> On 27.08.2019 14:08, Josh Boyer wrote:
> > On Mon, Aug 26, 2019 at 6:23 PM Heiner Kallweit
> wrote:
> >>
> >> This adds firmware rtl8125a-3 for Realtek's 2.5Gbps chip RTL8125.
> >>
> >> Signed-off-by: Heiner Kallweit
> >> ---
> >> Firmware file was provided by Realtek and they asked me to submi
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> This patch set adds the ability to use unaligned chunks in the XDP umem.
Thanks, Kevin for your hard work and perseverance on this patch set!
--
Jonathan
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> The addition of unaligned chunks mode, the documentation needs to be
> updated to indicate that the incoming addr to the fill ring will only be
> masked if the user application is run in the aligned chunk mode. This patch
> also adds a line to expl
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> This patch modifies xdpsock to use mmap instead of posix_memalign. With
> this change, we can use hugepages when running the application in unaligned
> chunks mode. Using hugepages makes it more likely that we have physically
> contiguous memory, w
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> This patch adds buffer recycling support for unaligned buffers. Since we
> don't mask the addr to 2k at umem_reg in unaligned mode, we need to make
> sure we give back the correct (original) addr to the fill queue. We achieve
> this using the new d
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> This patch adds support for the unaligned chunks mode. The addition of the
> unaligned chunks option will allow users to run the application with more
> relaxed chunk placement in the XDP umem.
>
> Unaligned chunks mode can be used with the '-u' or
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> This patch adds a 'flags' field to the umem_config and umem_reg structs.
> This will allow for more options to be added for configuring umems.
>
> The first use for the flags field is to add a flag for unaligned chunks
> mode. These flags can eithe
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> From: Maxim Mikityanskiy
>
> Relax the requirements to the XSK frame size to allow it to be smaller
> than a page and even not a power of two. The current implementation can
> work in this mode, both with Striding RQ and without it.
>
> The code t
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> With the addition of the unaligned chunks option, we need to make sure we
> handle the offsets accordingly based on the mode we are currently running
> in. This patch modifies the driver to appropriately mask the address for
> each case.
>
> Signed
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> With the addition of the unaligned chunks option, we need to make sure we
> handle the offsets accordingly based on the mode we are currently running
> in. This patch modifies the driver to appropriately mask the address for
> each case.
>
> Signed
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> With the addition of the unaligned chunks option, we need to make sure we
> handle the offsets accordingly based on the mode we are currently running
> in. This patch modifies the driver to appropriately mask the address for
> each case.
>
> Signed
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> Currently, addresses are chunk size aligned. This means, we are very
> restricted in terms of where we can place chunk within the umem. For
> example, if we have a chunk size of 2k, then our chunks can only be placed
> at 0,2k,4k,6k,8k... and so on
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> Currently, the dma, addr and handle are modified when we reuse Rx buffers
> in zero-copy mode. However, this is not required as the inputs to the
> function are copies, not the original values themselves. As we use the
> copies within the function, we
On 26 Aug 2019, at 19:25, Kevin Laatz wrote:
> Currently, the dma, addr and handle are modified when we reuse Rx buffers
> in zero-copy mode. However, this is not required as the inputs to the
> function are copies, not the original values themselves. As we use the
> copies within the function,
On Fri 30 Aug 2019 at 03:53, Pablo Neira Ayuso wrote:
> The flow mangle action is originally modeled after the tc pedit action,
> this has a number of shortcomings:
>
> 1) The tc pedit offset must be set on the 32-bits boundaries. Many
>protocol header field offsets are not aligned to 32-bit
On Fri, Aug 30, 2019 at 10:28 PM Jesper Dangaard Brouer
wrote:
>
> On Thu, 29 Aug 2019 05:42:42 +0900
> "Daniel T. Lee" wrote:
>
> > This commit adds CIDR parsing and IP validate helper function to parse
> > single IP or range of IP with CIDR. (e.g. 198.18.0.0/15)
> >
> > Helpers will be used in
Le 29/08/2019 à 19:30, Alexei Starovoitov a écrit :
[snip]
> These are the links that showing that k8 can delegates caps.
> Are you saying that you know of folks who specifically
> delegate cap_sys_admin and cap_net_admin _only_ to a container to run bpf in
> there?
>
Yes, we need cap_sys_admin o
On Fri, Aug 30, 2019 at 07:35:23AM -0700, Roopa Prabhu wrote:
> On Wed, Aug 28, 2019 at 10:26 PM Michal Kubecek wrote:
> >
> > On Wed, Aug 28, 2019 at 09:36:41PM -0700, Roopa Prabhu wrote:
> > >
> > > yes, correct. I mentioned that because I was wondering if we can
> > > think along the same line
On 8/30/19 8:35 AM, Roopa Prabhu wrote:
> On Wed, Aug 28, 2019 at 10:26 PM Michal Kubecek wrote:
>>
>> On Wed, Aug 28, 2019 at 09:36:41PM -0700, Roopa Prabhu wrote:
>>>
>>> yes, correct. I mentioned that because I was wondering if we can
>>> think along the same lines for this API.
>>> eg
>>> (a)
On Wed, Aug 28, 2019 at 10:26 PM Michal Kubecek wrote:
>
> On Wed, Aug 28, 2019 at 09:36:41PM -0700, Roopa Prabhu wrote:
> >
> > yes, correct. I mentioned that because I was wondering if we can
> > think along the same lines for this API.
> > eg
> > (a) RTM_NEWLINK always replaces the list attrib
On Thu, 29 Aug 2019 05:42:42 +0900
"Daniel T. Lee" wrote:
> This commit adds CIDR parsing and IP validate helper function to parse
> single IP or range of IP with CIDR. (e.g. 198.18.0.0/15)
>
> Helpers will be used in prior to set target address in samples/pktgen.
>
> Signed-off-by: Daniel T. L
On Thu, 29 Aug 2019 05:42:41 +0900
"Daniel T. Lee" wrote:
> This commit changes variable names that can cause confusion.
>
> For example, variable DST_MIN is quite confusing since the
> keyword 'udp_dst_min' and keyword 'dst_min' is used with pg_ctrl.
>
> On the following commit, 'dst_min' will
Here is a set of various bug fixes related to vlan filter offload and
two other rare cases.
Dmitry Bogdanov (4):
net: aquantia: fix removal of vlan 0
net: aquantia: fix limit of vlan filters
net: aquantia: reapply vlan filters on up
net: aquantia: fix out of memory condition on rx side
Ig
From: Dmitry Bogdanov
On embedded environments with hard memory limits it is a normal although
rare case when skb can't be allocated on rx part under high traffic.
In such OOM cases napi_complete_done() was not called.
So the napi object became in an invalid state like it is "scheduled".
Kernel
Declaring threaded irq handler should also indicate the irq is
oneshot. It is oneshot indeed, because HW implements irq automasking
on trigger.
Not declaring this causes some kernel configurations to fail
on interface up, because request_threaded_irq returned an err code.
The issue was originally
From: Dmitry Bogdanov
Fix a limit condition of vlans on the interface before setting vlan
promiscuous mode
Fixes: 48dd73d08d4dd ("net: aquantia: fix vlans not working over bridged
network")
Signed-off-by: Dmitry Bogdanov
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/aquantia/atlantic
From: Dmitry Bogdanov
In case of device reconfiguration the driver may reset the device invisible
for other modules, vlan module in particular. So vlans will not be
removed&created and vlan filters will not be configured in the device.
The patch reapplies the vlan filters at device start.
Fixes:
From: Dmitry Bogdanov
Due to absence of checking against the rx flow rule when vlan 0 is being
removed, the other rule could be removed instead of the rule with vlan 0
Fixes: 7975d2aff5afb ("net: aquantia: add support of rx-vlan-filter offload")
Signed-off-by: Dmitry Bogdanov
Signed-off-by: Igo
From: Florian Westphal
When I merged the extension sysctl tables with the main one I forgot to
reset them on netns creation. They currently read/write init_net settings.
Fixes: d912dec12428 ("netfilter: conntrack: merge acct and helper sysctl table
with main one")
Fixes: cb2833ed0044 ("netfilt
From: Florian Westphal
If 'fq' qdisc is used and a program has requested timestamps,
skb->tstamp needs to be cleared, else fq will treat these as
'transmit time'.
Signed-off-by: Florian Westphal
Signed-off-by: Pablo Neira Ayuso
---
net/netfilter/nf_flow_table_ip.c | 3 ++-
1 file changed, 2 i
From: Todd Seidelmann
Simplify the check in physdev_mt_check() to emit an error message
only when passed an invalid chain (ie, NF_INET_LOCAL_OUT).
This avoids cluttering up the log with errors against valid rules.
For large/heavily modified rulesets, current behavior can quickly
overwhelm the ri
From: wenxu
Get the vlan_proto of ingress bridge in network byteorder as userspace
expects. Otherwise this is inconsistent with NFT_META_PROTOCOL.
Fixes: 2a3a93ef0ba5 ("netfilter: nft_meta_bridge: Add NFT_META_BRI_IIFVPROTO
support")
Signed-off-by: wenxu
Signed-off-by: Pablo Neira Ayuso
---
From: Thomas Jarosch
The find_pattern() debug output was printing the 'skip' character.
This can be a NULL-byte and messes up further pr_debug() output.
Output without the fix:
kernel: nf_conntrack_ftp: Pattern matches!
kernel: nf_conntrack_ftp: Skipped up to `<7>nf_conntrack_ftp: find_pattern
Hi,
The following patchset contains Netfilter fixes for net:
1) Spurious warning when loading rules using the physdev match,
from Todd Seidelmann.
2) Fix FTP conntrack helper debugging output, from Thomas Jarosch.
3) Restore per-netns nf_conntrack_{acct,helper,timeout} sysctl knobs,
from
1 - 100 of 138 matches
Mail list logo
