On Fri, 30 Aug 2019 14:44:24 -0700, Shannon Nelson wrote: > On 8/29/19 4:33 PM, Jakub Kicinski wrote: > > On Thu, 29 Aug 2019 11:27:16 -0700, Shannon Nelson wrote: > [...] > > There's definitely a function for helping drivers which can't do full > > TSO slice up the packet, but I can't find it now 😫😫 > > > > Eric would definitely know. > > > > Did you have a look? Would it be useful here? > > Yes, obviously this could use some work for clarity and supportability, > and I think for performance as well. But since it works, I've been > concentrating on getting other parts of the driver working before coming > back to this. If there are some tools that can help clean this up, I > would be interested to see them.
Ha! I think I found it, can you take a look at net/core/tso.c and see if any of those help? I'm not opposed to merging as is, but at the same time I'm not volunteering to review that function..
