Hi Michael, I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-health-and-error-recovery/20190830-164635 config: x86_64-randconfig-f001-201934 (attached as .config) compiler: gcc-7 (Debian 7.4.0-11) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_fw_reset': >> drivers/net/ethernet/broadcom/bnxt/bnxt.c:10021:35: error: 'struct bnxt' has >> no member named 'sriov_cfg' if (bp->pf.registered_vfs || bp->sriov_cfg) { ^~ drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_fw_reset_task': drivers/net/ethernet/broadcom/bnxt/bnxt.c:10418:34: error: 'struct bnxt' has no member named 'sriov_cfg' if (bp->pf.registered_vfs || bp->sriov_cfg) { ^~ drivers/net/ethernet/broadcom/bnxt/bnxt.c:10425:11: error: 'struct bnxt' has no member named 'sriov_cfg' bp->sriov_cfg); ^~ vim +10021 drivers/net/ethernet/broadcom/bnxt/bnxt.c 10003 10004 void bnxt_fw_reset(struct bnxt *bp) 10005 { 10006 int rc; 10007 10008 bnxt_rtnl_lock_sp(bp); 10009 if (test_bit(BNXT_STATE_OPEN, &bp->state) && 10010 !test_bit(BNXT_STATE_IN_FW_RESET, &bp->state)) { 10011 set_bit(BNXT_STATE_IN_FW_RESET, &bp->state); 10012 if (BNXT_PF(bp) && bp->pf.active_vfs) { 10013 rc = bnxt_hwrm_func_qcfg(bp); 10014 if (rc) { 10015 netdev_err(bp->dev, "Firmware reset aborted, first func_qcfg cmd failed, rc = %d\n", 10016 rc); 10017 clear_bit(BNXT_STATE_IN_FW_RESET, &bp->state); 10018 dev_close(bp->dev); 10019 goto fw_reset_exit; 10020 } 10021 if (bp->pf.registered_vfs || bp->sriov_cfg) { 10022 u16 vf_tmo_dsecs = bp->pf.registered_vfs * 10; 10023 10024 if (bp->fw_reset_max_dsecs < vf_tmo_dsecs) 10025 bp->fw_reset_max_dsecs = vf_tmo_dsecs; 10026 bp->fw_reset_state = 10027 BNXT_FW_RESET_STATE_POLL_VF; 10028 bnxt_queue_fw_reset_work(bp, HZ / 10); 10029 goto fw_reset_exit; 10030 } 10031 } 10032 bnxt_fw_reset_close(bp); 10033 bp->fw_reset_state = BNXT_FW_RESET_STATE_ENABLE_DEV; 10034 bnxt_queue_fw_reset_work(bp, bp->fw_reset_min_dsecs * HZ / 10); 10035 } 10036 fw_reset_exit: 10037 bnxt_rtnl_unlock_sp(bp); 10038 } 10039 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
