Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-09 Thread Jiri Pirko
Fri, Aug 09, 2019 at 05:40:25PM CEST, ro...@cumulusnetworks.com wrote: >On Thu, Aug 8, 2019 at 11:25 PM Jiri Pirko wrote: >> >> Fri, Aug 09, 2019 at 06:11:30AM CEST, ro...@cumulusnetworks.com wrote: >> >On Fri, Jul 19, 2019 at 4:00 AM Jiri Pirko wrote: >> >> >> >> From: Jiri Pirko >> >> >> >> Ad

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-09 Thread Jiri Pirko
Fri, Aug 09, 2019 at 06:14:03PM CEST, dsah...@gmail.com wrote: >On 8/9/19 9:40 AM, Roopa Prabhu wrote: > diff --git a/include/uapi/linux/rtnetlink.h > b/include/uapi/linux/rtnetlink.h > index ce2a623abb75..b36cfd83eb76 100644 > --- a/include/uapi/linux/rtnetlink.h > +++ b/inclu

Re: [patch net-next] netdevsim: register couple of devlink params

2019-08-09 Thread Jiri Pirko
Fri, Aug 09, 2019 at 11:26:35PM CEST, jakub.kicin...@netronome.com wrote: >On Fri, 9 Aug 2019 13:05:12 +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Register couple of devlink params, one generic, one driver-specific. >> Make the values available over debugfs. >> >> Example: >> $ echo "111

Re: [pull request][net-next 00/15] Mellanox, mlx5 tc flow handling for concurrent execution (Part 2)

2019-08-09 Thread David Miller
From: Saeed Mahameed Date: Fri, 9 Aug 2019 22:04:17 + > This series, mostly from Vlad, is the 2nd part of 3 part series to > improve mlx5 tc flow handling by removing dependency on rtnl_lock and > providing a more fine-grained locking and rcu safe data structures to > allow tc flow handling f

Re: [PATCH net-next 1/1] tc-testing: added tdc tests for matchall filter

2019-08-09 Thread David Miller
From: Roman Mashak Date: Fri, 9 Aug 2019 18:46:40 -0400 > Signed-off-by: Roman Mashak Applied.

Re: [PATCH net] net/tls: swap sk_write_space on close

2019-08-09 Thread David Miller
From: Jakub Kicinski Date: Fri, 9 Aug 2019 18:36:23 -0700 > Now that we swap the original proto and clear the ULP pointer > on close we have to make sure no callback will try to access > the freed state. sk_write_space is not part of sk_prot, remember > to swap it. > > Reported-by: syzbot+dcdc9

Re: [PATCH net-next] selftests: Fix detection of nettest command in fcnal-test

2019-08-09 Thread David Miller
From: David Ahern Date: Fri, 9 Aug 2019 16:13:38 -0700 > From: David Ahern > > Most of the tests run by fcnal-test.sh relies on the nettest command. > Rather than trying to cover all of the individual tests, check for the > binary only at the beginning. > > Also removes the need for log_error

[PATCH net] net/tls: swap sk_write_space on close

2019-08-09 Thread Jakub Kicinski
Now that we swap the original proto and clear the ULP pointer on close we have to make sure no callback will try to access the freed state. sk_write_space is not part of sk_prot, remember to swap it. Reported-by: syzbot+dcdc9deefaec44785...@syzkaller.appspotmail.com Fixes: 95fa145479fb ("bpf: sock

[PATCH 2/2] ip nexthop: Allow flush|list operations to specify a specific protocol

2019-08-09 Thread Donald Sharp
In the case where we have a large number of nexthops from a specific protocol, allow the flush and list operations to take a protocol to limit the commands scopes. Signed-off-by: Donald Sharp --- ip/ipnexthop.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/

[PATCH 0/2] iproute2: Improve usability of `ip nexthop`

2019-08-09 Thread Donald Sharp
First patch fixes a spacing issue and the second patch allows the user to filter on the specificed protocol. Donald Sharp (2): ip nexthop: Add space to display properly when showing a group ip nexthop: Allow flush|list operations to specify a specific protocol ip/ipnexthop.c | 17 ++

[PATCH 1/2] ip nexthop: Add space to display properly when showing a group

2019-08-09 Thread Donald Sharp
When displaying a nexthop group made up of other nexthops, the display line shows this when you have additional data at the end: id 42 group 43/44/45/46/47/48/49/50/51/52/53/54/55/56/57/58/59/60/61/62/63/64/65/66/67/68/69/70/71/72/73/74proto zebra Modify code so that it shows: id 42 group 43/

Re: [PATCH v5 bpf-next] BPF: helpers: New helper to obtain namespacedata from current task

2019-08-09 Thread Yonghong Song
On 8/9/19 2:03 PM, Carlos Antonio Neira Bustos wrote: > Yonghong, > > I have splitted the patch in 2 : > > - bpf_helper introduction : > > > From 40ec0781525b82d5235c45f5066a7a79dea71065 Mon Sep 17 00:00:00 2001 > From: Carlos > Date: Fri, 9 Aug 2019 12:20:52 -0700 > Subject: [PATCH 1/2]

Re: [PATCH v3] tools: bpftool: fix reading from /proc/config.gz

2019-08-09 Thread Peter Wu
Hi all, Thanks for the lovely feedback :) On Fri, Aug 09, 2019 at 02:57:26PM -0700, Jakub Kicinski wrote: > On Fri, 9 Aug 2019 14:48:31 -0700, Stanislav Fomichev wrote: > > I'm just being nit picky :-) > > Because changelog says we already depend on -lz, but then in the patch > > we explicitly ad

[PATCH net-next] selftests: Fix detection of nettest command in fcnal-test

2019-08-09 Thread David Ahern
From: David Ahern Most of the tests run by fcnal-test.sh relies on the nettest command. Rather than trying to cover all of the individual tests, check for the binary only at the beginning. Also removes the need for log_error which is undefined. Fixes: 6f9d5cacfe07 ("selftests: Setup for functio

Re: [PATCH net-next v2 4/4] net: phy: realtek: add support for the 2.5Gbps PHY in RTL8125

2019-08-09 Thread Andrew Lunn
On Fri, Aug 09, 2019 at 09:31:32PM +0200, Heiner Kallweit wrote: > On 09.08.2019 21:18, Andrew Lunn wrote: > >> + }, { > >> + PHY_ID_MATCH_EXACT(0x001cca50), > > > > Hi Heiner > > > Hi Andrew, > > > With the Marvell driver, i looked at the range of IDs the PHYs where > > using. The swi

[PATCH net-next 6/7] net: dsa: mv88e6xxx: fix SMI bit checking

2019-08-09 Thread Vivien Didelot
The current mv88e6xxx_smi_direct_wait function is only used to check the 16th bit of the (16-bit) SMI Command register. But the bit shift operation is not enough if we eventually use this function to check other bits, thus replace it with a mask. Fixes: e7ba0fad9c53 ("net: dsa: mv88e6xxx: refine S

[PATCH net-next 3/7] net: dsa: mv88e6xxx: introduce wait bit routine

2019-08-09 Thread Vivien Didelot
Many portions of the driver need to wait until a given bit is set or cleared. Some busses even have a specific implementation for this operation. In preparation for such variant, implement a generic Wait Bit routine that can be used by the driver core functions. This allows us to get rid of the cu

[PATCH net-next 5/7] net: dsa: mv88e6xxx: remove wait and update routines

2019-08-09 Thread Vivien Didelot
Now that we have proper Wait Bit and Wait Mask routines, remove the unused mv88e6xxx_wait routine and its Global 1 and Global 2 variants. The indirect tables such as the Device Mapping Table or Priority Override Table make use of an Update bit to distinguish reading (0) from writing (1) operations

[PATCH net-next 7/7] net: dsa: mv88e6xxx: add delay in direct SMI wait

2019-08-09 Thread Vivien Didelot
The mv88e6xxx_smi_direct_wait routine is used to wait on indirect registers access. It is of no exception and must delay between read attempts, like other wait routines. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/smi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/driver

[PATCH net-next 4/7] net: dsa: mv88e6xxx: wait for AVB Busy bit

2019-08-09 Thread Vivien Didelot
The AVB is not an indirect table using an Update bit, but a unit using a Busy bit. This means that we must ensure that this bit is cleared before setting it and wait until it gets cleared again after writing an operation. Reflect that. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/

[PATCH net-next 0/7] net: dsa: mv88e6xxx: prepare Wait Bit operation

2019-08-09 Thread Vivien Didelot
The Remote Management Interface has its own implementation of a Wait Bit operation, which requires a bit number and a value to wait for. In order to prepare the introduction of this implementation, rework the code waiting for bits and masks in mv88e6xxx to match this signature. This has the benef

[PATCH net-next 2/7] net: dsa: mv88e6xxx: introduce wait mask routine

2019-08-09 Thread Vivien Didelot
The current mv88e6xxx_wait routine is used to wait for a given mask to be cleared to zero. However in some cases, the driver may have to wait for a given mask to be of a certain non-zero value. Thus provide a generic wait mask routine that will be used to implement the current mv88e6xxx_wait funct

[PATCH net-next 1/7] net: dsa: mv88e6xxx: wait for 88E6185 PPU disabled

2019-08-09 Thread Vivien Didelot
The PPU state of 88E6185 can be either "Disabled at Reset" or "Disabled after Initialization". Because we intentionally clear the PPU Enabled bit before checking its state, it is safe to wait for the MV88E6185_G1_STS_PPU_STATE_DISABLED state explicitly instead of waiting for any state different tha

[PATCH net-next 1/1] tc-testing: added tdc tests for matchall filter

2019-08-09 Thread Roman Mashak
Signed-off-by: Roman Mashak --- .../tc-testing/tc-tests/filters/matchall.json | 391 + 1 file changed, 391 insertions(+) create mode 100644 tools/testing/selftests/tc-testing/tc-tests/filters/matchall.json diff --git a/tools/testing/selftests/tc-testing/tc-tests/filter

Re: [PATCH v4 net-next 14/19] ionic: Add Tx and Rx handling

2019-08-09 Thread Shannon Nelson
On 7/25/19 4:48 PM, Saeed Mahameed wrote: On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: Add both the Tx and Rx queue setup and handling. The related stats display comes later. Instead of using the generic napi routines used by the slow-path commands, the Tx and Rx paths are simplifi

Re: [PATCH v2 net-next 2/2] net: mvpp2: support multiple comphy lanes

2019-08-09 Thread Matt Pelland
On Fri, Aug 09, 2019 at 10:32:50AM +0200, Antoine Tenart wrote: > Hello Matt, > > On Thu, Aug 08, 2019 at 07:06:06PM -0400, Matt Pelland wrote: > > > > static void mvpp2_port_enable(struct mvpp2_port *port) > > @@ -3389,7 +3412,9 @@ static void mvpp2_stop_dev(struct mvpp2_port *port) > > > >

Regression in routing table cleanup when VRF support was fixed.

2019-08-09 Thread Craig Robson
This commit caused a regression for me when using policy routing. 5a56a0b3a45d net: Don't delete routes in different VRFs The regression is that routes are no longer getting deleted when I delete IP addresses when using non-default routing tables. For example the following sequence used to delet

[net-next 03/15] net/mlx5e: Protect hairpin hash table with mutex

2019-08-09 Thread Saeed Mahameed
From: Vlad Buslov To remove dependency on rtnl lock, protect hairpin hash table from concurrent modifications with new "hairpin_tbl_lock" mutex. Signed-off-by: Vlad Buslov Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en/fs.h | 1 + .../net/e

[net-next 10/15] net/mlx5e: Protect encap hash table with mutex

2019-08-09 Thread Saeed Mahameed
From: Vlad Buslov To remove dependency on rtnl lock, protect encap hash table from concurrent modifications with new "encap_tbl_lock" mutex. Use the mutex to protect internal encap entry state from concurrent modification. This is necessary because a flow can be attached to multiple encap entries

[net-next 11/15] net/mlx5e: Allow concurrent creation of encap entries

2019-08-09 Thread Saeed Mahameed
From: Vlad Buslov Encap entries creation is fully synchronized by encap_tbl_lock. In order to allow concurrent allocation of hardware resources used to offload encapsulation, extend mlx5e_encap_entry with 'res_ready' completion. Move call to mlx5e_tc_tun_create_header_ipv{4|6}() out of encap_tbl_

[net-next 09/15] net/mlx5e: Extend encap entry with reference counter

2019-08-09 Thread Saeed Mahameed
From: Vlad Buslov List of flows attached to encap entry is used as implicit reference counter (encap entry is deallocated when list becomes free) and as a mechanism to obtain encap entry that flow is attached to (through list head). This is not safe when concurrent modification of list of flows a

[net-next 06/15] net/mlx5e: Protect mod header entry flows list with spinlock

2019-08-09 Thread Saeed Mahameed
From: Vlad Buslov To remove dependency on rtnl lock, extend mod header entry with spinlock and use it to protect list of flows attached to mod header entry from concurrent modifications. Signed-off-by: Vlad Buslov Reviewed-by: Jianbo Liu Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed -

[pull request][net-next 00/15] Mellanox, mlx5 tc flow handling for concurrent execution (Part 2)

2019-08-09 Thread Saeed Mahameed
Hi Dave, This series, mostly from Vlad, is the 2nd part of 3 part series to improve mlx5 tc flow handling by removing dependency on rtnl_lock and providing a more fine-grained locking and rcu safe data structures to allow tc flow handling for concurrent execution. In this part Vlad handles hairpi

[net-next 01/15] net/mlx5e: Extend hairpin entry with reference counter

2019-08-09 Thread Saeed Mahameed
From: Vlad Buslov List of flows attached to hairpin entry is used as implicit reference counter (hairpin entry is deallocated when list becomes free) and as a mechanism to obtain hairpin entry that flow is attached to (through list head). This is not safe when concurrent modification of list of f

[net-next 15/15] net/mlx5e: Use refcount_t for refcount

2019-08-09 Thread Saeed Mahameed
From: Chuhong Yuan refcount_t is better for reference counters since its implementation can prevent overflows. So convert atomic_t ref counters to refcount_t. Signed-off-by: Chuhong Yuan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c | 9 + 1 fil

[net-next 02/15] net/mlx5e: Protect hairpin entry flows list with spinlock

2019-08-09 Thread Saeed Mahameed
From: Vlad Buslov To remove dependency on rtnl lock, extend hairpin entry with spinlock and use it to protect list of flows attached to hairpin entry from concurrent modifications. Signed-off-by: Vlad Buslov Reviewed-by: Jianbo Liu Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- dr

[net-next 12/15] net/mlx5: E-switch, Removed unused hwid

2019-08-09 Thread Saeed Mahameed
From: Parav Pandit Currently mlx5_eswitch_rep stores same hw ID for all representors. However it is never used from this structure. It is always used from mlx5_vport. Hence, remove unused field. Signed-off-by: Parav Pandit Reviewed-by: Vu Pham Signed-off-by: Saeed Mahameed --- drivers/net/e

[net-next 08/15] net/mlx5e: Allow concurrent creation of mod_hdr entries

2019-08-09 Thread Saeed Mahameed
From: Vlad Buslov Mod_hdr entries creation is fully synchronized by mod_hdr_tbl->lock. In order to allow concurrent allocation of hardware resources used to offload header rewrite, extend mlx5e_mod_hdr_entry with 'res_ready' completion. Move call to mlx5_modify_header_alloc() out of mod_hdr_tbl->

[net-next 13/15] net/mlx5e: Simplify querying port representor parent id

2019-08-09 Thread Saeed Mahameed
From: Parav Pandit System image GUID doesn't depend on eswitch switchdev mode. Hence, remove the check which simplifies the code. Signed-off-by: Parav Pandit Reviewed-by: Vu Pham Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 16 +++- 1 file

[net-next 14/15] net/mlx5e: Use vhca_id in generating representor port_index

2019-08-09 Thread Saeed Mahameed
From: Parav Pandit It is desired to use unique port indices when multiple pci devices' devlink instance have the same switch-id. Make use of vhca-id to generate such unique devlink port indices. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core

[net-next 04/15] net/mlx5e: Allow concurrent creation of hairpin entries

2019-08-09 Thread Saeed Mahameed
From: Vlad Buslov Hairpin entries creation is fully synchronized by hairpin_tbl_lock. In order to allow concurrent initialization of mlx5e_hairpin structure instances and provisioning of hairpin entries to hardware, extend mlx5e_hairpin_entry with 'res_ready' completion. Move call to mlx5e_hairpi

[net-next 05/15] net/mlx5e: Extend mod header entry with reference counter

2019-08-09 Thread Saeed Mahameed
From: Vlad Buslov List of flows attached to mod header entry is used as implicit reference counter (mod header entry is deallocated when list becomes free) and as a mechanism to obtain mod header entry that flow is attached to (through list head). This is not safe when concurrent modification of

[net-next 07/15] net/mlx5e: Protect mod_hdr hash table with mutex

2019-08-09 Thread Saeed Mahameed
From: Vlad Buslov To remove dependency on rtnl lock, protect mod_hdr hash table from concurrent modifications with new mutex. Implement helper function to get flow namespace to prevent code duplication. Signed-off-by: Vlad Buslov Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- .../

Re: [PATCH v3] tools: bpftool: fix reading from /proc/config.gz

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 14:48:31 -0700, Stanislav Fomichev wrote: > I'm just being nit picky :-) > Because changelog says we already depend on -lz, but then in the patch > we explicitly add it. > > I think you were right in pointing out that we already implicitly depend > on -lz via -lelf and/or -lbfd.

Re: [PATCH v3] tools: bpftool: fix reading from /proc/config.gz

2019-08-09 Thread Stanislav Fomichev
On 08/09, Jakub Kicinski wrote: > On Fri, 9 Aug 2019 08:32:10 -0700, Stanislav Fomichev wrote: > > On 08/09, Peter Wu wrote: > > > /proc/config has never existed as far as I can see, but /proc/config.gz > > > is present on Arch Linux. Add support for decompressing config.gz using > > > zlib which i

Re: [v4,0/4] tools: bpftool: add net attach/detach command to attach XDP prog

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 22:32:44 +0900, Daniel T. Lee wrote: > Currently, bpftool net only supports dumping progs attached on the > interface. To attach XDP prog on interface, user must use other tool > (eg. iproute2). By this patch, with `bpftool net attach/detach`, user > can attach/detach XDP prog o

Re: [patch net-next] netdevsim: register couple of devlink params

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 13:05:12 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Register couple of devlink params, one generic, one driver-specific. > Make the values available over debugfs. > > Example: > $ echo "111" > /sys/bus/netdevsim/new_device > $ devlink dev param > netdevsim/netdevsim111:

Re: [net-next 01/15] ice: Implement ethtool ops for channels

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 11:31:25 -0700, Jeff Kirsher wrote: > From: Henry Tieman > > Add code to query and set the number of queues on the primary > VSI for a PF. This is accessed from the 'ethtool -l' and 'ethtool -L' > commands, respectively. > > Signed-off-by: Henry Tieman > Signed-off-by: Tony

Re: [PATCH v3] tools: bpftool: fix reading from /proc/config.gz

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 08:32:10 -0700, Stanislav Fomichev wrote: > On 08/09, Peter Wu wrote: > > /proc/config has never existed as far as I can see, but /proc/config.gz > > is present on Arch Linux. Add support for decompressing config.gz using > > zlib which is a mandatory dependency of libelf. Replac

Re: [PATCH v5 bpf-next] BPF: helpers: New helper to obtain namespacedata from current task

2019-08-09 Thread Carlos Antonio Neira Bustos
Yonghong, I have splitted the patch in 2 : - bpf_helper introduction : >From 40ec0781525b82d5235c45f5066a7a79dea71065 Mon Sep 17 00:00:00 2001 From: Carlos Date: Fri, 9 Aug 2019 12:20:52 -0700 Subject: [PATCH 1/2] [PATCH v8 bpf-next 1/2] BPF: New helper to obtain namespace data from current

[PATCH net-next] r8169: inline rtl8169_free_rx_databuff

2019-08-09 Thread Heiner Kallweit
rtl8169_free_rx_databuff is used in only one place, so let's inline it. We can improve the loop because rtl8169_init_ring zero's RX_databuff before calling rtl8169_rx_fill, and rtl8169_rx_fill fills Rx_databuff starting from index 0. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realte

Re: [PATCH net-next] r8169: fix performance issue on RTL8168evl

2019-08-09 Thread David Miller
From: Heiner Kallweit Date: Fri, 9 Aug 2019 00:02:40 +0200 > From: Holger Hoffstätte > Disabling TSO but leaving SG active results is a significant > performance drop. Therefore disable also SG on RTL8168evl. > This restores the original performance. > > Fixes: 93681cd7d94f ("r8169: enable HW c

Re: [pull request][net 00/12] Mellanox, mlx5 fixes 2019-08-08

2019-08-09 Thread David Miller
From: Saeed Mahameed Date: Thu, 8 Aug 2019 20:21:58 + > This series introduces some fixes to mlx5 driver. > > Highlights: > 1) From Tariq, Critical mlx5 kTLS fixes to better align with hw specs. > 2) From Aya, Fixes to mlx5 tx devlink health reporter. > 3) From Maxim, aRFs parsing to use flo

Re: [PATCH net-next] r8169: make use of xmit_more

2019-08-09 Thread Heiner Kallweit
On 09.08.2019 10:52, Holger Hoffstätte wrote: > On 8/9/19 10:25 AM, Eric Dumazet wrote: > (snip) >>> >>> So that didn't take long - got another timeout this morning during some >>> random light usage, despite sg/tso being disabled this time. >>> Again the only common element is the xmit_more patch.

Re: [net v2] ixgbe: fix possible deadlock in ixgbe_service_task()

2019-08-09 Thread David Miller
From: Jeff Kirsher Date: Thu, 8 Aug 2019 09:37:56 -0700 > From: Taehee Yoo > > ixgbe_service_task() calls unregister_netdev() under rtnl_lock(). > But unregister_netdev() internally calls rtnl_lock(). > So deadlock would occur. > > Fixes: 59dd45d550c5 ("ixgbe: firmware recovery mode") > Signe

Re: [PATCH net v2 0/2] Fix collisions in socket cookie generation

2019-08-09 Thread David Miller
From: Daniel Borkmann Date: Thu, 8 Aug 2019 13:57:24 +0200 > This change makes the socket cookie generator as a global counter > instead of per netns in order to fix cookie collisions for BPF use > cases we ran into. See main patch #1 for more details. > > Given the change is small/trivial and

Re: [PATCH v2 2/2] tcp: Update TCP_BASE_MSS comment

2019-08-09 Thread David Miller
From: Josh Hunt Date: Wed, 7 Aug 2019 19:52:30 -0400 > TCP_BASE_MSS is used as the default initial MSS value when MTU probing is > enabled. Update the comment to reflect this. > > Suggested-by: Neal Cardwell > Signed-off-by: Josh Hunt Applied.

Re: [PATCH v2 1/2] tcp: add new tcp_mtu_probe_floor sysctl

2019-08-09 Thread David Miller
From: Josh Hunt Date: Wed, 7 Aug 2019 19:52:29 -0400 > The current implementation of TCP MTU probing can considerably > underestimate the MTU on lossy connections allowing the MSS to get down to > 48. We have found that in almost all of these cases on our networks these > paths can handle much l

Re: tcan4x5x on a Raspberry Pi

2019-08-09 Thread Wolfgang Grandegger
Hello Konstantin, m 09.08.19 um 18:46 schrieb FIXED-TERM Buecheler Konstantin (ETAS-SEC/ECT-Mu): > >> Konstantin > >>> On 7/29/19 6:19 AM, FIXED-TERM Buecheler Konstantin (ETAS-SEC/ECT-Mu) wrote: >>> Hi all, >>> >>> I am currently working on a project where I am trying to use the tcan4550 >>> c

Re: [PATCH 0/2 net,v4] flow_offload hardware priority fixes

2019-08-09 Thread David Miller
From: David Miller Date: Fri, 09 Aug 2019 12:37:41 -0700 (PDT) > From: Pablo Neira Ayuso > Date: Tue, 6 Aug 2019 18:03:08 +0200 > >> This patchset contains two updates for the flow_offload users: >> >> 1) Pass the major tc priority to drivers so they do not have to >>lshift it. This is a

Re: [PATCH net-next 04/12] net: stmmac: Add Split Header support and enable it in XGMAC cores

2019-08-09 Thread David Miller
From: Jose Abreu Date: Fri, 9 Aug 2019 20:36:12 +0200 > Add the support for Split Header feature in the RX path and enable it in > XGMAC cores. > > Signed-off-by: Jose Abreu Well, what is the performance advantage/disadvantage of this mode? Show some numbers please to justify the use of the

Re: [PATCH net-next 01/12] net: stmmac: Get correct timestamp values from XGMAC

2019-08-09 Thread David Miller
From: Jose Abreu Date: Fri, 9 Aug 2019 20:36:09 +0200 > + void __iomem *ioaddr = hw->pcsr; > + int count = 0; > + u32 value; > + > + do { > + if (readl_poll_timeout_atomic(ioaddr + XGMAC_TIMESTAMP_STATUS, > + value, value & XG

Re: [PATCH 0/2 net,v4] flow_offload hardware priority fixes

2019-08-09 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 6 Aug 2019 18:03:08 +0200 > This patchset contains two updates for the flow_offload users: > > 1) Pass the major tc priority to drivers so they do not have to >lshift it. This is a preparation patch for the fix coming in >patch #2. > > 2) Set the hard

Re: [PATCH net-next v2 4/4] net: phy: realtek: add support for the 2.5Gbps PHY in RTL8125

2019-08-09 Thread Heiner Kallweit
On 09.08.2019 21:18, Andrew Lunn wrote: >> +}, { >> +PHY_ID_MATCH_EXACT(0x001cca50), > > Hi Heiner > Hi Andrew, > With the Marvell driver, i looked at the range of IDs the PHYs where > using. The switch, being MDIO based, also has ID values. The PHY range > and the switch range a

Re: Clause 73 and USXGMII

2019-08-09 Thread Russell King - ARM Linux admin
On Fri, Aug 09, 2019 at 06:42:39PM +, Jose Abreu wrote: > From: Russell King - ARM Linux admin > Date: Aug/08/2019, 13:09:03 (UTC+00:00) > > > On Thu, Aug 08, 2019 at 11:45:29AM +, Jose Abreu wrote: > > > From: Russell King - ARM Linux admin > > > Date: Aug/08/2019, 10:23:13 (UTC+00:00)

Re: [PATCH net-next v2 4/4] net: phy: realtek: add support for the 2.5Gbps PHY in RTL8125

2019-08-09 Thread Andrew Lunn
> + }, { > + PHY_ID_MATCH_EXACT(0x001cca50), Hi Heiner With the Marvell driver, i looked at the range of IDs the PHYs where using. The switch, being MDIO based, also has ID values. The PHY range and the switch range are well separated, and it seems unlikely Marvell would reuse a s

Re: [PATCH net-next] gso: enable udp gso for virtual devices

2019-08-09 Thread Willem de Bruijn
On Fri, Aug 9, 2019 at 2:58 PM Josh Hunt wrote: > > On 6/26/19 4:41 PM, Willem de Bruijn wrote: > > On Wed, Jun 26, 2019 at 3:17 PM Jason Baron wrote: > >> > >> > >> > >> On 6/14/19 4:53 PM, Jason Baron wrote: > >>> > >>> > >>> On 6/13/19 5:20 PM, Willem de Bruijn wrote: > >>> @@ -237,6 +237,

Re: [PATCH net-next v2 3/4] net: phy: add phy_modify_paged_changed

2019-08-09 Thread Andrew Lunn
On Fri, Aug 09, 2019 at 08:44:22PM +0200, Heiner Kallweit wrote: > Add helper function phy_modify_paged_changed, behavios is the same > as for phy_modify_changed. > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v2 1/4] net: phy: simplify genphy_config_advert by using the linkmode_adv_to_xxx_t functions

2019-08-09 Thread Andrew Lunn
On Fri, Aug 09, 2019 at 08:43:04PM +0200, Heiner Kallweit wrote: > Using linkmode_adv_to_mii_adv_t and linkmode_adv_to_mii_ctrl1000_t > allows to simplify the code. In addition avoiding the conversion to > the legacy u32 advertisement format allows to remove the warning. > > Signed-off-by: Heiner

Re: [net 01/12] net/mlx5e: Use flow keys dissector to parse packets for ARFS

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 18:49:50 +, Saeed Mahameed wrote: > On Thu, 2019-08-08 at 18:15 -0700, Jakub Kicinski wrote: > > On Thu, 8 Aug 2019 20:22:00 +, Saeed Mahameed wrote: > > > From: Maxim Mikityanskiy > > > > > > The current ARFS code relies on certain fields to be set in the SKB > > > (

Re: [PATCH net-next] gso: enable udp gso for virtual devices

2019-08-09 Thread Josh Hunt
On 6/26/19 4:41 PM, Willem de Bruijn wrote: On Wed, Jun 26, 2019 at 3:17 PM Jason Baron wrote: On 6/14/19 4:53 PM, Jason Baron wrote: On 6/13/19 5:20 PM, Willem de Bruijn wrote: @@ -237,6 +237,7 @@ static inline int find_next_netdev_feature(u64 feature, unsigned long start)

Re: [net 01/12] net/mlx5e: Use flow keys dissector to parse packets for ARFS

2019-08-09 Thread Saeed Mahameed
On Thu, 2019-08-08 at 18:15 -0700, Jakub Kicinski wrote: > On Thu, 8 Aug 2019 20:22:00 +, Saeed Mahameed wrote: > > From: Maxim Mikityanskiy > > > > The current ARFS code relies on certain fields to be set in the SKB > > (e.g. transport_header) and extracts IP addresses and ports by > > custo

Re: [PATCH 3/3] tipc: fix issue of calling smp_processor_id() in preemptible

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 15:16:57 +0800, Ying Xue wrote: > Fixes: e9c1a793210f ("tipc: add dst_cache support for udp media") > syzbot+1a68504d96cd17b33...@syzkaller.appspotmail.com ^ Reported-by: missing here? > Signed-off-by: Hillf Danton > Signed-off-by: Ying Xue

Re: [PATCH bpf-next v5 0/6] xdp: Add devmap_hash map type

2019-08-09 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Thu, 8 Aug 2019 12:57:05 -0700 > Y Song wrote: > >> On Thu, Aug 8, 2019 at 12:43 PM Toke Høiland-Jørgensen >> wrote: >> > >> > Alexei Starovoitov writes: >> > >> > > On Fri, Jul 26, 2019 at 9:06 AM Toke Høiland-Jørgensen >> > > wrote: >> > >> >> > >>

[PATCH net-next v2 2/4] net: phy: prepare phylib to deal with PHY's extending Clause 22

2019-08-09 Thread Heiner Kallweit
The integrated PHY in 2.5Gbps chip RTL8125 is the first (known to me) PHY that uses standard Clause 22 for all modes up to 1Gbps and adds 2.5Gbps control using vendor-specific registers. To use phylib for the standard part little extensions are needed: - Move most of genphy_config_aneg to a new fun

[PATCH net-next v2 4/4] net: phy: realtek: add support for the 2.5Gbps PHY in RTL8125

2019-08-09 Thread Heiner Kallweit
This adds support for the integrated 2.5Gbps PHY in Realtek RTL8125. Advertisement of 2.5Gbps mode is done via a vendor-specific register. Same applies to reading NBase-T link partner advertisement. Unfortunately this 2.5Gbps PHY shares the PHY ID with the integrated 1Gbps PHY's in other Realtek ne

[PATCH net-next v2 3/4] net: phy: add phy_modify_paged_changed

2019-08-09 Thread Heiner Kallweit
Add helper function phy_modify_paged_changed, behavios is the same as for phy_modify_changed. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy-core.c | 29 - include/linux/phy.h| 2 ++ 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a/driv

[PATCH net-next v2 1/4] net: phy: simplify genphy_config_advert by using the linkmode_adv_to_xxx_t functions

2019-08-09 Thread Heiner Kallweit
Using linkmode_adv_to_mii_adv_t and linkmode_adv_to_mii_ctrl1000_t allows to simplify the code. In addition avoiding the conversion to the legacy u32 advertisement format allows to remove the warning. Signed-off-by: Heiner Kallweit Suggested-by: Andrew Lunn --- Changes in v2: - added to series -

Re: [PATCH v2 2/2] tcp: Update TCP_BASE_MSS comment

2019-08-09 Thread Josh Hunt
On 8/9/19 11:43 AM, David Miller wrote: From: Josh Hunt Date: Fri, 9 Aug 2019 11:38:05 -0700 I forgot to tag these at net-next. Do I need to resubmit a v3 with net-next in the subject? No need. Thanks

Re: [PATCH v2 2/2] tcp: Update TCP_BASE_MSS comment

2019-08-09 Thread David Miller
From: Josh Hunt Date: Fri, 9 Aug 2019 11:38:05 -0700 > I forgot to tag these at net-next. Do I need to resubmit a v3 with > net-next in the subject? No need.

RE: Clause 73 and USXGMII

2019-08-09 Thread Jose Abreu
From: Russell King - ARM Linux admin Date: Aug/08/2019, 13:09:03 (UTC+00:00) > On Thu, Aug 08, 2019 at 11:45:29AM +, Jose Abreu wrote: > > From: Russell King - ARM Linux admin > > Date: Aug/08/2019, 10:23:13 (UTC+00:00) > > > > > On Thu, Aug 08, 2019 at 09:02:57AM +, Jose Abreu wrote: >

[PATCH net-next v2 0/4] net: phy: realtek: add support for integrated 2.5Gbps PHY in RTL8125

2019-08-09 Thread Heiner Kallweit
This series adds support for the integrated 2.5Gbps PHY in RTL8125. First three patches add necessary functionality to phylib. Changes in v2: - added patch 1 - changed patch 4 to use a fake PHY ID that is injected by the network driver. This allows to use a dedicated PHY driver. Heiner Kallweit

Re: [PATCH v2 2/2] tcp: Update TCP_BASE_MSS comment

2019-08-09 Thread Josh Hunt
On 8/7/19 11:13 PM, Eric Dumazet wrote: On 8/8/19 1:52 AM, Josh Hunt wrote: TCP_BASE_MSS is used as the default initial MSS value when MTU probing is enabled. Update the comment to reflect this. Suggested-by: Neal Cardwell Signed-off-by: Josh Hunt --- Signed-off-by: Eric Dumazet Dave

[PATCH net-next 12/12] net: stmmac: selftests: Add selftest for VLAN TX Offload

2019-08-09 Thread Jose Abreu
Add 2 new selftests for VLAN Insertion offloading. Tests are for inner and outer VLAN offloading. Signed-off-by: Jose Abreu --- .../net/ethernet/stmicro/stmmac/stmmac_selftests.c | 96 +- 1 file changed, 94 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmi

[PATCH net-next 02/12] net: stmmac: Prepare to add Split Header support

2019-08-09 Thread Jose Abreu
In order to add Split Header support, stmmac_rx() needs to take into account that packet may be split accross multiple descriptors. Refactor the logic of this function in order to support this scenario. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 6 + dri

[PATCH net-next 11/12] net: stmmac: Add support for VLAN Insertion Offload

2019-08-09 Thread Jose Abreu
Adds the logic to insert a given VLAN ID in a packet. This is offloaded to HW and its descriptor based. For now, only XGMAC implements the necessary callbacks. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/common.h | 8 drivers/net/ethernet/stmicro/stmmac/dwxgmac2

[PATCH net-next 06/12] net: stmmac: dwxgmac: Add Flexible PPS support

2019-08-09 Thread Jose Abreu
Add the support for Flexible PPS in XGMAC cores. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 19 .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c| 56 ++ 2 files changed, 75 insertions(+) diff --git a/drivers/net/ethernet/st

[PATCH net-next 10/12] net: stmmac: xgmac: Add EEE support

2019-08-09 Thread Jose Abreu
Add support for EEE in XGMAC cores by implementing the necessary callbacks. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 12 .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c| 75 -- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma

[PATCH net-next 04/12] net: stmmac: Add Split Header support and enable it in XGMAC cores

2019-08-09 Thread Jose Abreu
Add the support for Split Header feature in the RX path and enable it in XGMAC cores. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/common.h | 1 + drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 6 ++ .../net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 18 +

[PATCH net-next 09/12] net: stmmac: selftests: Add tests for SA Insertion/Replacement

2019-08-09 Thread Jose Abreu
Add 4 new tests: - SA Insertion (register based) - SA Insertion (descriptor based) - SA Replacament (register based) - SA Replacement (descriptor based) Signed-off-by: Jose Abreu --- .../net/ethernet/stmicro/stmmac/stmmac_selftests.c | 98 +- 1

[PATCH net-next 07/12] net: stmmac: Add ethtool register dump for XGMAC cores

2019-08-09 Thread Jose Abreu
Add the ethtool interface to dump the register map in XGMAC cores. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 ++ .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c| 11 +- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 10 - .../

[PATCH net-next 00/12] net: stmmac: Improvements for -next

2019-08-09 Thread Jose Abreu
Couple of improvements for -next tree. More info in commit logs. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: netdev@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-

[PATCH net-next 08/12] net: stmmac: Add support for SA Insertion/Replacement in XGMAC cores

2019-08-09 Thread Jose Abreu
Add the support for Source Address Insertion and Replacement in XGMAC cores. Two methods are supported: Descriptor based and register based. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 ++ drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 11 +

[PATCH net-next 05/12] net: stmmac: Add a counter for Split Header packets

2019-08-09 Thread Jose Abreu
Add a counter that increments each time a packet with split header is received. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/common.h | 1 + drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 1 + drivers/net/ethernet/stmicro/stmmac/stmmac_main.c| 2 ++ 3 fil

[PATCH net-next 03/12] net: stmmac: xgmac: Correctly return that RX descriptor is not last one

2019-08-09 Thread Jose Abreu
Return the correct value when RX descriptor is not the last one. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c b/drivers/net/ether

[PATCH net-next 01/12] net: stmmac: Get correct timestamp values from XGMAC

2019-08-09 Thread Jose Abreu
TX Timestamp in XGMAC comes from MAC instead of descriptors. Implement this in a new callback. Also, RX Timestamp in XGMAC must be cheked against corruption and we need a barrier to make sure that descriptor fields are read correctly. Signed-off-by: Jose Abreu --- .../net/ethernet/stmicro/stmma

[net-next 02/15] ice: Use the software based tail when checking for hung Tx ring

2019-08-09 Thread Jeff Kirsher
From: Brett Creeley Currently in ice_get_tx_pending we try to read a Tx ring's tail. This is then compared with the software based head (next_to_clean) to determine if we have pending work. This will never work because reading of the Tx ring's tail is no longer supported. Fix this by using the so

[net-next 13/15] ice: Move VF resources definition to SR-IOV specific file

2019-08-09 Thread Jeff Kirsher
From: Akeem G Abodunrin In order to use some of the VF resources definition in the SR-IOV specific virtchnl header file, this patch moves applicable code to ice_virtchnl_pf.h file accordingly... and they should have been defined in the destination file originally. Signed-off-by: Akeem G Abodunri

[net-next 12/15] ice: Increase size of Mailbox receive queue for many VFs

2019-08-09 Thread Jeff Kirsher
From: Brett Creeley Currently we use the ICE_MBXQ_LEN for both the Mailbox send and receive queues that are used to communicate with VFs. This is fine for the send queue because the PF driver will lock the queue for every single send, but for the Mailbox receive queue every VF is posting to its M

[net-next 05/15] ice: fix set pause param autoneg check

2019-08-09 Thread Jeff Kirsher
From: Paul Greenwalt When ETHTOOL_GLINKSETTINGS is defined get pause param pause->autoneg reports SW configured setting, however when not defined get pause param pause->autoneg reports the link status. Set pause param needs to compare pause->autoneg with the same source as get pause param to bloc

  1   2   >