Fri, Aug 09, 2019 at 11:26:35PM CEST, jakub.kicin...@netronome.com wrote: >On Fri, 9 Aug 2019 13:05:12 +0200, Jiri Pirko wrote: >> From: Jiri Pirko <j...@mellanox.com> >> >> Register couple of devlink params, one generic, one driver-specific. >> Make the values available over debugfs. >> >> Example: >> $ echo "111" > /sys/bus/netdevsim/new_device >> $ devlink dev param >> netdevsim/netdevsim111: >> name max_macs type generic >> values: >> cmode driverinit value 32 >> name test1 type driver-specific >> values: >> cmode driverinit value true >> $ cat /sys/kernel/debug/netdevsim/netdevsim111/max_macs >> 32 >> $ cat /sys/kernel/debug/netdevsim/netdevsim111/test1 >> Y >> $ devlink dev param set netdevsim/netdevsim111 name max_macs cmode >> driverinit value 16 >> $ devlink dev param set netdevsim/netdevsim111 name test1 cmode driverinit >> value false >> $ devlink dev reload netdevsim/netdevsim111 >> $ cat /sys/kernel/debug/netdevsim/netdevsim111/max_macs >> 16 >> $ cat /sys/kernel/debug/netdevsim/netdevsim111/test1 >> >> Signed-off-by: Jiri Pirko <j...@mellanox.com> > >The netdevsim patch looks good, what's the plan for tests?
I have this and a follow-up regions implementation for testing purposes (netns notificatiosn). I will also need this for syzkaller. Selftest I have scheduled right after. > >We don't need much perhaps what you have in the commit message >as a script which can be run by automated bots would be sufficient?