On Fri, 9 Aug 2019 22:32:44 +0900, Daniel T. Lee wrote: > Currently, bpftool net only supports dumping progs attached on the > interface. To attach XDP prog on interface, user must use other tool > (eg. iproute2). By this patch, with `bpftool net attach/detach`, user > can attach/detach XDP prog on interface. > > # bpftool prog > 16: xdp name xdp_prog1 tag 539ec6ce11b52f98 gpl > loaded_at 2019-08-07T08:30:17+0900 uid 0 > ... > 20: xdp name xdp_fwd_prog tag b9cb69f121e4a274 gpl > loaded_at 2019-08-07T08:30:17+0900 uid 0 > > # bpftool net attach xdpdrv id 16 dev enp6s0np0 > # bpftool net > xdp: > enp6s0np0(4) driver id 16 > > # bpftool net attach xdpdrv id 20 dev enp6s0np0 overwrite > # bpftool net > xdp: > enp6s0np0(4) driver id 20 > > # bpftool net detach xdpdrv dev enp6s0np0 > # bpftool net > xdp: > > > While this patch only contains support for XDP, through `net > attach/detach`, bpftool can further support other prog attach types. > > XDP attach/detach tested on Mellanox ConnectX-4 and Netronome Agilio.
Looks good to me now*, thanks! Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> * apart from the entire duplication thing.
