On 09.08.2019 21:18, Andrew Lunn wrote:
>> + }, {
>> + PHY_ID_MATCH_EXACT(0x001cca50),
>
> Hi Heiner
>
Hi Andrew,
> With the Marvell driver, i looked at the range of IDs the PHYs where
> using. The switch, being MDIO based, also has ID values. The PHY range
> and the switch range are well separated, and it seems unlikely Marvell
> would reuse a switch ID in a PHY which was not compatible with the
> PHY.
>
> Could you explain why you picked this value for the PHY? What makes
> you think it is not in use by another Realtek PHY?
>
0x001cc800 being the Realtek OUI, I've seen only PHY's with ID
0x001cc8XX and 0x001cc9XX so far. Realtek doesn't seem to have such
a clear separation between PHY and switch PHY ID's.
Example:
0x001cc961 (RTL8366, switch)
0x001cc916 (RTL8211F, PHY)
Last digit of the model is used as model number.
I did the same and used 5 as model number (from RTL8125).
Revision number is set to 0 because RTL8125 is brand-new.
I chose a PHY ID in 0x001ccaXX range because it isn't used by
Realtek AFAIK.
> Thanks
> Andrew
>
Heiner
